Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mock adapters to separate crates #1128

Merged
merged 18 commits into from
Nov 2, 2023
Merged

Conversation

citizen-stig
Copy link
Member

@citizen-stig citizen-stig commented Nov 1, 2023

Description

  • Remove mocks feature in sov-rollup-interface
  • Add 2 new crates: sov-mock-da and sov-mock-zkvm
  • Remove verifier feature from all DA adapters
  • demo-simple-stf was calling "native" method from BlobReader. There is some work needs to be done: demo-simple-stf uses native code inside apply_slot. #1129

(!) Note. sov-mock-da should be imported with "native" flag if any module is imported with native flag, because modules indirectly import rollup-interface with native, which means that sov-mock-da can have not fully implement BlobReader if it also does not have "native"

Testing

Existing tests are passing

Docs

Documentation has been updated

@citizen-stig citizen-stig self-assigned this Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #1128 (c7848a9) into nightly (5d61e35) will decrease coverage by 0.1%.
Report is 1 commits behind head on nightly.
The diff coverage is 59.4%.

Files Coverage Δ
adapters/mock-da/src/service.rs 100.0% <ø> (ø)
adapters/mock-da/src/types/address.rs 89.2% <ø> (ø)
adapters/mock-da/src/validity_condition.rs 60.8% <ø> (ø)
adapters/mock-zkvm/src/lib.rs 98.4% <100.0%> (ø)
full-node/db/sov-db/src/ledger_db/rpc.rs 84.4% <ø> (ø)
full-node/sov-sequencer/src/lib.rs 93.0% <ø> (ø)
...tations/integration-tests/src/chain_state/tests.rs 97.1% <100.0%> (+<0.1%) ⬆️
...implementations/sov-prover-incentives/src/tests.rs 100.0% <ø> (ø)
...lementations/sov-sequencer-registry/src/genesis.rs 100.0% <ø> (ø)
module-system/sov-modules-api/src/lib.rs 84.9% <ø> (ø)
... and 8 more

@citizen-stig citizen-stig changed the title Move mock adapters to separate create Move mock adapters to separate crates Nov 1, 2023
@citizen-stig citizen-stig marked this pull request as ready for review November 1, 2023 19:22
Copy link
Member

@bkolad bkolad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please also update sov-seq-starter with the relevant changes.

@citizen-stig citizen-stig added this pull request to the merge queue Nov 2, 2023
Merged via the queue into nightly with commit 2df08fd Nov 2, 2023
16 checks passed
@citizen-stig citizen-stig deleted the nikolai/move-mock-adapters branch November 2, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants