Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sov-rollup-starter with RollupTemplate #1082

Merged
merged 8 commits into from
Oct 20, 2023

Conversation

bkolad
Copy link
Member

@bkolad bkolad commented Oct 20, 2023

Description

This PR updates sov-rollup-starter with the new RollupTemplate which simplifies rollup creation.
The executable Readme will be provided in the next PR.

Testing

Added tests in sov-rollup-starter

Docs

Docs will be provided later.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #1082 (a6d3c29) into nightly (08e842f) will decrease coverage by 0.1%.
The diff coverage is 69.3%.

Files Coverage Δ
...dule-system/sov-modules-rollup-template/src/lib.rs 90.7% <100.0%> (-0.2%) ⬇️
sov-rollup-starter/src/register_sequencer.rs 100.0% <100.0%> (ø)
sov-rollup-starter/src/rollup.rs 100.0% <100.0%> (+8.7%) ⬆️
sov-rollup-starter/src/bin/node.rs 0.0% <0.0%> (ø)

... and 2 files with indirect coverage changes

@bkolad bkolad force-pushed the blaze/update_rollup_starter branch from 58661cd to 9063fa7 Compare October 20, 2023 10:12
@bkolad bkolad changed the title WIP: Update sov-rollup-starter with RollupTemplate Update sov-rollup-starter with RollupTemplate Oct 20, 2023
@bkolad bkolad marked this pull request as ready for review October 20, 2023 10:13
@bkolad bkolad requested a review from vlopes11 October 20, 2023 10:14
Copy link
Contributor

@vlopes11 vlopes11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Added a couple of preliminary questions for the definitive review

sov-rollup-starter/src/bin/node.rs Outdated Show resolved Hide resolved
sov-rollup-starter/src/bin/node.rs Outdated Show resolved Hide resolved
sov-rollup-starter/src/register_sequencer.rs Show resolved Hide resolved
sov-rollup-starter/src/register_sequencer.rs Outdated Show resolved Hide resolved
sov-rollup-starter/src/rollup.rs Show resolved Hide resolved
sov-rollup-starter/src/rollup.rs Show resolved Hide resolved
sov-rollup-starter/src/rollup.rs Outdated Show resolved Hide resolved
sov-rollup-starter/src/rollup.rs Show resolved Hide resolved
@bkolad bkolad enabled auto-merge October 20, 2023 12:32
Copy link
Contributor

@vlopes11 vlopes11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bkolad bkolad added this pull request to the merge queue Oct 20, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 20, 2023
@bkolad bkolad added this pull request to the merge queue Oct 20, 2023
Merged via the queue into nightly with commit 35379ab Oct 20, 2023
13 checks passed
@bkolad bkolad deleted the blaze/update_rollup_starter branch October 20, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants