Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

demo-simple-stf uses native code inside apply_slot. #1129

Open
citizen-stig opened this issue Nov 1, 2023 · 0 comments
Open

demo-simple-stf uses native code inside apply_slot. #1129

citizen-stig opened this issue Nov 1, 2023 · 0 comments
Assignees
@dubbelosix
Labels
bug Something isn't working documentation Improvements or additions to documentation Small Use this label for quick cleanup and maintenance tasks

Comments

@citizen-stig
Copy link
Member

Summary

demo-simple-stf package has several issues:

  • CheckHashPreimageStf uses BlobReaderTrait::full_data which is not available in ZK, so this STF cannot be verified
  • README.md is outdated

Desired outcome

  • Accomodate correct usage of
@citizen-stig citizen-stig added bug Something isn't working documentation Improvements or additions to documentation Small Use this label for quick cleanup and maintenance tasks labels Nov 1, 2023
@citizen-stig citizen-stig mentioned this issue Nov 1, 2023
Merged
@dubbelosix dubbelosix self-assigned this Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dubbelosix dubbelosix

Labels
bug Something isn't working documentation Improvements or additions to documentation Small Use this label for quick cleanup and maintenance tasks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dubbelosix @citizen-stig