Fix Java ITs #9635
Merged
Fix Java ITs #9635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastien-marichal
force-pushed
the
sma/its-fix
branch
from
f25cd16
to
6ef1736
Compare
| @@ -64,7 +64,8 @@ public void logsContainInfo() { | |||
| .contains("WARN: SonarScanner for .NET detected only TEST files and no MAIN files for C# in the current solution. " + | |||
| "Only TEST-code related results will be imported to your SonarQube/SonarCloud project. " + | |||
| "Many of our rules (e.g. vulnerabilities) are raised only on MAIN-code. " + | |||
| "Read more about how the SonarScanner for .NET detects test projects: https://github.com/SonarSource/sonar-scanner-msbuild/wiki/Analysis-of-product-projects-vs.-test-projects"); | |||
| "Read more about how the SonarScanner for .NET detects test projects: https://github.com/SonarSource/sonar-scanner-msbuild/wiki/Analysis-of-product-projects-vs.-test-projects", | |||
| "Multi-Language analysis is enabled. If this was not intended, please set \"/d:sonar.scanner.scanAll=false\" in the begin step."); | |||
|
|
|||
| assertThat(buildResult.getLogsLines(l -> l.contains("INFO"))).contains( | |||
| "INFO: Found 1 MSBuild VB.NET project: 1 MAIN project.", | |||
There was a problem hiding this comment.
Two lines below will probably still fail:
TestUtils.verifyNoGuiWarnings(ORCHESTRATOR, buildResult);
you need to assert the GUI warning there as well
sebastien-marichal
force-pushed
the
sma/its-fix
branch
from
6ef1736
to
c36dea4
Compare
|
|
github-actions
bot
assigned gregory-paidis-sonarsource and unassigned sebastien-marichal
github-actions
bot
assigned sebastien-marichal and unassigned gregory-paidis-sonarsource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.