Reproducer for S1192 FP: SQL Named Parameters #9593
Conversation
analyzers/tests/SonarAnalyzer.Test/TestCases/StringLiteralShouldNotBeDuplicated.cs
Outdated
Show resolved
Hide resolved
zsolt-kolbay-sonarsource
requested review from
Tim-Pohlmann and
sebastien-marichal
github-actions
bot
assigned Tim-Pohlmann and sebastien-marichal and unassigned zsolt-kolbay-sonarsource and Tim-Pohlmann
| public class SqlCommand | ||
| { | ||
| public string CommandText { get; } | ||
| public SqlCommand(string commandText) => CommandText = commandText; | ||
| public void AddParameter(SqlParameter parameter) { } | ||
| public object ExecuteQuery() => null; | ||
| } | ||
|
|
||
| public class SqlParameter | ||
| { | ||
| public string Name { get; } | ||
| public string Value { get; } | ||
| public SqlParameter(string name, string value) | ||
| { | ||
| Name = name; | ||
| Value = value; | ||
| } | ||
| } |
There was a problem hiding this comment.
To be sure, shouldn't those be in the Dapper namespace?
There was a problem hiding this comment.
I originally wanted to create some dummy classes, so that the UT doesn't need to load Dapper and its dependencies.
But a real-world example is probably better. I changed the test case and moved it to a dedicated test file.
There was a problem hiding this comment.
Optional: I think those test cases could be in a dedicated .Dapper.cs file.
There was a problem hiding this comment.
I changed the test case and moved it to a dedicated test file.
| @@ -58,6 +58,16 @@ public class StringLiteralShouldNotBeDuplicatedTest | |||
| .WithOptions(ParseOptionsHelper.FromCSharp11) | |||
| .Verify(); | |||
|
|
|||
| [TestMethod] | |||
| public void StringLiteralShouldNotBeDuplicated_CSharp_Dapper() => | |||
There was a problem hiding this comment.
Nitpick
| public void StringLiteralShouldNotBeDuplicated_CSharp_Dapper() => | |
| public void StringLiteralShouldNotBeDuplicated_CS_Dapper() => |
There was a problem hiding this comment.
Is there any reason not to move those changes to a .Dapper.vb file?
|
|
Reproduces #9569