Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on Google Guava library #9546

Merged
merged 5 commits into from
Jul 23, 2024
Merged

Remove dependency on Google Guava library #9546

merged 5 commits into from
Jul 23, 2024

Conversation

zsolt-kolbay-sonarsource
Copy link
Contributor

Fixes #5547

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource marked this pull request as ready for review July 23, 2024 11:49
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 23, 2024

Quality Gate Passed Quality Gate passed for 'Sonar .NET Java Plugin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 23, 2024

Quality Gate Passed Quality Gate passed for 'SonarAnalyzer for .NET'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

mary-georgiou-sonarsource
mary-georgiou-sonarsource approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mary-georgiou-sonarsource mary-georgiou-sonarsource merged commit 3a68155 into master Jul 23, 2024
19 checks passed
@mary-georgiou-sonarsource mary-georgiou-sonarsource deleted the Zsolt/remove-guava branch July 23, 2024 14:02
@andrei-epure-sonarsource
Copy link
Contributor

Was there a visible difference in the size of the plugin after this change?

@pavel-mikula-sonarsource
Copy link
Contributor

No, it was only used in UTs, so this is expected.
We've already checked this with Zsolt, as I was also curious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mary-georgiou-sonarsource mary-georgiou-sonarsource mary-georgiou-sonarsource approved these changes

Assignees

@mary-georgiou-sonarsource mary-georgiou-sonarsource

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove dependency on guava
4 participants
@zsolt-kolbay-sonarsource @andrei-epure-sonarsource @pavel-mikula-sonarsource @mary-georgiou-sonarsource