Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S3963 FP: Static constructor with conditional and no static filed initialization #9512

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Fix S3963 FP: Static constructor with conditional and no static filed initialization #9512

merged 3 commits into from
Jul 11, 2024

Conversation

sebastien-marichal
Copy link
Contributor

Fixes #6343

mary-georgiou-sonarsource
mary-georgiou-sonarsource approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - mino polishing - ignore if you wish as it does not worth blocking the whole PR for this.

analyzers/src/SonarAnalyzer.CSharp/Rules/InitializeStaticFieldsInline.cs Outdated
@@ -54,7 +54,7 @@ public sealed class InitializeStaticFieldsInline : SonarDiagnosticAnalyzer
.Distinct()
.Count();
var hasIfOrSwitch = Array.Exists(bodyDescendantNodes, x => x.IsAnyKind(SyntaxKind.IfStatement, SyntaxKind.SwitchStatement));
if ((hasIfOrSwitch && assignedFieldCount <= 1)
if ((hasIfOrSwitch && assignedFieldCount == 1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one line :)

@sebastien-marichal sebastien-marichal enabled auto-merge (squash) July 11, 2024 11:53
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 11, 2024

Quality Gate Passed Quality Gate passed for 'Sonar .NET Java Plugin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 11, 2024

Quality Gate Passed Quality Gate passed for 'SonarAnalyzer for .NET'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sebastien-marichal sebastien-marichal merged commit bc2307e into master Jul 11, 2024
26 checks passed
@sebastien-marichal sebastien-marichal deleted the sma/s3963-fp branch July 11, 2024 12:18
@sebastien-marichal
Copy link
Contributor Author

Peach validation:

  • 39 Lost issues => All TNs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mary-georgiou-sonarsource mary-georgiou-sonarsource mary-georgiou-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix S3963 FP: Static constructor with conditional and no static filed initialization
2 participants
@sebastien-marichal @mary-georgiou-sonarsource