Merge pull request #273 from Somfic/dev
1136 new problems found by Qodana for .NET
Qodana for .NET
1136 new problems were found
| Inspection name | Severity | Problems |
|---|---|---|
Auto-property accessor is never used (non-private accessibility) |
🔶 Warning | 82 |
Non-nullable member is uninitialized. |
🔶 Warning | 58 |
Redundant using directive |
🔶 Warning | 19 |
Missing XML comment for publicly visible type or member |
🔶 Warning | 11 |
Dereference of a possibly null reference. |
🔶 Warning | 8 |
Possible null reference argument for a parameter. |
🔶 Warning | 8 |
Redundant member initializer |
🔶 Warning | 7 |
Type member is never used (private accessibility) |
🔶 Warning | 7 |
Get-only auto-property is never assigned |
🔶 Warning | 6 |
Unused local variable |
🔶 Warning | 6 |
Possible 'null' assignment to non-nullable entity |
🔶 Warning | 3 |
Possible null reference assignment. |
🔶 Warning | 3 |
Non-accessed field (private accessibility) |
🔶 Warning | 3 |
Possible 'System.NullReferenceException' |
🔶 Warning | 3 |
Return type of a function can be non-nullable |
🔶 Warning | 3 |
Invalid XML documentation comment |
🔶 Warning | 2 |
Redundant 'object.ToString()' call |
🔶 Warning | 2 |
Auto-property accessor is never used (private accessibility) |
🔶 Warning | 2 |
Field is never used |
🔶 Warning | 2 |
Async function without await expression |
🔶 Warning | 1 |
Possible null reference return. |
🔶 Warning | 1 |
Nullability of return type doesn't match implicitly implemented member (possibly because of nullability attributes). |
🔶 Warning | 1 |
Expression is always 'true' or 'false' according to nullable reference types' annotations |
🔶 Warning | 1 |
Usage of <inheritdoc /> is invalid |
🔶 Warning | 1 |
The pattern is redundant, it does not produce any runtime checks |
🔶 Warning | 1 |
Assignment is not used |
🔶 Warning | 1 |
Redundant cast |
🔶 Warning | 1 |
Type member is never used (non-private accessibility) |
◽️ Notice | 725 |
Type is never used (non-private accessibility) |
◽️ Notice | 71 |
Type member is never accessed via base type (non-private accessibility) |
◽️ Notice | 26 |
Auto-property can be made get-only (non-private accessibility) |
◽️ Notice | 7 |
Class is never instantiated (non-private accessibility) |
◽️ Notice | 7 |
Member can be made private (non-private accessibility) |
◽️ Notice | 7 |
Use explicit or implicit modifier definition for type members |
◽️ Notice | 5 |
Invert 'if' statement to reduce nesting |
◽️ Notice | 5 |
Member can be made static (shared) (private accessibility) |
◽️ Notice | 5 |
Field can be made readonly (private accessibility) |
◽️ Notice | 4 |
Use preferred style for trailing comma before new line in multiline lists |
◽️ Notice | 3 |
Some values of the enum are not processed inside 'switch' statement and are handled via default section |
◽️ Notice | 3 |
'if' statement can be rewritten as '?:' expression |
◽️ Notice | 2 |
'if-return' statement can be rewritten as 'return' statement |
◽️ Notice | 2 |
Convert 'if' statement into 'switch' |
◽️ Notice | 2 |
Redundant empty argument list on object creation expression |
◽️ Notice | 2 |
Return type can be IEnumerable<T> (non-private accessibility) |
◽️ Notice | 2 |
Method return value is never used (non-private accessibility) |
◽️ Notice | 2 |
Use preferred style of 'new' expression when created type is evident |
◽️ Notice | 1 |
Remove redundant parentheses |
◽️ Notice | 1 |
Auto-property can be made get-only (private accessibility) |
◽️ Notice | 1 |
'if' statement can be rewritten as '??' expression |
◽️ Notice | 1 |
Event is never subscribed to (non-private accessibility) |
◽️ Notice | 1 |
Loop can be converted into LINQ-expression |
◽️ Notice | 1 |
Member can be made protected (non-private accessibility) |
◽️ Notice | 1 |
Redundant string interpolation |
◽️ Notice | 1 |
Redundant verbatim string prefix |
◽️ Notice | 1 |
Replace 'Substring' with range indexer |
◽️ Notice | 1 |
Add explicit 'return' or 'continue' before local functions |
◽️ Notice | 1 |
Unused parameter (non-private accessibility) |
◽️ Notice | 1 |
Use raw string |
◽️ Notice | 1 |
💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report
Contact Qodana team
Contact us at [email protected]
- Or via our issue tracker: https://jb.gg/qodana-issue
- Or share your feedback: https://jb.gg/qodana-discussions
Details
This result was published with Qodana GitHub Action
Annotations
Check notice on line 103 in EliteAPI.Tests/Parsers.cs
github-actions / Qodana for .NET
Use preferred style of 'new' expression when created type is evident
Redundant type specification
Check notice on line 177 in EliteAPI/Bindings/BindingsParser.cs
github-actions / Qodana for .NET
Remove redundant parentheses
Redundant parentheses
Check notice on line 23 in EliteAPI.Events/Status/Ship/CommanderFlags.cs
github-actions / Qodana for .NET
Use preferred style for trailing comma before new line in multiline lists
Remove trailing comma to conform to code style
Check notice on line 159 in EliteAPI.Events/Status/Ship/StatusEvent.cs
github-actions / Qodana for .NET
Use preferred style for trailing comma before new line in multiline lists
Remove trailing comma to conform to code style
Check notice on line 25 in EliteAPI.Tests/JournalManual.cs
github-actions / Qodana for .NET
Use preferred style for trailing comma before new line in multiline lists
Remove trailing comma to conform to code style
Check notice on line 101 in EliteAPI.Tests/Conventions.cs
github-actions / Qodana for .NET
Use explicit or implicit modifier definition for type members
Inconsistent modifiers style: missing 'private' modifier
Check notice on line 158 in EliteAPI.Tests/Schemas.cs
github-actions / Qodana for .NET
Use explicit or implicit modifier definition for type members
Inconsistent modifiers style: missing 'private' modifier
Check notice on line 85 in EliteAPI.Tests/Schemas.cs
github-actions / Qodana for .NET
Use explicit or implicit modifier definition for type members
Inconsistent modifiers style: missing 'private' modifier
Check notice on line 81 in EliteAPI.Tests/Conventions.cs
github-actions / Qodana for .NET
Use explicit or implicit modifier definition for type members
Inconsistent modifiers style: missing 'private' modifier
Check notice on line 105 in EliteAPI.Tests/Schemas.cs
github-actions / Qodana for .NET
Use explicit or implicit modifier definition for type members
Inconsistent modifiers style: missing 'private' modifier
Check warning on line 37 in EliteAPI/Bindings/BindingsParser.cs
github-actions / Qodana for .NET
Possible 'null' assignment to non-nullable entity
Possible 'null' assignment to non-nullable entity
Check warning on line 67 in EliteAPI/Configuration/EliteDangerousApiConfiguration.cs
github-actions / Qodana for .NET
Possible 'null' assignment to non-nullable entity
Possible 'null' assignment to non-nullable entity
Check warning on line 100 in EliteAPI/Configuration/EliteDangerousApiConfiguration.cs
github-actions / Qodana for .NET
Possible 'null' assignment to non-nullable entity
Possible 'null' assignment to non-nullable entity
Check notice on line 261 in EliteAPI.Tests/JournalManual.cs
github-actions / Qodana for .NET
Auto-property can be made get-only (non-private accessibility)
Auto-property can be made get-only
Check notice on line 10 in EliteAPI.Abstractions/Bindings/Models/InvertedSubBinding.cs
github-actions / Qodana for .NET
Auto-property can be made get-only (non-private accessibility)
Auto-property can be made get-only
Check notice on line 13 in EliteAPI.Abstractions/Events/EventPath.cs
github-actions / Qodana for .NET
Auto-property can be made get-only (non-private accessibility)
Auto-property can be made get-only
Check notice on line 263 in EliteAPI.Tests/JournalManual.cs
github-actions / Qodana for .NET
Auto-property can be made get-only (non-private accessibility)
Auto-property can be made get-only
Check notice on line 10 in EliteAPI.Abstractions/Bindings/Models/DeadzoneSubBinding.cs
github-actions / Qodana for .NET
Auto-property can be made get-only (non-private accessibility)
Auto-property can be made get-only
Check notice on line 11 in EliteAPI.Abstractions/Events/EventPath.cs
github-actions / Qodana for .NET
Auto-property can be made get-only (non-private accessibility)
Auto-property can be made get-only
Check notice on line 10 in EliteAPI.Abstractions/Bindings/Models/ToggleSubBinding.cs
github-actions / Qodana for .NET
Auto-property can be made get-only (non-private accessibility)
Auto-property can be made get-only
Check notice on line 34 in EliteAPI/EliteDangerousApi.cs
github-actions / Qodana for .NET
Auto-property can be made get-only (private accessibility)
Auto-property can be made get-only
Check warning on line 20 in EliteAPI/Events/EventParser.cs
github-actions / Qodana for .NET
Missing XML comment for publicly visible type or member
Missing XML comment for publicly visible type or member 'EliteAPI.Events.EventParser.EventParser'
Check warning on line 17 in EliteAPI/Bindings/BindingsParser.cs
github-actions / Qodana for .NET
Missing XML comment for publicly visible type or member
Missing XML comment for publicly visible type or member 'EliteAPI.Bindings.BindingsParser.BindingsParser'
Check warning on line 12 in EliteAPI/Events/LocalisedConverter.cs
github-actions / Qodana for .NET
Missing XML comment for publicly visible type or member
Missing XML comment for publicly visible type or member 'EliteAPI.Events.LocalisedConverter'
Check warning on line 19 in EliteAPI/Readers/Reader.cs
github-actions / Qodana for .NET
Missing XML comment for publicly visible type or member
Missing XML comment for publicly visible type or member 'EliteAPI.Readers.Reader.Reader'