Google Authentication using the new API #1036
Open
+191
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Hello @CosminBd and thanks for your contribution PR |
lucasmichot
requested changes
Aug 24, 2023
|
@CosminBd could you resolve conflicts? |
|
@atymic it's good to go now |
lucasmichot
requested changes
Aug 30, 2023
atymic
reviewed
Sep 4, 2023
| @@ -70,7 +70,7 @@ parameters: | |||
| src/Gitea: '[email protected]:SocialiteProviders/Gitea.git' | |||
| src/Gitee: '[email protected]:SocialiteProviders/Gitee.git' | |||
| src/Goodreads: '[email protected]:SocialiteProviders/Goodreads.git' | |||
| src/Google: '[email protected]:SocialiteProviders/Google-Plus.git' | |||
| src/Google: '[email protected]:SocialiteProviders/Google.git' | |||
There was a problem hiding this comment.
do you mean remove? Google+ has become redundant, no?
atymic
reviewed
Sep 4, 2023
| $jwt = $this->request->credential; | ||
| $certificates = $this->fetchCertificates(); | ||
| $decoded = (array) JWT::decode($jwt, $certificates); | ||
| return $this->user = $this->mapUserToObject($decoded) |
atymic
reviewed
Sep 4, 2023
|
|
||
| protected function getAuthUrl($state) | ||
| { | ||
| // TODO: Implement getAuthUrl() method. |
atymic
reviewed
Sep 4, 2023
| */ | ||
| protected function fetchCertificates(): array | ||
| { | ||
| return collect(json_decode(file_get_contents('https://www.googleapis.com/oauth2/v1/certs'), true))->map(function ($key) { |
There was a problem hiding this comment.
What happens if getting this endpoint fails?
|
@CosminBd Hey man, is it possible to handle this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #940
Using the new Google API for authentication, which moves away from OAuth and to using JWT's for identifing users.
There are still a couple of things to be fixed, mainly: