Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dev setup #915

Merged
merged 7 commits into from
Aug 4, 2023
Merged

Improve dev setup #915

merged 7 commits into from
Aug 4, 2023

Conversation

yrong
Copy link
Contributor

@yrong yrong commented Jul 31, 2023

Resolves: SNO-583

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage: 81.69% and project coverage change: -0.03% ⚠️

Comparison is base (cb7fdc8) 75.40% compared to head (cbdcbf8) 75.37%.

❗ Current head cbdcbf8 differs from pull request most recent head 8ce22d1. Consider uploading reports for the commit 8ce22d1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #915      +/-   ##
==========================================
- Coverage   75.40%   75.37%   -0.03%     
==========================================
  Files          40       40              
  Lines        1736     1734       -2     
  Branches       74       74              
==========================================
- Hits         1309     1307       -2     
  Misses        407      407              
  Partials       20       20              
Flag Coverage Δ
rust 75.98% <81.69%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
parachain/pallets/control/src/lib.rs 94.28% <0.00%> (ø)
parachain/pallets/inbound-queue/src/lib.rs 65.95% <0.00%> (ø)
parachain/pallets/outbound-queue/src/api.rs 0.00% <0.00%> (ø)
parachain/primitives/beacon/src/serde_utils.rs 65.11% <0.00%> (ø)
parachain/primitives/core/src/outbound.rs 17.18% <0.00%> (-0.28%) ⬇️
parachain/primitives/ethereum/src/receipt.rs 79.31% <0.00%> (ø)
parachain/primitives/router/src/inbound/mod.rs 48.59% <ø> (ø)
...hain/pallets/outbound-queue/merkle-tree/src/lib.rs 64.94% <50.00%> (ø)
parachain/primitives/router/src/outbound/mod.rs 87.96% <95.45%> (ø)
...achain/pallets/ethereum-beacon-client/src/impls.rs 56.81% <100.00%> (ø)
... and 5 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yrong yrong marked this pull request as ready for review July 31, 2023 03:20
Copy link
Contributor

@claravanstaden claravanstaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@yrong yrong requested a review from doubledup July 31, 2023 22:10
Copy link
Contributor

@doubledup doubledup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant!

scripts/generate_bindings.sh Outdated Show resolved Hide resolved
scripts/init.sh Outdated Show resolved Hide resolved
web/init.sh Outdated Show resolved Hide resolved
hooks/pre-commit Outdated Show resolved Hide resolved
hooks/pre-commit Outdated Show resolved Hide resolved
@yrong yrong requested a review from vgeddes August 1, 2023 01:09
flake.nix Outdated Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
parachain/pallets/ethereum-beacon-client/src/lib.rs Outdated Show resolved Hide resolved
scripts/init.sh Outdated Show resolved Hide resolved
scripts/init.sh Outdated Show resolved Hide resolved
scripts/init.sh Outdated Show resolved Hide resolved
yrong and others added 2 commits August 2, 2023 21:15
scripts/init.sh Outdated Show resolved Hide resolved
smoketest/make-bindings.sh Outdated Show resolved Hide resolved
Copy link
Collaborator

@vgeddes vgeddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@yrong yrong merged commit b92b1db into main Aug 4, 2023
@yrong yrong deleted the ron/dev-setup branch August 4, 2023 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants