-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prep for crates io #1101
Prep for crates io #1101
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1101 +/- ##
=======================================
Coverage 80.57% 80.57%
=======================================
Files 55 55
Lines 2209 2209
Branches 72 72
=======================================
Hits 1780 1780
Misses 412 412
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
edition = "2021" | ||
edition.workspace = true | ||
authors.workspace = true | ||
repository.workspace = true | ||
license = "Apache-2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For completeness, can we add this field to all the manifests:
categories = ["cryptography::cryptocurrencies"]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 06b88e3.
@@ -2,8 +2,9 @@ | |||
name = "snowbridge-kusama-common" | |||
description = "Snowbridge Kusama Common" | |||
version = "0.0.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we can also bump the version to "0.9.0" now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 06b88e3.
|
||
Provides an API: | ||
|
||
- to prove BEEFY messages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To generate merkle proofs for outbound messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😅 Dankie! 5afeb2d
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1101 +/- ##
=======================================
Coverage 80.57% 80.57%
=======================================
Files 55 55
Lines 2209 2209
Branches 72 72
=======================================
Hits 1780 1780
Misses 412 412
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Reference authors, edition and repository in the workspace. That way, we will reference the correct values in the polkadot-sdk subtree because in that instance the workspace values are references.
Adds some minimal readme's so the crates.io docs are not empty.
Polkadot-sdk companion: Snowfork/polkadot-sdk#93