Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep for crates io #1101

Merged
merged 7 commits into from
Jan 9, 2024
Merged

Prep for crates io #1101

merged 7 commits into from
Jan 9, 2024

Conversation

claravanstaden
Copy link
Contributor

@claravanstaden claravanstaden commented Jan 9, 2024

Reference authors, edition and repository in the workspace. That way, we will reference the correct values in the polkadot-sdk subtree because in that instance the workspace values are references.

Adds some minimal readme's so the crates.io docs are not empty.

Polkadot-sdk companion: Snowfork/polkadot-sdk#93

@claravanstaden claravanstaden marked this pull request as ready for review January 9, 2024 12:40
@claravanstaden claravanstaden requested review from vgeddes, yrong and alistair-singh and removed request for vgeddes and yrong January 9, 2024 12:40
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (902f8ab) 80.57% compared to head (8ab47c7) 80.57%.
Report is 1 commits behind head on main.

❗ Current head 8ab47c7 differs from pull request most recent head fc77ca4. Consider uploading reports for the commit fc77ca4 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1101   +/-   ##
=======================================
  Coverage   80.57%   80.57%           
=======================================
  Files          55       55           
  Lines        2209     2209           
  Branches       72       72           
=======================================
  Hits         1780     1780           
  Misses        412      412           
  Partials       17       17           
Flag Coverage Δ
rust 80.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

edition = "2021"
edition.workspace = true
authors.workspace = true
repository.workspace = true
license = "Apache-2.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For completeness, can we add this field to all the manifests:

categories = ["cryptography::cryptocurrencies"]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 06b88e3.

@@ -2,8 +2,9 @@
name = "snowbridge-kusama-common"
description = "Snowbridge Kusama Common"
version = "0.0.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can also bump the version to "0.9.0" now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 06b88e3.


Provides an API:

- to prove BEEFY messages
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To generate merkle proofs for outbound messages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅 Dankie! 5afeb2d

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (902f8ab) 80.57% compared to head (5afeb2d) 80.57%.
Report is 1 commits behind head on main.

❗ Current head 5afeb2d differs from pull request most recent head e8906a7. Consider uploading reports for the commit e8906a7 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1101   +/-   ##
=======================================
  Coverage   80.57%   80.57%           
=======================================
  Files          55       55           
  Lines        2209     2209           
  Branches       72       72           
=======================================
  Hits         1780     1780           
  Misses        412      412           
  Partials       17       17           
Flag Coverage Δ
rust 80.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@vgeddes vgeddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@claravanstaden claravanstaden merged commit a90f0c9 into main Jan 9, 2024
9 checks passed
@claravanstaden claravanstaden deleted the prep-for-crates-io-round2 branch January 9, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants