Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emulated tests PR feedback #1082

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Emulated tests PR feedback #1082

merged 2 commits into from
Dec 21, 2023

Conversation

alistair-singh
Copy link
Contributor

@alistair-singh alistair-singh commented Dec 20, 2023 •
edited
Loading

@alistair-singh alistair-singh changed the title Emulated test feedback Emulated tests PR feedback Dec 20, 2023
@alistair-singh alistair-singh mentioned this pull request Dec 20, 2023
Merged
@codecov Codecov
Copy link

codecov bot commented Dec 20, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9e33df1) 80.69% compared to head (b1d8828) 80.69%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1082   +/-   ##
=======================================
  Coverage   80.69%   80.69%           
=======================================
  Files          55       55           
  Lines        2274     2274           
  Branches       71       71           
=======================================
  Hits         1835     1835           
  Misses        422      422           
  Partials       17       17
Flag Coverage Δ
rust 80.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@claravanstaden claravanstaden mentioned this pull request Dec 21, 2023
Closed
yrong
yrong approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@yrong yrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@alistair-singh alistair-singh merged commit ef079f2 into main Dec 21, 2023
7 checks passed
@alistair-singh alistair-singh deleted the alistair/emulated-tests-feedback branch December 21, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrong yrong yrong approved these changes

@claravanstaden claravanstaden claravanstaden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alistair-singh @claravanstaden @yrong