Use FromNetwork and remove EthereumLocation #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1075 +/- ##
==========================================
- Coverage 80.71% 80.69% -0.02%
==========================================
Files 55 55
Lines 2276 2274 -2
Branches 71 71
==========================================
- Hits 1837 1835 -2
Misses 422 422
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alistair-singh
force-pushed
the
alistair/use-from-network
branch
from
4fca0e3
to
ab3fdfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR feedback links:
https://github.com/paritytech/polkadot-sdk/pull/2522/files#r1430197256
https://github.com/paritytech/polkadot-sdk/pull/2522/files#r1430158269
https://github.com/paritytech/polkadot-sdk/pull/2522/files#r1430202924
https://github.com/paritytech/polkadot-sdk/pull/2522/files#r1430199412
Polkadot-sdk: Snowfork/polkadot-sdk#80
Adds comments and tests to FromNetwork.
Resolves: SNO-802