This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
forked from paritytech/polkadot-sdk
-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claravanstaden
approved these changes
Dec 20, 2023
Comment on lines
391
to
392
/// Creates an AgentId from a MultiLocation. An AgentId is a unique mapping to a Agent contract | ||
/// which acts as the sovereign account for the MultiLocation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
/// Creates an AgentId from a MultiLocation. An AgentId is a unique mapping to a Agent contract | |
/// which acts as the sovereign account for the MultiLocation. | |
/// Creates an AgentId from a MultiLocation. An AgentId is a unique mapping to a Agent contract on Ethereum | |
/// which acts as the sovereign account for the MultiLocation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved in 0d33404
@alistair-singh maybe if you have time you could do this one too? paritytech#2522 (comment) |
alistair-singh
force-pushed
the
alistair/documentation
branch
from
December 20, 2023 12:06
ebe64e6
to
b4e2aea
Compare
Addressed as many as I could find included in this PR. |
claravanstaden
pushed a commit
that referenced
this pull request
Dec 20, 2023
* rename to balance * add more comments * add comment * fix comments * more comment docs * remove ws changes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snowbridge: Snowfork/snowbridge#1076