This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
Make base fee configurable from storage #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alistair-singh
commented
Dec 16, 2023
| @@ -857,7 +860,8 @@ pub mod bridging { | |||
| /// (initially was calculated by test `OutboundQueue::calculate_fees` - ETH/ROC 1/400 and fee_per_gas 20 GWEI = 2200698000000 + *25%) | |||
| /// Needs to be more than fee calculated from DefaultFeeConfig FeeConfigRecord in snowbridge:parachain/pallets/outbound-queue/src/lib.rs | |||
| /// Polkadot uses 10 decimals, Kusama and Rococo 12 decimals. | |||
| pub const BridgeHubEthereumBaseFeeInROC: u128 = 2_750_872_500_000; | |||
| pub const DefaultBridgeHubEthereumBaseFeeInROC: u128 = 2_750_872_500_000; | |||
There was a problem hiding this comment.
Need the non-storage const for the tests as the storage modifier causes tests to panic as there is no underlyiing storage provider.
vgeddes
reviewed
Dec 16, 2023
| @@ -857,7 +860,8 @@ pub mod bridging { | |||
| /// (initially was calculated by test `OutboundQueue::calculate_fees` - ETH/ROC 1/400 and fee_per_gas 20 GWEI = 2200698000000 + *25%) | |||
| /// Needs to be more than fee calculated from DefaultFeeConfig FeeConfigRecord in snowbridge:parachain/pallets/outbound-queue/src/lib.rs | |||
| /// Polkadot uses 10 decimals, Kusama and Rococo 12 decimals. | |||
| pub const BridgeHubEthereumBaseFeeInROC: u128 = 2_750_872_500_000; | |||
| pub const DefaultBridgeHubEthereumBaseFeeInROC: u128 = 2_750_872_500_000; | |||
| pub storage BridgeHubEthereumBaseFeeInROC: u128 = DefaultBridgeHubEthereumBaseFeeInROC::get(); | |||
There was a problem hiding this comment.
Can we remove the ROC from the name, so that in production the storage key will be the same for all runtimes?
vgeddes
reviewed
Dec 16, 2023
| @@ -857,7 +860,8 @@ pub mod bridging { | |||
| /// (initially was calculated by test `OutboundQueue::calculate_fees` - ETH/ROC 1/400 and fee_per_gas 20 GWEI = 2200698000000 + *25%) | |||
| /// Needs to be more than fee calculated from DefaultFeeConfig FeeConfigRecord in snowbridge:parachain/pallets/outbound-queue/src/lib.rs | |||
| /// Polkadot uses 10 decimals, Kusama and Rococo 12 decimals. | |||
| pub const BridgeHubEthereumBaseFeeInROC: u128 = 2_750_872_500_000; | |||
| pub const DefaultBridgeHubEthereumBaseFeeInROC: u128 = 2_750_872_500_000; | |||
There was a problem hiding this comment.
Ditto, I think we should remove ROC from the name.
alistair-singh
force-pushed
the
alistair/make-base-fee-storage
branch
from
1007ee9
to
0043e6a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snowbridge: Snowfork/snowbridge#1060