Skip to content
This repository has been archived by the owner on Oct 22, 2024. It is now read-only.

Updates from upstream #60

Merged
merged 123 commits into from
Dec 6, 2023
Merged

Updates from upstream #60

merged 123 commits into from
Dec 6, 2023

Commits on Nov 16, 2023

  1. [ci] Enable zombienet jobs in PRs (paritytech#2361)

    Since preparation for the merge queues needs more time I'm enabling
    zombienet jobs in PRs CI back.
    alvicsam authored Nov 16, 2023
    Configuration menu
    Copy the full SHA
    d4c426a View commit details
    Browse the repository at this point in the history
  2. westend: remove SessionKeys migration already applied on-chain (parit…

    …ytech#2363)
    
    Westend now successfully updated to `spec: 103000`, we **have to
    remove** the session keys migration before the next release as it
    doesn't gracefully handle reapplying it.
    acatangiu authored Nov 16, 2023
    Configuration menu
    Copy the full SHA
    02e8061 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5e98803 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4ac2db8 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. add pallet nomination-pools versioned migration to kitchensink (parit…

    …ytech#2167)
    
    The versioned migrations are already there in pallet nomination-pools:
    
    https://github.com/paritytech/polkadot-sdk/blob/f6ee4781f633f0f89598f7b230595afe401da8dc/substrate/frame/nomination-pools/src/migration.rs#L27-L48
    
    Just updating the kitchensink runtime to point to them.
    
    This is also nice because it points the dev to an example of how to use
    `VersionedMigration`.
    brunopgalvao authored Nov 17, 2023
    Configuration menu
    Copy the full SHA
    596088a View commit details
    Browse the repository at this point in the history
  2. fix typo (paritytech#2377)

    cuteolaf authored Nov 17, 2023
    Configuration menu
    Copy the full SHA
    b85c64a View commit details
    Browse the repository at this point in the history
  3. bump zombienet version v1.3.80 (paritytech#2376)

    New release includes logic to move all jobs to `spot instances`.
    Thx!
    pepoviola authored Nov 17, 2023
    Configuration menu
    Copy the full SHA
    20723ea View commit details
    Browse the repository at this point in the history
  4. [NPoS] Check if staker is exposed in paged exposure storage entries (p…

    …aritytech#2369)
    
    Addresses a bug caused by
    paritytech#1189. The changes are
    still not released yet, so would like to push the fix soon so it can go
    together with the release of the above PR.
    
    `fast_unstake` checks if a staker is exposed in an era. However, this fn
    is still returning whether the staker is exposed based on the old
    storage item. This PR fixes that by looking in both old and new exposure
    storages.
    
    Also adds some integrity tests for paged exposures.
    Ank4n authored Nov 17, 2023
    Configuration menu
    Copy the full SHA
    2e001de View commit details
    Browse the repository at this point in the history
  5. Beefy: small fixes (paritytech#2378)

    Related to paritytech#2285
    
    - save the state of the BEEFY gadget after processing a finality proof.
    We need this in order to avoid skipping blocks.
    - avoid reprocessing the old state when not necessary
    serban300 authored Nov 17, 2023
    Configuration menu
    Copy the full SHA
    3ab2bc9 View commit details
    Browse the repository at this point in the history
  6. crypto: lazy_static removed, light parser for address URI added (pa…

    …ritytech#2250)
    
    The `lazy_static` package does not work well in `no-std`: it requires
    `spin_no_std` feature, which also will propagate into `std` if enabled.
    This is not what we want.
    
    This PR provides simple address uri parser which allows to get rid of
    _regex_ which was used to parse the address uri, what in turns allows to
    remove lazy_static.
    
    Three regular expressions
    (`SS58_REGEX`,`SECRET_PHRASE_REGEX`,`JUNCTION_REGEX`) were replaced with
    the parser which unifies all of them.
    
    The new parser does not support Unicode, it is ASCII only.
    
    Related to: paritytech#2044
    
    ---------
    
    Co-authored-by: Bastian Köcher <[email protected]>
    Co-authored-by: Koute <[email protected]>
    Co-authored-by: command-bot <>
    3 people authored Nov 17, 2023
    Configuration menu
    Copy the full SHA
    5007e2d View commit details
    Browse the repository at this point in the history
  7. [trivial] asset-hubs runtimes: fix incorrect doc-comments (paritytech…

    …#2384)
    
    Fix some incorrect doc-comments
    acatangiu authored Nov 17, 2023
    Configuration menu
    Copy the full SHA
    490fb66 View commit details
    Browse the repository at this point in the history
  8. Do not panic if the fdlimit call to increase the file descriptor li…

    …mit fails (paritytech#2155)
    
    # Description
    
    Sometimes changing file descriptor limits is not allowed, but there is
    no need to crash the node if/when this happens. Since `fdlimit`'s author
    decided to use panics instead of returning `Result`, we need to catch
    it.
    
    # Checklist
    
    - [x] My PR includes a detailed description as outlined in the
    "Description" section above
    - [ ] My PR follows the [labeling requirements](CONTRIBUTING.md#Process)
    of this project (at minimum one label for `T`
      required)
    - [ ] I have made corresponding changes to the documentation (if
    applicable)
    - [ ] I have added tests that prove my fix is effective or that my
    feature works (if applicable)
    
    ---------
    
    Co-authored-by: Koute <[email protected]>
    nazar-pc and koute authored Nov 17, 2023
    Configuration menu
    Copy the full SHA
    079b14f View commit details
    Browse the repository at this point in the history
  9. Relax force_default_xcm_version for testnet system parachains (pari…

    …tytech#2385)
    
    This PR fixes two things:
    - relax `force_default_xcm_version` for testnet system parachains (e.g.
    BridgeHubWestend has now 2 and there is no way to change it to 3, so we
    need to call `force_xcm_version(3)` for every parachain that it is
    connected to, because we send XCMv3 messages)
    - add `Storage` item to `PolkadotXcm` pallet definition (now we cannot
    see storage items for `pallet_xcm` in PJS)
    
    
    ## TODO
    
    - [ ] when merged open PR to `polkadot-fellows/runtimes` repo
    bkontur authored Nov 17, 2023
    Configuration menu
    Copy the full SHA
    0385902 View commit details
    Browse the repository at this point in the history
  10. Make collator RPC mode non-experimental (paritytech#2381)

    The `--relay-chain-rpc-urls` CLI flag has been available for a while
    now. We have collators with this running and parachain teams are also
    using it. It should be fine now to remove the experimental status.
    skunert authored Nov 17, 2023
    Configuration menu
    Copy the full SHA
    9e34163 View commit details
    Browse the repository at this point in the history
  11. Fix migrations and add CI check for new system chains (paritytech#2336)

    Westend Collectives migration CI check can be fixed once we have
    paritytech/try-runtime-cli#58, will open another
    PR once it is available.
    
    - [x] Remove deprecated `DmpQueue` pallet from Rococo Contracts, the
    migration is complete
    - [x] Fix Asset Hub Rococo storage versions
    - [x] Add migration check CI for Asset Hub Rococo and Westend Bridge Hub
    liamaharon authored Nov 17, 2023
    Configuration menu
    Copy the full SHA
    82912ac View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    1d1c371 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2023

  1. Bump secp256k1 from 0.24.3 to 0.28.0 (paritytech#2357)

    Bumps [secp256k1](https://github.com/rust-bitcoin/rust-secp256k1) from
    0.24.3 to 0.28.0.
    <details>
    <summary>Changelog</summary>
    <p><em>Sourced from <a
    href="https://github.com/rust-bitcoin/rust-secp256k1/blob/master/CHANGELOG.md">secp256k1's
    changelog</a>.</em></p>
    <blockquote>
    <h1>0.28.0 - 2023-10-23</h1>
    <ul>
    <li>Add bindings to the ElligatorSwift implementation <a
    href="https://redirect.github.com/rust-bitcoin/rust-secp256k1/pull/627">#627</a></li>
    <li>Depend on recent release of <code>bitcoin_hashes</code> v0.13.0 <a
    href="https://redirect.github.com/rust-bitcoin/rust-secp256k1/pull/621">#621</a></li>
    <li>Add a verify function to <code>PublicKey</code> <a
    href="https://redirect.github.com/rust-bitcoin/rust-secp256k1/pull/618">#618</a></li>
    <li>Add serialize function for schnorr::Signature <a
    href="https://redirect.github.com/rust-bitcoin/rust-secp256k1/pull/607">#607</a></li>
    <li>Bump MSRV to 1.48 <a
    href="https://redirect.github.com/rust-bitcoin/rust-secp256k1/pull/595">#595</a></li>
    <li>Remove implementations of <code>PartialEq</code>, <code>Eq</code>,
    <code>PartialOrd</code>, <code>Ord</code>, and <code>Hash</code> from
    the
    <code>impl_array_newtype</code> macro. Users will now need to derive
    these traits if they are wanted.</li>
    </ul>
    <h1>0.27.0 - 2023-03-15</h1>
    <ul>
    <li><a
    href="https://redirect.github.com/rust-bitcoin/rust-secp256k1/pull/588">Depend
    on newly release <code>bitcoin_hashes</code> v0.12</a>.</li>
    <li><a
    href="https://redirect.github.com/rust-bitcoin/rust-secp256k1/pull/578">Implement
    <code>Debug</code> trait for <code>Scalar</code> type</a>.</li>
    <li><a
    href="https://redirect.github.com/rust-bitcoin/rust-secp256k1/pull/582">Implement
    <code>insecure-erase</code></a>.</li>
    </ul>
    <h1>0.26.0 - 2202-12-19</h1>
    <ul>
    <li>Update libsecp25k1 to v0.2.0</li>
    </ul>
    <h1>0.25.0 - 2022-12-07</h1>
    <ul>
    <li><a
    href="https://redirect.github.com/rust-bitcoin/rust-secp256k1/pull/548">Fix
    soundness issue with <code>preallocated_gen_new</code></a></li>
    <li>Update to <code>secp256k1-sys</code> <a
    href="https://redirect.github.com/rust-bitcoin/rust-secp256k1/pull/549">v0.7.0</a></li>
    <li>Use type system to <a
    href="https://redirect.github.com/rust-bitcoin/rust-secp256k1/pull/483">improve
    safety</a>.</li>
    <li><a
    href="https://redirect.github.com/rust-bitcoin/rust-secp256k1/pull/490">Change
    secp256k1-sys symbol names to 0_6_1</a>.</li>
    <li><a
    href="https://redirect.github.com/rust-bitcoin/rust-secp256k1/pull/499">Introduce
    <code>rustfmt</code></a> to the codebase.</li>
    <li><a
    href="https://redirect.github.com/rust-bitcoin/rust-secp256k1/pull/507">Make
    all raw pointer methods go through the CPtr trait</a>.</li>
    <li><a
    href="https://redirect.github.com/rust-bitcoin/rust-secp256k1/pull/518">Make
    comparison functions stable</a>.</li>
    <li><a
    href="https://redirect.github.com/rust-bitcoin/rust-secp256k1/pull/512">Remove</a>
    public constant <code>ONE_KEY</code> (consider using
    <code>FromStr</code> as a replacement).</li>
    </ul>
    <h1>0.24.1 - 2022-10-25</h1>
    <ul>
    <li><a
    href="https://redirect.github.com/rust-bitcoin/rust-secp256k1/issues/491">Fix
    broken deserialization logic of <code>KeyPair</code></a> that previously
    always panicked. After the patch deserialization only panics if neither
    the <code>global-context</code> nor the <code>alloc</code> (default)
    feature is active.</li>
    </ul>
    <h1>0.24.0 - 2022-07-20</h1>
    <ul>
    <li>Upgrade to new release of <a
    href="https://github.com/rust-bitcoin/bitcoin_hashes/releases/tag/0.11.0">bitcoin_hashes</a>.</li>
    </ul>
    <h1>0.23.4 - 2022-07-14</h1>
    <ul>
    <li><a
    href="https://redirect.github.com/rust-bitcoin/rust-secp256k1/pull/474">Disable
    automatic rerandomization of contexts under WASM</a></li>
    </ul>
    <h1>0.23.3 - 2022-06-29</h1>
    <ul>
    <li><a
    href="https://redirect.github.com/rust-bitcoin/rust-secp256k1/pull/465">Add
    must_use for mut self key manipulation methods</a></li>
    <li><a
    href="https://redirect.github.com/rust-bitcoin/rust-secp256k1/pull/466">Fix
    fuzzing feature guard</a></li>
    </ul>
    <h1>0.23.2 - 2022-06-27</h1>
    <!-- raw HTML omitted -->
    </blockquote>
    <p>... (truncated)</p>
    </details>
    <details>
    <summary>Commits</summary>
    <ul>
    <li><a
    href="https://github.com/rust-bitcoin/rust-secp256k1/commit/7de09c8050da12a13ef9ee3850597f69c887952d"><code>7de09c8</code></a>
    Merge <a
    href="https://redirect.github.com/rust-bitcoin/rust-secp256k1/issues/256">rust-bitcoin/rust-secp256k1256</a>:
    Tracking PR for release: `secp256k1 v0...</li>
    <li><a
    href="https://github.com/rust-bitcoin/rust-secp256k1/commit/3dc5b165401f249c01a88cec54061301cffd97a0"><code>3dc5b16</code></a>
    Bump version to v0.28.0</li>
    <li><a
    href="https://github.com/rust-bitcoin/rust-secp256k1/commit/3aada83180beec2b9f5ab8e7b9280a5517d3bcde"><code>3aada83</code></a>
    Merge <a
    href="https://redirect.github.com/rust-bitcoin/rust-secp256k1/issues/256">rust-bitcoin/rust-secp256k1256</a>:
    Add bindings to the ElligatorSwift imp...</li>
    <li><a
    href="https://github.com/rust-bitcoin/rust-secp256k1/commit/39febcb866ce285d53052a3636602f04483aa710"><code>39febcb</code></a>
    Create rust-bidings</li>
    <li><a
    href="https://github.com/rust-bitcoin/rust-secp256k1/commit/da4f67b274c3061717723a568cfb182e4e2e7cce"><code>da4f67b</code></a>
    Merge <a
    href="https://redirect.github.com/rust-bitcoin/rust-secp256k1/issues/256">rust-bitcoin/rust-secp256k1256</a>:
    Update vendored lib secp256k1 to v0.4.0</li>
    <li><a
    href="https://github.com/rust-bitcoin/rust-secp256k1/commit/80b2a8d4aa6ffa72041d569eab2278cd8c1ace2a"><code>80b2a8d</code></a>
    Update vendored libsecp to v0.4.0</li>
    <li><a
    href="https://github.com/rust-bitcoin/rust-secp256k1/commit/d2285c929a086276ce6d1670d795c49191e30c65"><code>d2285c9</code></a>
    ci: Remove MIPS* from CI</li>
    <li><a
    href="https://github.com/rust-bitcoin/rust-secp256k1/commit/0d58f50d523b40a78de0b87146208e3ad338c8ba"><code>0d58f50</code></a>
    ci: generalize grp in &quot;illegal callback&quot; test</li>
    <li><a
    href="https://github.com/rust-bitcoin/rust-secp256k1/commit/acf9ac13e9f8df84dd52d2f012cda7211a6af10c"><code>acf9ac1</code></a>
    delete <code>test_manual_create_destroy</code> test</li>
    <li><a
    href="https://github.com/rust-bitcoin/rust-secp256k1/commit/04ce50891bb0d49be5355f5c0d82db70d7dda65a"><code>04ce508</code></a>
    lib: fix bad unit test</li>
    <li>Additional commits viewable in <a
    href="https://github.com/rust-bitcoin/rust-secp256k1/compare/secp256k1-0.24.3...secp256k1-0.28.0">compare
    view</a></li>
    </ul>
    </details>
    <br />
    
    
    [![Dependabot compatibility
    score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=secp256k1&package-manager=cargo&previous-version=0.24.3&new-version=0.28.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
    
    Dependabot will resolve any conflicts with this PR as long as you don't
    alter it yourself. You can also trigger a rebase manually by commenting
    `@dependabot rebase`.
    
    [//]: # (dependabot-automerge-start)
    [//]: # (dependabot-automerge-end)
    
    ---
    
    <details>
    <summary>Dependabot commands and options</summary>
    <br />
    
    You can trigger Dependabot actions by commenting on this PR:
    - `@dependabot rebase` will rebase this PR
    - `@dependabot recreate` will recreate this PR, overwriting any edits
    that have been made to it
    - `@dependabot merge` will merge this PR after your CI passes on it
    - `@dependabot squash and merge` will squash and merge this PR after
    your CI passes on it
    - `@dependabot cancel merge` will cancel a previously requested merge
    and block automerging
    - `@dependabot reopen` will reopen this PR if it is closed
    - `@dependabot close` will close this PR and stop Dependabot recreating
    it. You can achieve the same result by closing it manually
    - `@dependabot show <dependency name> ignore conditions` will show all
    of the ignore conditions of the specified dependency
    - `@dependabot ignore <dependency name> major version` will close this
    group update PR and stop Dependabot creating any more for the specific
    dependency's major version (unless you unignore this specific
    dependency's major version or upgrade to it yourself)
    - `@dependabot ignore <dependency name> minor version` will close this
    group update PR and stop Dependabot creating any more for the specific
    dependency's minor version (unless you unignore this specific
    dependency's minor version or upgrade to it yourself)
    - `@dependabot ignore <dependency name>` will close this group update PR
    and stop Dependabot creating any more for the specific dependency
    (unless you unignore this specific dependency or upgrade to it yourself)
    - `@dependabot unignore <dependency name>` will remove all of the ignore
    conditions of the specified dependency
    - `@dependabot unignore <dependency name> <ignore condition>` will
    remove the ignore condition of the specified dependency and ignore
    conditions
    
    
    </details>
    
    ---------
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: Liam Aharon <[email protected]>
    dependabot[bot] and liamaharon authored Nov 18, 2023
    Configuration menu
    Copy the full SHA
    794ee98 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2023

  1. Preserve artifact cache unless stale (paritytech#1918)

    Co-authored-by: Marcin S <[email protected]>
    eagr and mrcnski authored Nov 19, 2023
    Configuration menu
    Copy the full SHA
    b585893 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. Pools: Add MaxUnbonding to metadata (paritytech#2397)

    Ross Bulat authored Nov 20, 2023
    Configuration menu
    Copy the full SHA
    aa5705b View commit details
    Browse the repository at this point in the history
  2. Bump docker/build-push-action from 5.0.0 to 5.1.0 (paritytech#2404)

    Bumps
    [docker/build-push-action](https://github.com/docker/build-push-action)
    from 5.0.0 to 5.1.0.
    <details>
    <summary>Release notes</summary>
    <p><em>Sourced from <a
    href="https://github.com/docker/build-push-action/releases">docker/build-push-action's
    releases</a>.</em></p>
    <blockquote>
    <h2>v5.1.0</h2>
    <ul>
    <li>Add <code>annotations</code> input by <a
    href="https://github.com/crazy-max"><code>@​crazy-max</code></a> in <a
    href="https://redirect.github.com/docker/build-push-action/pull/992">docker/build-push-action#992</a></li>
    <li>Add <code>secret-envs</code> input by <a
    href="https://github.com/elias-lundgren"><code>@​elias-lundgren</code></a>
    in <a
    href="https://redirect.github.com/docker/build-push-action/pull/980">docker/build-push-action#980</a></li>
    <li>Bump <code>@​babel/traverse</code> from 7.17.3 to 7.23.2 in <a
    href="https://redirect.github.com/docker/build-push-action/pull/991">docker/build-push-action#991</a></li>
    <li>Bump <code>@​docker/actions-toolkit</code> from 0.13.0-rc.1 to
    0.14.0 in <a
    href="https://redirect.github.com/docker/build-push-action/pull/990">docker/build-push-action#990</a>
    <a
    href="https://redirect.github.com/docker/build-push-action/pull/1006">docker/build-push-action#1006</a></li>
    </ul>
    <p><strong>Full Changelog</strong>: <a
    href="https://github.com/docker/build-push-action/compare/v5.0.0...v5.1.0">https://github.com/docker/build-push-action/compare/v5.0.0...v5.1.0</a></p>
    </blockquote>
    </details>
    <details>
    <summary>Commits</summary>
    <ul>
    <li><a
    href="https://github.com/docker/build-push-action/commit/4a13e500e55cf31b7a5d59a38ab2040ab0f42f56"><code>4a13e50</code></a>
    Merge pull request <a
    href="https://redirect.github.com/docker/build-push-action/issues/1006">#1006</a>
    from docker/dependabot/npm_and_yarn/docker/actions-t...</li>
    <li><a
    href="https://github.com/docker/build-push-action/commit/74166686865cdc289a02f214871fb53447b73447"><code>7416668</code></a>
    chore: update generated content</li>
    <li><a
    href="https://github.com/docker/build-push-action/commit/b4f76a5dc6a67282180eddc6d460f23bc97bfcbc"><code>b4f76a5</code></a>
    chore(deps): Bump <code>@​docker/actions-toolkit</code> from 0.13.0 to
    0.14.0</li>
    <li><a
    href="https://github.com/docker/build-push-action/commit/b7feb766fae338d85274c87a9d0f24c09690dbe2"><code>b7feb76</code></a>
    Merge pull request <a
    href="https://redirect.github.com/docker/build-push-action/issues/1005">#1005</a>
    from crazy-max/ci-inspect</li>
    <li><a
    href="https://github.com/docker/build-push-action/commit/fae8018297c67066fff64a6e9c319c86f89b8982"><code>fae8018</code></a>
    ci: inspect sbom and provenance</li>
    <li><a
    href="https://github.com/docker/build-push-action/commit/b625868b13c3feb675cabbf9bfeb52ae94166606"><code>b625868</code></a>
    Merge pull request <a
    href="https://redirect.github.com/docker/build-push-action/issues/1004">#1004</a>
    from crazy-max/ci-update-buildx</li>
    <li><a
    href="https://github.com/docker/build-push-action/commit/5193ef1da6ea0d66de97d22817c258b203ade96a"><code>5193ef1</code></a>
    ci: update buildx to latest</li>
    <li><a
    href="https://github.com/docker/build-push-action/commit/d3afd779e409ac26db5374fb27fe4aae9f6adb42"><code>d3afd77</code></a>
    Merge pull request <a
    href="https://redirect.github.com/docker/build-push-action/issues/991">#991</a>
    from docker/dependabot/npm_and_yarn/babel/traverse-7....</li>
    <li><a
    href="https://github.com/docker/build-push-action/commit/7a786bb2b9408f7f997564f677248fabd4b886d5"><code>7a786bb</code></a>
    Merge pull request <a
    href="https://redirect.github.com/docker/build-push-action/issues/992">#992</a>
    from crazy-max/annotations</li>
    <li><a
    href="https://github.com/docker/build-push-action/commit/c66ae3adcfbf698ecd851c6bb782654a0c6ffcae"><code>c66ae3a</code></a>
    chore: update generated content</li>
    <li>Additional commits viewable in <a
    href="https://github.com/docker/build-push-action/compare/0565240e2d4ab88bba5387d719585280857ece09...4a13e500e55cf31b7a5d59a38ab2040ab0f42f56">compare
    view</a></li>
    </ul>
    </details>
    <br />
    
    
    [![Dependabot compatibility
    score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=docker/build-push-action&package-manager=github_actions&previous-version=5.0.0&new-version=5.1.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
    
    Dependabot will resolve any conflicts with this PR as long as you don't
    alter it yourself. You can also trigger a rebase manually by commenting
    `@dependabot rebase`.
    
    [//]: # (dependabot-automerge-start)
    [//]: # (dependabot-automerge-end)
    
    ---
    
    <details>
    <summary>Dependabot commands and options</summary>
    <br />
    
    You can trigger Dependabot actions by commenting on this PR:
    - `@dependabot rebase` will rebase this PR
    - `@dependabot recreate` will recreate this PR, overwriting any edits
    that have been made to it
    - `@dependabot merge` will merge this PR after your CI passes on it
    - `@dependabot squash and merge` will squash and merge this PR after
    your CI passes on it
    - `@dependabot cancel merge` will cancel a previously requested merge
    and block automerging
    - `@dependabot reopen` will reopen this PR if it is closed
    - `@dependabot close` will close this PR and stop Dependabot recreating
    it. You can achieve the same result by closing it manually
    - `@dependabot show <dependency name> ignore conditions` will show all
    of the ignore conditions of the specified dependency
    - `@dependabot ignore this major version` will close this PR and stop
    Dependabot creating any more for this major version (unless you reopen
    the PR or upgrade to it yourself)
    - `@dependabot ignore this minor version` will close this PR and stop
    Dependabot creating any more for this minor version (unless you reopen
    the PR or upgrade to it yourself)
    - `@dependabot ignore this dependency` will close this PR and stop
    Dependabot creating any more for this dependency (unless you reopen the
    PR or upgrade to it yourself)
    
    
    </details>
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Nov 20, 2023
    Configuration menu
    Copy the full SHA
    b35300c View commit details
    Browse the repository at this point in the history
  3. remove retry from backers on failed candidate validation (paritytech#…

    …2182)
    
    Hey guys, as discussed I've changed the name to a more general one
    `PvfExecKind`, is this good or too general?
    Creating this as a draft, I still have to fix the tests.
    
    Closes paritytech#1585
    
    Kusama address: FkB6QEo8VnV3oifugNj5NeVG3Mvq1zFbrUu4P5YwRoe5mQN
    
    ---------
    
    Co-authored-by: command-bot <>
    Co-authored-by: Marcin S <[email protected]>
    jpserrat and mrcnski authored Nov 20, 2023
    Configuration menu
    Copy the full SHA
    ede4a36 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. bump zombienet version v1.3.82 (paritytech#2396)

    Includes:
     - bump `pjs` modules versions
    - re-enable test disable in
    paritytech#2294
    
    ---------
    
    Co-authored-by: Bastian Köcher <[email protected]>
    pepoviola and bkchr authored Nov 21, 2023
    Configuration menu
    Copy the full SHA
    126f64a View commit details
    Browse the repository at this point in the history
  2. chain-spec-builder: cleanup (paritytech#2174)

    This PR removes:
    -  `New`, `Generate`, `Edit` commands,
    - `kitchensink` dependency
    from the `chain-spec-builder` util.
    
    New `convert-to-raw`, `update-code` commands were added.
    
    Additionally renames the `runtime` command (which was added in paritytech#1256) to
    `create`.
    
    ---------
    
    Co-authored-by: Sebastian Kunert <[email protected]>
    Co-authored-by: Bastian Köcher <[email protected]>
    Co-authored-by: command-bot <>
    3 people authored Nov 21, 2023
    Configuration menu
    Copy the full SHA
    2fd8c51 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0619049 View commit details
    Browse the repository at this point in the history
  4. Add output positional arg to undying-collator cli (paritytech#2375)

    Follow up from paritytech#2370 to
    add `output` positional argument to undying-collator.
    
    cc @JoshOrndorff
    
    ---------
    
    Co-authored-by: Bastian Köcher <[email protected]>
    pepoviola and bkchr authored Nov 21, 2023
    Configuration menu
    Copy the full SHA
    40afc77 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    552be48 View commit details
    Browse the repository at this point in the history
  6. cumulus-consensus-common: block import: delayed_best_block flag add…

    …ed (paritytech#2001)
    
    This PR adds the `delayed_best_block` flag to `ParachainBlockImport`. If
    not set, the `params.fork_choice` is not updated (to
    `ForkChoiceStrategy::Custom`) during the block import.
    
    When `delayed_best_block` is set to `false` all parachain blocks on the
    [longest
    fork](https://github.com/paritytech/polkadot-sdk/blob/552be4800d9e4b480f79a300fc531783e04be099/substrate/client/service/src/client/client.rs#L708-L709)
    will be notified as the best block, allowing transaction pool to be
    updated with every imported block.
    
    Otherwise imported blocks will not be notified as best blocks
    (`fork_choice=ForkChoiceStrategy::Custom(false)`), and transaction pool
    would be updated only with best block received from relay-chain.
    
    Improvement for: paritytech#1202
    
    ---------
    
    Co-authored-by: Bastian Köcher <[email protected]>
    michalkucharczyk and bkchr authored Nov 21, 2023
    Configuration menu
    Copy the full SHA
    b25d29a View commit details
    Browse the repository at this point in the history
  7. Different XCM builders, default one requires fee payment (paritytech#…

    …2253)
    
    Adding on top of the new builder pattern for creating XCM programs, I'm
    adding some more APIs:
    
    ```rust
    let paying_fees: Xcm<()> = Xcm::builder() // Only allow paying for fees
      .withdraw_asset() // First instruction has to load the holding register
      .buy_execution() // Second instruction has to be `buy_execution`
      .build();
    
    let paying_fees_invalid: Xcm<()> = Xcm::builder()
      .withdraw_asset()
      .build(); // Invalid, need to pay for fees
    
    let not_paying_fees: Xcm<()> = Xcm::builder_unpaid()
      .unpaid_execution() // Needed
      .withdraw_asset()
      .deposit_asset()
      .build();
    
    let all_goes: Xcm<()> = Xcm::builder_unsafe() // You can do anything
      .withdraw_asset()
      .deposit_asset()
      .build();
    ```
    
    The invalid bits are because the methods don't even exist on the types
    that you'd want to call them on.
    
    ---------
    
    Co-authored-by: command-bot <>
    franciscoaguirre authored Nov 21, 2023
    Configuration menu
    Copy the full SHA
    b3841b6 View commit details
    Browse the repository at this point in the history
  8. added action to pass review bot on merge queue (paritytech#2414)

    This action will trigger when a merge queue is created and will add a
    positive status check under the `review-bot` account, allowing the PR to
    pass the required check for the merge.
    
    ---------
    
    Co-authored-by: Chevdor <[email protected]>
    Bullrich and chevdor authored Nov 21, 2023
    Configuration menu
    Copy the full SHA
    f5ad32e View commit details
    Browse the repository at this point in the history
  9. Update tick collator for async backing (paritytech#1497)

    This updates the tick runtime and polkadot-parachain collator to use
    async backing.
    Sophia-Gold authored Nov 21, 2023
    Configuration menu
    Copy the full SHA
    50811d6 View commit details
    Browse the repository at this point in the history
  10. cumulus-test-service: block import fix (paritytech#2430)

    This is follow-up for:
    paritytech#2001
    
    Block import queue for `test-parachain` (`cumulus-test-service`) shall
    use delayed best block feature.
    
    This should fixed broken zombienet tests.
    michalkucharczyk authored Nov 21, 2023
    Configuration menu
    Copy the full SHA
    2183669 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. Deprecate RewardDestination::Controller (paritytech#2380)

    Deprecates `RewardDestination::Controller` variant.
    
    - [x] `RewardDestination::Controller` annotated with `#[deprecated]`.
    - [x] `Controller` variant is now handled the same way as `Stash` in
    `payout_stakers`.
    - [x] `set_payee` errors if `RewardDestination::Controller` is provided.
    - [x] Added `update_payee` call to lazily migrate
    `RewardDestination::Controller` `Payee` storage entries to
    `RewardDestination::Account(controller)` .
    - [x] `payout_stakers_dead_controller` has been removed from benches &
    weights - was not used.
    - [x] Tests no longer use `RewardDestination::Controller`.
    
    ---------
    
    Co-authored-by: command-bot <>
    Co-authored-by: Gonçalo Pestana <[email protected]>
    Co-authored-by: georgepisaltu <[email protected]>
    3 people authored Nov 22, 2023
    Configuration menu
    Copy the full SHA
    7a32f4b View commit details
    Browse the repository at this point in the history
  2. Revert docker images tag naming to <prnum-shortsha> (paritytech#2434)

    Docker images from paritypr are also used in testnets. PR reverts docker
    tags naming to a more convenient.
    
    cc @PierreBesson
    alvicsam authored Nov 22, 2023
    Configuration menu
    Copy the full SHA
    a9ba1e5 View commit details
    Browse the repository at this point in the history
  3. Fixes import path in benchmark macro (paritytech#2437)

    Fully-qualified path was not being used in benchmark macro for one of
    the cases. This PR fixes this and removes the unnecessary import in a
    couple of files, which I believe was done to fix this issue.
    gupnik authored Nov 22, 2023
    Configuration menu
    Copy the full SHA
    98f9e2e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    408af9b View commit details
    Browse the repository at this point in the history
  5. Make TypeInfo for SkipCheckIfFeeless transparent, too (paritytech#2449)

    The `SkipCheckifFeeless::IDENTIFIER` became transparent (ie was whatever
    the inner signed ext was). This PR just makes the `TypeInfo` transparent
    too, so that libraries that use said info to decode the data (ie subxt)
    can behave identically whether or not the `SkipCheckifFeeless` wrapper
    is used or not.
    
    ---------
    
    Co-authored-by: Oliver Tale-Yazdi <[email protected]>
    jsdw and ggwpez authored Nov 22, 2023
    Configuration menu
    Copy the full SHA
    0d6dcb3 View commit details
    Browse the repository at this point in the history
  6. work with additional key values (paritytech#1757)

    Add the possibility to inject additional key-values in the
    sproof-builder that generates the relay root that gets stored in
    parachain-system.
    
    Rationale: pallets that verify additional storage items (not those
    verified by parachain-system) from the relay should be able to proof
    against the relay root that gets stored in parachain-system. This PR
    allows to create provide additional nibles that can later be used for
    verifiability in other pallets
    girazoki authored Nov 22, 2023
    Configuration menu
    Copy the full SHA
    0956357 View commit details
    Browse the repository at this point in the history
  7. polkadot-node-subsystems: ChainApiBackend added + polkadot-debug

    …image version fixed (paritytech#2411)
    
    The out-dated version (bad tag) of [polkadot
    image](https://github.com/paritytech/polkadot-sdk/blob/ede4a362622dfa69eb167eaa876246b1289f4b41/.gitlab/pipeline/zombienet/cumulus.yml#L31)
    ([docker
    info](https://hub.docker.com/layers/paritypr/polkadot-debug/master/images/sha256:adb1658052cf671b50c90d5cece5c7a131efa1a95978249bd5cb85a5ad654f7a?context=explore))
    was used. This PR fixes this.
    
    See also:
    paritytech#2411 (comment)
    
    Also adds an abstraction that allows asynchronous backends to be passed to `ChainApiSubsystem`
    ---------
    
    Co-authored-by: Sebastian Kunert <[email protected]>
    michalkucharczyk and skunert authored Nov 22, 2023
    Configuration menu
    Copy the full SHA
    4987488 View commit details
    Browse the repository at this point in the history
  8. Remove #[macro_use] annotation from mod service in all nodes. (pa…

    …ritytech#2456)
    
    This PR removes `#[macro_use]` from the service module in each of the
    Substrate nodes in the repo.
    
    * Parachain Template
    * Polkadot Parachain
    * Minimal Node
    * Node Template
    * Kitchen Sink Node
    
    IDK why this annotation was present, maybe from when we had the
    `new_partial!` macro?
    
    ---------
    
    Co-authored-by: Joshy Orndorff <[email protected]>
    JoshOrndorff and Joshy Orndorff authored Nov 22, 2023
    Configuration menu
    Copy the full SHA
    ec18933 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2023

  1. Add on-chain-release-build feature for Collectives Westend (parityt…

    …ech#2463)
    
    Collectives Westend is missing an `on-chain-release-build` feature flag.
    liamaharon authored Nov 23, 2023
    Configuration menu
    Copy the full SHA
    2d09e83 View commit details
    Browse the repository at this point in the history
  2. CI: Disable runtime upgrade spec name check on Westend Asset Hub and …

    …fix Staking pallet migration (paritytech#2447)
    
    Westend Asset Hub currently failing because the spec name is being
    changed next runtime upgrade
    (https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4413125).
    
    This also fixes an idempotency issue with a staking pallet migration.
    Similar issues will be caught automatically now that we've also updated
    to try-runtime-cli v0.5.0 which checks for idempotency issues.
    
    This also enables try-state checks running in the CI.
    liamaharon authored Nov 23, 2023
    Configuration menu
    Copy the full SHA
    12062f6 View commit details
    Browse the repository at this point in the history
  3. sp-api: Move macro related re-exports to __private (paritytech#2446)

    This moves the macro related re-exports to `__private` to make it more
    obvious for downstream users that they are using an internal api.
    
    ---------
    
    Co-authored-by: command-bot <>
    bkchr authored Nov 23, 2023
    Configuration menu
    Copy the full SHA
    21f1811 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    19c05e8 View commit details
    Browse the repository at this point in the history
  5. Amend staking docs to account for state of controller deprecation (pa…

    …ritytech#2451)
    
    Amends some staking pallet docs, and deprecation comment, to adjust to
    the latest controller deprecation state.
    
    Note, do we need the `README.md` file, which is a duplicate of the
    pallet docs? Docs would be easier to maintain, and less ambiguity for
    devs to refer to, if we had one source of truth in the generated pallet
    docs.
    Ross Bulat authored Nov 23, 2023
    Configuration menu
    Copy the full SHA
    c29b74d View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2023

  1. Configuration menu
    Copy the full SHA
    a00a767 View commit details
    Browse the repository at this point in the history
  2. pallet-xcm: ensure xcm outcome is always complete, revert effects oth…

    …erwise (paritytech#2405)
    
    On extrinsics/call, ensure local XCM execution is complete/successful.
    Otherwise, fail the extrinsic so that state changes don't get committed
    to the db.
    
    Added regression tests that fail without the fix.
    
    fixes paritytech#2237
    
    ---------
    
    Co-authored-by: Adrian Catangiu <[email protected]>
    xlc and acatangiu authored Nov 24, 2023
    Configuration menu
    Copy the full SHA
    4163152 View commit details
    Browse the repository at this point in the history
  3. pallet-staking: Converts all math operations to safe (paritytech#2435)

    This PR converts unsafe math operations to safe in the staking pallet.
     
    Closes paritytech#2431
    
    ---------
    
    Co-authored-by: Ankan <[email protected]>
    gpestana and Ank4n authored Nov 24, 2023
    Configuration menu
    Copy the full SHA
    f086d54 View commit details
    Browse the repository at this point in the history
  4. Adapt test worker to profile flag (paritytech#2450)

    closes paritytech#2194 
    
    cc @mrcnski
    
    ---------
    
    Co-authored-by: Bastian Köcher <[email protected]>
    eagr and bkchr authored Nov 24, 2023
    Configuration menu
    Copy the full SHA
    e3242d2 View commit details
    Browse the repository at this point in the history
  5. Disable any peer connections for parachain nodes in pov-recovery zom…

    …bienet test (paritytech#2475)
    
    I noticed that this test broke at some point. The parachain nodes should
    only acquire their blocks from the relay chain. But they were connecting
    to their peers and started fetching blocks from there.
    
    In this test I now take additional measures so we check that each nodes
    really uses pov-recovery to get the blocks.
    skunert authored Nov 24, 2023
    Configuration menu
    Copy the full SHA
    471eafc View commit details
    Browse the repository at this point in the history
  6. Remove dmp-queue pallet from Rococo Asset Hub and Bridge Hub (parityt…

    …ech#2483)
    
    DMP queue migration is complete and the pallet should be removed to fix
    the check runtime upgrade CI.
    
    <img width="1501" alt="Screenshot 2023-11-24 at 16 05 37"
    src="https://github.com/paritytech/polkadot-sdk/assets/16665596/ee1da6bb-2756-4423-8085-1e4c73553ad5">
    
    <img width="1501" alt="Screenshot 2023-11-24 at 16 06 44"
    src="https://github.com/paritytech/polkadot-sdk/assets/16665596/03f3e88f-aed8-4eaa-aab6-7998f72258be">
    liamaharon authored Nov 24, 2023
    Configuration menu
    Copy the full SHA
    7554f53 View commit details
    Browse the repository at this point in the history
  7. relay-chain-consensus: set a fork_choice (paritytech#2462)

    After paritytech#2001 the `fork_choice` strategy may remain uninitialized in the
    block import pipeline which uses relay-chain verifier.
    Refer to
    paritytech#2430 (comment)
    for some further discussion.
    michalkucharczyk authored Nov 24, 2023
    Configuration menu
    Copy the full SHA
    891628a View commit details
    Browse the repository at this point in the history
  8. Improve UnpinHandleInner debug (paritytech#2485)

    Printing the `unpin_worker_sender` included the entire stacktrace and
    that is a little bit too verbose.
    bkchr authored Nov 24, 2023
    Configuration menu
    Copy the full SHA
    803ea76 View commit details
    Browse the repository at this point in the history
  9. Derive MaxEncodedLen on SlotDuration (paritytech#2484)

    # Description
    
    Needed this in my code as part of the larger data structure.
    
    ---------
    
    Co-authored-by: command-bot <>
    nazar-pc authored Nov 24, 2023
    Configuration menu
    Copy the full SHA
    07ea6da View commit details
    Browse the repository at this point in the history
  10. pallet-xcm: fix benchmarking (paritytech#2489)

    Use non-zero weight limit in benchmarking `pallet_xcm::execute()` so the
    given XCM actually executes.
    acatangiu authored Nov 24, 2023
    Configuration menu
    Copy the full SHA
    90488ff View commit details
    Browse the repository at this point in the history
  11. [NPoS] Use EraInfo to manipulate exposure in fast-unstake tests (pari…

    …tytech#2459)
    
    The FastUnstake pallet tests were previously directly modifying storage
    items in the pallet-staking to alter exposure. However, due to the
    introduction of the [new paged exposure
    feature](paritytech#1189) these
    tests were not testing against correct storage items. This issue
    resulted in a bug that I didn't catch, which has been addressed in [this
    fix](paritytech#2369).
    
    This PR introduces a modification to how the pallet-fast-unstake handles
    exposure. It now utilizes `pallet-staking::EraInfo` to set or mutate
    Exposures.
    Ank4n authored Nov 24, 2023
    Configuration menu
    Copy the full SHA
    8af61d0 View commit details
    Browse the repository at this point in the history
  12. Remove RuntimeApi dependency on system parachain runtime code (pari…

    …tytech#2455)
    
    The last issue blocking the removal of the Polkadot and Kusama system
    parachains from the repo in paritytech#1737 is the dependency on the runtime code
    through the RuntimeApi in `polkadot-parachain`.
    
    This PR introduces two fake runtimes to satisfy the build requirements
    and changes the `new_partial` function to make it not be generic over
    the runtimes.
    The reason for the second runtime is the different Aura keys used in
    Polkadot Asset Hub, as the impl for AuraApi depends on this type.
    If this changes the `RuntimeApi` generic could be removed completely
    from all functions in `services.rs` and and generic type parameters in
    `services.rs` and specified as a concrete type to TFullClient`.
    
    ---------
    
    Co-authored-by: Bastian Köcher <[email protected]>
    seadanda and bkchr authored Nov 24, 2023
    Configuration menu
    Copy the full SHA
    d07186b View commit details
    Browse the repository at this point in the history
  13. Add missing workspace members (paritytech#2491)

    The following members have been added:
    
    ```pre
    cumulus/parachains/integration-tests/emulated/chains/parachains/testing/penpal
    cumulus/parachains/testnets-common
    polkadot/node/tracking-allocator
    substrate/frame/examples/frame-crate
    ```
    
    CI check can be added after
    paritytech/pipeline-scripts#105 is merged.
    
    ---------
    
    Signed-off-by: Oliver Tale-Yazdi <[email protected]>
    Co-authored-by: Bastian Köcher <[email protected]>
    ggwpez and bkchr authored Nov 24, 2023
    Configuration menu
    Copy the full SHA
    81638d4 View commit details
    Browse the repository at this point in the history
  14. bump zombienet version v1.3.83 (paritytech#2492)

    Include fix for `0002-parachains-upgrade-smoke-test` test.
    pepoviola authored Nov 24, 2023
    Configuration menu
    Copy the full SHA
    63f1210 View commit details
    Browse the repository at this point in the history
  15. Do not pollute global base path with export genesis/wasm (paritytech#…

    …2487)
    
    Otherwise the user may runs into weird errors if there is already a db.
    bkchr authored Nov 24, 2023
    Configuration menu
    Copy the full SHA
    5e27342 View commit details
    Browse the repository at this point in the history
  16. Zombienet: add polkadot-debug image publish as needs for cumulus tests (

    paritytech#2493)
    
    Add `build-push-image-polkadot-debug` job to needs since we changed to
    use the polkadot-debug image from the current branch for cumulus test
    and we need to be sure that the image is ready. Fix issues like
    https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4481059
    
    cc: @bkchr
    
    Co-authored-by: Bastian Köcher <[email protected]>
    pepoviola and bkchr authored Nov 24, 2023
    Configuration menu
    Copy the full SHA
    ffc64fd View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2023

  1. polkadot-parachain: one chain-spec for all (paritytech#2457)

    This PR removes some `ChainSpec` types which are not necessary
    (left-overs from paritytech#1256). Currently `ChainSpec` does not have to be
    generic over the specific `RuntimeGenesisConfig`, it is enough to use
    single type for all:
    
    https://github.com/paritytech/polkadot-sdk/blob/9f787018857660440182142adc806954d7d07709/cumulus/polkadot-parachain/src/chain_spec/mod.rs#L53-L54
    
    
    related to: paritytech#25
    
    ---------
    
    Co-authored-by: command-bot <>
    michalkucharczyk authored Nov 25, 2023
    Configuration menu
    Copy the full SHA
    d5d15a1 View commit details
    Browse the repository at this point in the history
  2. Update documentation for SafeMode and TxPause Pallets (paritytech#2413)

    # Description
    
    Documentation for the TxPause and SafeMode pallets.
    
    Based on reading and the notes from the following related PRs:
    - paritytech/substrate#12092
    
    I believe this also completes the checklist to be able to close the
    related PRs:
    - Close paritytech#302 
    - Close paritytech#274
    
    ---------
    
    Co-authored-by: joe petrowski <[email protected]>
    wilwade and joepetrowski authored Nov 25, 2023
    Configuration menu
    Copy the full SHA
    73ff1c3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cfa19c3 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. New runtime spec_version format + backport of the bump to 1.4.0 (pa…

    …ritytech#2468)
    
    ## Overview
    
    This PR aligns the `spec_version` formatting to the [recent
    changes](https://github.com/polkadot-fellows/runtimes/pull/26/files#diff-efa4caeb17487ecb13d8f5eb7863c3241d84afa2e73fbf25909a2ca89df0f362R142)
    made for the Polkadot/Kusama runtimes.
    
    It also backports the latest version `v1.4.0` bumps as `1_004_000`.
    
    ## Details
    
    During the switch from `v0.9` to `v1.x`, the format of the
    `spec_version` was modified from: `(M)m_ppp` for a runtime considered on
    version `M.m.pp`. For instance `0.9.42` had a `spec_version` of `9420`.
    
    With the transition to `v1.x`, the format was changed to a bigger number
    (still `u32`) formatted as `MM_mm_ppp` where `1.2.3` would be stored as
    `01_02_003`.
    
    This PR aligns the format with that has been introduced in the
    fellowship repo: `MMM_mmm_ppp`.
    
    ---------
    
    Co-authored-by: Bastian Köcher <[email protected]>
    chevdor and bkchr authored Nov 27, 2023
    Configuration menu
    Copy the full SHA
    4f8048b View commit details
    Browse the repository at this point in the history
  2. Zombienet tests - disputes on finalized blocks (paritytech#2184)

    **Overview:**
    Adding an extra malus variant focusing on disputing finalized blocks. It
    will:
    - wrap around approval-voting
    - listen to `OverseerSignal::BlockFinalized` and when encountered start
    a dispute for the `dispute_offset`th ancestor
    - simply pass through all other messages and signals
    
    Add zombienet tests testing various edgecases:
    - disputing freshly finalized blocks
    - disputing stale finalized blocks
    - disputing eagerly pruned finalized blocks (might be separate PR)
    
    **TODO:**
    - [x] Register new malus variant
    - [x] Simple pass through wrapper (approval-voting)
    - [x] Simple network definition
    - [x] Listen to block finalizations
    - [x] Fetch ancestor hash
    - [x] Fetch session index
    - [x] Fetch candidate
    - [x] Construct and send dispute message
    - [x] zndsl test 1 checking that disputes on fresh finalizations resolve
    valid Closes paritytech#1365
    - [x] zndsl test 2 checking that disputes for too old finalized blocks
    are not possible Closes paritytech#1364
    - [ ] zndsl test 3 checking that disputes for candidates with eagerly
    pruned relay parent state are handled correctly paritytech#1359 (deferred to a
    separate PR)
    - [x] Unit tests for new malus variant (testing cli etc)
    - [x] Clean/streamline error handling
    - [ ] ~~Ensure it tests properly on session boundaries~~
    
    ---------
    
    Co-authored-by: Javier Viola <[email protected]>
    Co-authored-by: Marcin S. <[email protected]>
    Co-authored-by: Tsvetomir Dimitrov <[email protected]>
    4 people authored Nov 27, 2023
    Configuration menu
    Copy the full SHA
    dc69dbb View commit details
    Browse the repository at this point in the history
  3. Decomissioned PR-Custom-Review (paritytech#2503)

    This PR decomissions
    [`PR-Custom-Review`](https://github.com/paritytech/pr-custom-review) in
    replacement for
    [`Review-bot`](https://github.com/paritytech/review-bot).
    Bullrich authored Nov 27, 2023
    Configuration menu
    Copy the full SHA
    0317501 View commit details
    Browse the repository at this point in the history
  4. Build the standard library crates when building the runtimes (parityt…

    …ech#2217)
    
    Our executor currently only supports the WASM MVP feature set, however
    nowadays when compiling WASM the Rust compiler has more features enabled
    by default.
    
    We do set the `-C target-cpu=mvp` flag to make sure that *our* code gets
    compiled in a way that is compatible with our executor, however this
    doesn't affect Rust's standard library crates (`std`, `core` and
    `alloc`) which are by default precompiled and still can make use of
    these extra features.
    
    So in this PR we force the compiler to also compile the standard library
    crates for us to make sure that they also only use the MVP features.
    
    I've added the `WASM_BUILD_STD` environment variable which can be used
    to disable this behavior if set to `0`.
    
    Unfortunately this *will* slow down the compile times when building
    runtimes, but there isn't much that we can do about that.
    
    Fixes paritytech#1755
    
    ---------
    
    Co-authored-by: Bastian Köcher <[email protected]>
    koute and bkchr authored Nov 27, 2023
    Configuration menu
    Copy the full SHA
    2610450 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4298bc6 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    fd1ed40 View commit details
    Browse the repository at this point in the history
  7. Staking: chill_other takes stash instead of controller (paritytech#…

    …2501)
    
    The `chill_other` call is the only staking call that explicitly requires
    `controller` in its signature. This PR changes the controller arg to be
    the stash instead, with `StakingLedger` then fetching the controller
    from storage.
    
    This is not a breaking change per se - the call types do not change, but
    is noteworthy as UIs will now want to pass the stash account into
    `chill_other` calls, & metadata will reflect this.
    
    Note: This is very low impact. `chill_other` has [hardly ever been
    used](https://polkadot.subscan.io/extrinsic?address=&module=staking&call=chill_other&result=all&signedChecked=signed%20only&startDate=&endDate=&startBlock=&timeType=date&version=9431&endBlock=)
    on Polkadot - notwithstanding the one called 11 days ago at block
    18177457 that was a part of test I did, the last call was made 493 days
    ago. Only 2 calls have ever been successful.
    
    Addresses controller deprecation paritytech#2500
    
    ---------
    
    Co-authored-by: command-bot <>
    Co-authored-by: Gonçalo Pestana <[email protected]>
    Ross Bulat and gpestana authored Nov 27, 2023
    Configuration menu
    Copy the full SHA
    838a534 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. CI: Fix build-and-attach-release-runtimes.yml (paritytech#2471)

    Incorporate suggestion from release team to get this workflow working.
    
    edit: worked on this test GH release:
    https://github.com/paritytech/polkadot-sdk/releases/tag/liam-debug-ghw.
    let's try it.
    liamaharon authored Nov 28, 2023
    Configuration menu
    Copy the full SHA
    db29099 View commit details
    Browse the repository at this point in the history
  2. Fixes cumulus README instructions (paritytech#2442)

    README instructions fixes to be compatible with the `polkadot-prepare`
    and `polkadot-execute` binary split.
    gpestana authored Nov 28, 2023
    Configuration menu
    Copy the full SHA
    2ac23d2 View commit details
    Browse the repository at this point in the history
  3. Pools: Add ability to configure commission claiming permissions (pari…

    …tytech#2474)
    
    Addresses paritytech#409.
    
    This request has been raised by multiple community members - the ability
    for the nomination pool root role to configure permissionless commission
    claiming:
    
    > Would it be possible to have a claim_commission_other extrinsic for
    claiming commission of nomination pools permissionless?
    
    This PR does not quite introduce this additional call, but amends
    `do_claim_commission` to check a new `claim_permission` field in the
    `Commission` struct, configured by an enum:
    
    ```
    enum CommissionClaimPermission {
       Permissionless,
       Account(AccountId),
    }
    ```
    This can be optionally set in a bonded pool's
    `commission.claim_permission` field:
    
    ```
    struct BondedPool {
       commission: {
          <snip>
          claim_permission: Option<CommissionClaimPermission<T::AccountId>>,
       },
       <snip>
    }
    ```
    
    This is a new field and requires a migration to add it to existing
    pools. This will be `None` on pool creation, falling back to the `root`
    role having sole access to claim commission if it is not set; this is
    the behaviour as it is today. Once set, the field _can_ be set to `None`
    again.
    
    #### Changes
    - [x] Add `commision.claim_permission` field.
    - [x] Add `can_claim_commission` and amend `do_claim_commission`.
    - [x] Add `set_commission_claim_permission` call.
    - [x] Test to cover new configs and call.
    - [x] Add and amend benchmarks.
    - [x] Generate new weights + slot into call
    `set_commission_claim_permission`.
    - [x] Add migration to introduce `commission.claim_permission`, bump
    storage version.
    - [x] Update Westend weights.
    - [x] Migration working.
    
    ---------
    
    Co-authored-by: command-bot <>
    Ross Bulat authored Nov 28, 2023
    Configuration menu
    Copy the full SHA
    7506271 View commit details
    Browse the repository at this point in the history
  4. Added NetworkId::PolkadotBulletin variant (paritytech#2517)

    We're going to bridge Polkadot Bridge Hub with [Polkadot Bulletin
    chain](https://github.com/zdave-parity/polkadot-bulletin-chain) soon
    (and Rococo Bridge Hub with 1:1 copy of Polkadot Bulletin chain even
    sooner), so we need a variant for that chain in `NetworkId`. As
    suggested, I'm adding a new variant for it to the `NetworkId` (we may
    have used `ByGenesis(_)`, but decision was made to have a dedicated
    variant for that).
    svyatonik authored Nov 28, 2023
    Configuration menu
    Copy the full SHA
    0f7ffc6 View commit details
    Browse the repository at this point in the history
  5. polkadot: disable block authoring backoff on production networks (par…

    …itytech#2510)
    
    Currently the polkadot node will backoff from block authoring if
    finality starts lagging. This PR disables this mechanism on production
    networks (polkadot and kusama) and adds a flags to optionally force
    enabling it.
    andresilva authored Nov 28, 2023
    Configuration menu
    Copy the full SHA
    58a1f9c View commit details
    Browse the repository at this point in the history
  6. Set frame_system::LastRuntimeUpgrade after running try-runtime mi…

    …grations (paritytech#2515)
    
    Sets `frame_system::LastRuntimeUpgrade` after running try-runtime
    migrations to better emulate real behavior.
    
    This fixes an issue where migrations using the spec version to determine
    whether to execute can incorrectly fail idempotency checks.
    
    @s0me0ne-unkn0wn noticed this issue with the session key migration
    introduced in paritytech#2265.
    liamaharon authored Nov 28, 2023
    Configuration menu
    Copy the full SHA
    6dc3e6c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    6a417eb View commit details
    Browse the repository at this point in the history
  8. Moves all test runtimes to use derive_impl (paritytech#2409)

    Step in paritytech#171
    
    This PR adds `derive_impl` on all `frame_system` config impls for mock
    runtimes. The overridden configs are maintained as of now to ensure
    minimal changes.
    
    ---------
    
    Co-authored-by: Oliver Tale-Yazdi <[email protected]>
    gupnik and ggwpez authored Nov 28, 2023
    Configuration menu
    Copy the full SHA
    cd8741c View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    dbd8d20 View commit details
    Browse the repository at this point in the history
  10. Remove wasm-builder's README (paritytech#2525)

    Followup of paritytech#2217
    
    This PR deletes the README of the `wasm-builder` crate and moves its
    docs back into the rustdoc, [as requested
    here](paritytech#2217 (comment)).
    (:
    koute authored Nov 28, 2023
    Configuration menu
    Copy the full SHA
    f01781a View commit details
    Browse the repository at this point in the history
  11. Remove im-online pallet from Rococo and Westend (paritytech#2265)

    Co-authored-by: ordian <[email protected]>
    Co-authored-by: Vladimir Istyufeev <[email protected]>
    3 people authored Nov 28, 2023
    Configuration menu
    Copy the full SHA
    c5f211d View commit details
    Browse the repository at this point in the history
  12. polkadot: remove grandpa pause support (paritytech#2511)

    This was never used and we probably don't need it anyway.
    andresilva authored Nov 28, 2023
    Configuration menu
    Copy the full SHA
    b0b4451 View commit details
    Browse the repository at this point in the history
  13. Remove pov-recovery race condition/Improve zombienet test (paritytech…

    …#2526)
    
    The test was a bit flaky on CI. 
    
    There was a race condition in the pov-recovery system. If the timing is
    bad, it can happen that a block waits for a parent that is already
    queued for import. The check if a block has children waiting happens
    when we insert into the import queue. So we need to do an additional
    check once we receive the import notification for the parent block.
    
    Second issue is that `alice` was missing `--in-peers 0` and `--out-peers
    0`, so alice was sometimes still fetching block via sync and the
    assertion on the logs in zombienet would fail.
    
    There is another potential issue that I saw once locally. We have a
    failing pov-recovery queue that fails from time to time to check that
    the retry mechanism does what it should. We now make sure that the same
    candidate is never failed twice, so the tests become more predictable.
    skunert authored Nov 28, 2023
    Configuration menu
    Copy the full SHA
    ec3a61e View commit details
    Browse the repository at this point in the history
  14. Rework the event system of sc-network (paritytech#1370)

    This commit introduces a new concept called `NotificationService` which
    allows Polkadot protocols to communicate with the underlying
    notification protocol implementation directly, without routing events
    through `NetworkWorker`. This implies that each protocol has its own
    service which it uses to communicate with remote peers and that each
    `NotificationService` is unique with respect to the underlying
    notification protocol, meaning `NotificationService` for the transaction
    protocol can only be used to send and receive transaction-related
    notifications.
    
    The `NotificationService` concept introduces two additional benefits:
      * allow protocols to start using custom handshakes
      * allow protocols to accept/reject inbound peers
    
    Previously the validation of inbound connections was solely the
    responsibility of `ProtocolController`. This caused issues with light
    peers and `SyncingEngine` as `ProtocolController` would accept more
    peers than `SyncingEngine` could accept which caused peers to have
    differing views of their own states. `SyncingEngine` would reject excess
    peers but these rejections were not properly communicated to those peers
    causing them to assume that they were accepted.
    
    With `NotificationService`, the local handshake is not sent to remote
    peer if peer is rejected which allows it to detect that it was rejected.
    
    This commit also deprecates the use of `NetworkEventStream` for all
    notification-related events and going forward only DHT events are
    provided through `NetworkEventStream`. If protocols wish to follow each
    other's events, they must introduce additional abtractions, as is done
    for GRANDPA and transactions protocols by following the syncing protocol
    through `SyncEventStream`.
    
    Fixes paritytech#512
    Fixes paritytech#514
    Fixes paritytech#515
    Fixes paritytech#554
    Fixes paritytech#556
    
    ---
    These changes are transferred from
    paritytech/substrate#14197 but there are no
    functional changes compared to that PR
    
    ---------
    
    Co-authored-by: Dmitry Markin <[email protected]>
    Co-authored-by: Alexandru Vasile <[email protected]>
    3 people authored Nov 28, 2023
    Configuration menu
    Copy the full SHA
    e71c484 View commit details
    Browse the repository at this point in the history
  15. [ci] Run gitspiegel trigger with merge conflicts (paritytech#2531)

    Currently gitspiegel trigger won't run if there is merge conflict. This
    PR fixes it.
    
    close paritytech/gitspiegel#183
    alvicsam authored Nov 28, 2023
    Configuration menu
    Copy the full SHA
    aada961 View commit details
    Browse the repository at this point in the history
  16. Remove long deprecated AllPalletsWithoutSystemReversed (paritytech#…

    …2509)
    
    Remove deprecated `AllPalletsXY` types.
    
    They have been deprecated for nearly 1.5 years now, I think its fine to
    remove them.
    If anyone feels like we should first put a date on the deprecation as
    stated in the deprecation guideline, feel free to speak up. To me it
    looks like this has been forgotten and can be directly removed.
    skunert authored Nov 28, 2023
    Configuration menu
    Copy the full SHA
    8201793 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. Remove dmp_queue pallet from Westend SP runtimes (paritytech#2516)

    Westend SP dmp queue pallet removal is complete.
    
    <img width="1499" alt="Screenshot 2023-11-28 at 08 31 27"
    src="https://github.com/paritytech/polkadot-sdk/assets/16665596/906246fb-3de9-4133-a827-431636a097ad">
    
    <img width="1499" alt="Screenshot 2023-11-28 at 08 32 08"
    src="https://github.com/paritytech/polkadot-sdk/assets/16665596/bde84891-b044-42c7-9a0b-59125cd24db1">
    
    <img width="1499" alt="Screenshot 2023-11-28 at 08 31 45"
    src="https://github.com/paritytech/polkadot-sdk/assets/16665596/38337484-0856-45c0-b9ff-8c785bc3c0e3">
    liamaharon authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    a9aa2d1 View commit details
    Browse the repository at this point in the history
  2. Enable parallel key scraping (paritytech#1985)

    closes #174
    
    ---------
    
    Co-authored-by: Liam Aharon <[email protected]>
    Co-authored-by: Oliver Tale-Yazdi <[email protected]>
    3 people authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    1d5d4a4 View commit details
    Browse the repository at this point in the history
  3. substrate-node: NativeElseWasmExecutor is no longer used (paritytec…

    …h#2521)
    
    This PR removes `NativeElseWasmExecutor` usage from substrate node.
    Instead [`WasmExecutor<(sp_io::SubstrateHostFunctions,
    sp_statement_store::runtime_api::HostFunctions)>`](https://github.com/paritytech/polkadot-sdk/blob/49a41ab3bb3f630c20e5b24cec8d92382404631c/substrate/bin/node/executor/src/lib.rs#L26)
    is used.
    
    Related to paritytech#2358.
    
    ---------
    
    Co-authored-by: Davide Galassi <[email protected]>
    michalkucharczyk and davxy authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    39d6c95 View commit details
    Browse the repository at this point in the history
  4. Remove system parachains Polkadot and Kusama runtimes (paritytech#1737)

    Since the Polkadot and Kusama runtimes are no longer in the repo, the
    relevant systems parachains runtimes also need to be removed. More
    context [here](paritytech#603)
    and [here](paritytech#1731).
    
    Removes the following:
    - `asset-hub-kusama` and `asset-hub-polkadot`
    - `bridge-hub-kusama` and `bridge-hub-polkadot`
    - `collectives-polkadot`
    - `glutton-kusama`
    
    Partially solves paritytech#603 and adds to paritytech#1731.
    seadanda authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    63ac247 View commit details
    Browse the repository at this point in the history
  5. Improve CodeExecutor (paritytech#2358)

    Since `sp-state-machine` and `GenesisConfigBuilderRuntimeCaller` always
    set `use_native` to be false.
    We should remove this param and make `NativeElseWasmExecutor` behave
    like its name.
    It could make the above components use the correct execution strategy.
    
    Maybe polkadot do not need about `NativeElseWasmExecutor` anymore. But
    it is still needed by other chains and it's useful for debugging.
    
    ---------
    
    Co-authored-by: Bastian Köcher <[email protected]>
    Co-authored-by: command-bot <>
    Co-authored-by: Michal Kucharczyk <[email protected]>
    3 people authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    f2fe6a4 View commit details
    Browse the repository at this point in the history
  6. add Rotko common good parachain nodes (paritytech#2533)

    rotko networks parachain bootnodes 
    ```
    # array of commands for testing
    parachains=(
      "./polkadot-parachain --chain asset-hub-polkadot --reserved-only --reserved-nodes /dns/mint14.rotko.net/tcp/33514/p2p/12D3KooWKkzLjYF6M5eEs7nYiqEtRqY8SGVouoCwo3nCWsRnThDW --no-hardware-benchmarks"
      "./polkadot-parachain --chain asset-hub-polkadot --reserved-only --reserved-nodes /dns/mint14.rotko.net/tcp/34514/ws/p2p/12D3KooWKkzLjYF6M5eEs7nYiqEtRqY8SGVouoCwo3nCWsRnThDW --no-hardware-benchmarks"
      "./polkadot-parachain --chain asset-hub-polkadot --reserved-only --reserved-nodes /dns/mint14.rotko.net/tcp/35514/wss/p2p/12D3KooWKkzLjYF6M5eEs7nYiqEtRqY8SGVouoCwo3nCWsRnThDW --no-hardware-benchmarks"
      "./polkadot-parachain --chain asset-hub-kusama --reserved-only --reserved-nodes /dns/mine14.rotko.net/tcp/33524/p2p/12D3KooWJUFnjR2PNbsJhudwPVaWCoZy1acPGKjM2cSuGj345BBu --no-hardware-benchmarks"
      "./polkadot-parachain --chain asset-hub-kusama --reserved-only --reserved-nodes /dns/mine14.rotko.net/tcp/34524/ws/p2p/12D3KooWJUFnjR2PNbsJhudwPVaWCoZy1acPGKjM2cSuGj345BBu --no-hardware-benchmarks"
      "./polkadot-parachain --chain asset-hub-kusama --reserved-only --reserved-nodes /dns/mine14.rotko.net/tcp/35524/wss/p2p/12D3KooWJUFnjR2PNbsJhudwPVaWCoZy1acPGKjM2cSuGj345BBu --no-hardware-benchmarks"
      "./polkadot-parachain --chain asset-hub-westend --reserved-only --reserved-nodes /dns/wmint14.rotko.net/tcp/33534/p2p/12D3KooWE4UDXqgtTcMCyUQ8S4uvaT8VMzzTBA6NWmKuYwTacWuN --no-hardware-benchmarks"
      "./polkadot-parachain --chain asset-hub-westend --reserved-only --reserved-nodes /dns/wmint14.rotko.net/tcp/34534/ws/p2p/12D3KooWE4UDXqgtTcMCyUQ8S4uvaT8VMzzTBA6NWmKuYwTacWuN --no-hardware-benchmarks"
      "./polkadot-parachain --chain asset-hub-westend --reserved-only --reserved-nodes /dns/wmint14.rotko.net/tcp/35534/wss/p2p/12D3KooWE4UDXqgtTcMCyUQ8S4uvaT8VMzzTBA6NWmKuYwTacWuN --no-hardware-benchmarks"
      "./polkadot-parachain --chain bridge-hub-polkadot --reserved-only --reserved-nodes /dns/pbr13.rotko.net/tcp/33543/p2p/12D3KooWMxZY7tDc2Rh454VaJJ7RexKAXVS6xSBEvTnXSGCnuGDw --no-hardware-benchmarks"
      "./polkadot-parachain --chain bridge-hub-polkadot --reserved-only --reserved-nodes /dns/pbr13.rotko.net/tcp/34543/ws/p2p/12D3KooWMxZY7tDc2Rh454VaJJ7RexKAXVS6xSBEvTnXSGCnuGDw --no-hardware-benchmarks"
      "./polkadot-parachain --chain bridge-hub-polkadot --reserved-only --reserved-nodes /dns/pbr13.rotko.net/tcp/35543/wss/p2p/12D3KooWMxZY7tDc2Rh454VaJJ7RexKAXVS6xSBEvTnXSGCnuGDw --no-hardware-benchmarks"
      "./polkadot-parachain --chain bridge-hub-kusama --reserved-only --reserved-nodes /dns/kbr13.rotko.net/tcp/33553/p2p/12D3KooWAmBp54mUEYtvsk2kxNEsDbAvdUMcaghxKXgUQxmPEQ66 --no-hardware-benchmarks"
      "./polkadot-parachain --chain bridge-hub-kusama --reserved-only --reserved-nodes /dns/kbr13.rotko.net/tcp/34553/ws/p2p/12D3KooWAmBp54mUEYtvsk2kxNEsDbAvdUMcaghxKXgUQxmPEQ66 --no-hardware-benchmarks"
      "./polkadot-parachain --chain bridge-hub-kusama --reserved-only --reserved-nodes /dns/kbr13.rotko.net/tcp/35553/wss/p2p/12D3KooWAmBp54mUEYtvsk2kxNEsDbAvdUMcaghxKXgUQxmPEQ66 --no-hardware-benchmarks"
      "./polkadot-parachain --chain bridge-hub-westend --reserved-only --reserved-nodes /dns/wbr13.rotko.net/tcp/33563/p2p/12D3KooWJyeRHpxZZbfBCNEgeUFzmRC5AMSAs2tJhjJS1k5hULkD --no-hardware-benchmarks"
      "./polkadot-parachain --chain bridge-hub-westend --reserved-only --reserved-nodes /dns/wbr13.rotko.net/tcp/34563/ws/p2p/12D3KooWJyeRHpxZZbfBCNEgeUFzmRC5AMSAs2tJhjJS1k5hULkD --no-hardware-benchmarks"
      "./polkadot-parachain --chain bridge-hub-westend --reserved-only --reserved-nodes /dns/wbr13.rotko.net/tcp/35563/wss/p2p/12D3KooWJyeRHpxZZbfBCNEgeUFzmRC5AMSAs2tJhjJS1k5hULkD --no-hardware-benchmarks"
      "./polkadot-parachain --chain collectives-polkadot --reserved-only --reserved-nodes /dns/pch13.rotko.net/tcp/33573/wss/p2p/12D3KooWRXudHoazPZ9osMfdY38e8CBxQLD4RhrVeHpRSNNpcDtH --no-hardware-benchmarks"
      "./polkadot-parachain --chain collectives-polkadot --reserved-only --reserved-nodes /dns/pch13.rotko.net/tcp/34573/wss/p2p/12D3KooWRXudHoazPZ9osMfdY38e8CBxQLD4RhrVeHpRSNNpcDtH --no-hardware-benchmarks"
      "./polkadot-parachain --chain collectives-polkadot --reserved-only --reserved-nodes /dns/pch13.rotko.net/tcp/35573/wss/p2p/12D3KooWRXudHoazPZ9osMfdY38e8CBxQLD4RhrVeHpRSNNpcDtH --no-hardware-benchmarks"
      "./polkadot-parachain --chain collectives-westend --reserved-only --reserved-nodes /dns/wch13.rotko.net/tcp/33593/p2p/12D3KooWPG85zhuSRoyptjLkFD4iJFistjiBmc15JgQ96B4fdXYr --no-hardware-benchmarks"
      "./polkadot-parachain --chain collectives-westend --reserved-only --reserved-nodes /dns/wch13.rotko.net/tcp/34593/ws/p2p/12D3KooWPG85zhuSRoyptjLkFD4iJFistjiBmc15JgQ96B4fdXYr --no-hardware-benchmarks"
      "./polkadot-parachain --chain collectives-westend --reserved-only --reserved-nodes /dns/wch13.rotko.net/tcp/35593/wss/p2p/12D3KooWPG85zhuSRoyptjLkFD4iJFistjiBmc15JgQ96B4fdXYr --no-hardware-benchmarks"
    )
    ```
    hitchhooker authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    19f665f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8f03570 View commit details
    Browse the repository at this point in the history
  8. ParachainHost: No need to be generic over the block or hash type (par…

    …itytech#2537)
    
    The `BlockNumber` and `Hash` are fixed types any way.
    bkchr authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    d3d301f View commit details
    Browse the repository at this point in the history
  9. Adding LuckyFriday's Bootnodes per IBP Application (paritytech#2538)

    Good day,
    
    This PR requests the inclusion of two bootnode entries for Polkadot,
    Kusama and Westend as part of LuckyFriday's IBP application. The nodes
    are hosted on self-owned hardware in a co-located facility. We've
    undertaken connectivity tests ourselves and also from members of the
    IBP.
    
    The test commands used are as follows:
    
    ```
    polkadot --chain westend --base-path /tmp/node --name "Boot" --reserved-only --reserved-nodes "/dns/ibp-boot-westend.luckyfriday.io/tcp/30334/wss/p2p/12D3KooWDg1YEytdwFFNWroFj6gio4YFsMB3miSbHKgdpJteUMB9" --no-hardware-benchmarks
    
    polkadot --chain westend --base-path /tmp/node --name "Boot" --reserved-only --reserved-nodes "/dns/ibp-boot-westend.luckyfriday.io/tcp/30333/p2p/12D3KooWDg1YEytdwFFNWroFj6gio4YFsMB3miSbHKgdpJteUMB9" --no-hardware-benchmarks
    
    polkadot --chain kusama --base-path /tmp/node --name "Boot" --reserved-only --reserved-nodes "/dns/ibp-boot-kusama.luckyfriday.io/tcp/30334/wss/p2p/12D3KooW9vu1GWHBuxyhm7rZgD3fhGZpNajPXFexadvhujWMgwfT" --no-hardware-benchmarks
    
    polkadot --chain kusama --base-path /tmp/node --name "Boot" --reserved-only --reserved-nodes "/dns/ibp-boot-kusama.luckyfriday.io/tcp/30333/p2p/12D3KooW9vu1GWHBuxyhm7rZgD3fhGZpNajPXFexadvhujWMgwfT" --no-hardware-benchmarks
    
    polkadot --chain polkadot --base-path /tmp/node --name "Boot" --reserved-only --reserved-nodes "/dns/ibp-boot-polkadot.luckyfriday.io/tcp/30334/wss/p2p/12D3KooWEjk6QXrZJ26fLpaajisJGHiz6WiQsR8k7mkM9GmWKnRZ" --no-hardware-benchmarks
    
    polkadot --chain polkadot --base-path /tmp/node --name "Boot" --reserved-only --reserved-nodes "/dns/ibp-boot-polkadot.luckyfriday.io/tcp/30333/p2p/12D3KooWEjk6QXrZJ26fLpaajisJGHiz6WiQsR8k7mkM9GmWKnRZ" --no-hardware-benchmarks
    ```
    
    All tests yielded syncing with 1 peer, a positive result. We have also
    backed up our node-key in the event that restoration is required.
    
    I hope that the aforementioned meets the requirement for inclusion and
    look forward to a speedy turnaround.
    
    Kind Regards,
    Will | Paradox
    paradox-tt authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    2858cbc View commit details
    Browse the repository at this point in the history
  10. sp-api: Sprinkle some automatically_derived attributes

    This attribute is informing tooling that the code is automatically
    derived and thus, should not enable any linting.
    bkchr committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    08f29af View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    eb46b99 View commit details
    Browse the repository at this point in the history
  12. chainHead: Backport error codes from spec (paritytech#2539)

    This PR backports the error codes from the spec.
    
    This relies on two specs for defining the error codes:
    - Our rpc-spec-v2 https://github.com/paritytech/json-rpc-interface-spec.
    - JSON-RPC spec https://www.jsonrpc.org/specification#error_object.
    
    To better describe the error codes, they are divided into two separate
    modules `rpc_spec_v2` and `json_rpc_spec` respectively.
    
    The `InvalidSubscriptionID` and `FetchBlockHeader` are merged into the
    JSON-RPC spec `INTERNAL_ERROR`.
    While the other error codes are adjusted from spec.
    
    Errors that are currently in use:
    - -32801 block hash not reported by chainHead_follow or block hash has
    been unpinned
    - -32802 chainHead_follow started with withRuntime == false
    - -32803 chainHead_follow did not generate an
    operationWaitingForContinue event
    
    The following are errors defined in the [JSON-RPC
    spec](https://www.jsonrpc.org/specification#error_object):
    - -32602 The provided parameter isn't one of the expected values, has
    different format or is missing
    - -32603 Internal server error
    
    Note: Error `-32801` must be introduced and generated by the outstanding
    paritytech#1505
    
    Closes: paritytech#2530
    
    ---------
    
    Signed-off-by: Alexandru Vasile <[email protected]>
    lexnv authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    ecdf343 View commit details
    Browse the repository at this point in the history
  13. state-db: log_target usage fixed (paritytech#2547)

    Use `LOG_TARGET/LOG_TARGET_PIN` in logs.
    michalkucharczyk authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    c68ce6e View commit details
    Browse the repository at this point in the history
  14. Parachain Template: Prune AuxStore bound and corresponding crate de…

    …pendency (paritytech#2303)
    
    This small PR removes an unnecessary trait bound to the `AuxStore` trait
    from the Parachain template's `rpc.rs` file.
    
    With that bound removed, the entire dependency on `sc-client-api` can
    also be removed.
    
    ---------
    
    Co-authored-by: Joshy Orndorff <[email protected]>
    Co-authored-by: Bastian Köcher <[email protected]>
    3 people authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    f69069b View commit details
    Browse the repository at this point in the history
  15. Contracts: use compiled rust tests (paritytech#2347)

    see paritytech#2189
    
    This PR does the following:
    - Bring the user api functions into a new pallet-contracts-uapi (They
    are currently defined in ink!
    [here])(https://github.com/paritytech/ink/blob/master/crates/env/src/engine/on_chain/ext.rs)
    - Add older api versions and unstable to the user api trait.
    - Remove pallet-contracts-primitives and bring the types it defined in
    uapi / pallet-contracts
    - Add the infrastructure to build fixtures from Rust files and test it
    works by replacing `dummy.wat` and `call.wat`
    - Move all the doc from wasm/runtime.rs to pallet-contracts-uapi.
    
    This will be done in a follow up:
    - convert the rest of the test from .wat to rust
    - bring risc-v uapi up to date with wasm
    - finalize the uapi host fns, making sure everything is codegen from the
    source host fns in pallet-contracts
    
    ---------
    
    Co-authored-by: Alexander Theißen <[email protected]>
    pgherveou and athei authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    2135fa8 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. upgraded review bot to 2.3.0 (paritytech#2549)

    Upgraded to version 2.3.0 which includes:
    - paritytech/review-bot#103
    - paritytech/review-bot#102
    Bullrich authored Nov 30, 2023
    Configuration menu
    Copy the full SHA
    e41a0e7 View commit details
    Browse the repository at this point in the history
  2. Register metrics for the notification handles (paritytech#2562)

    Add metrics for notification handles so substream events are correctly
    reported to Prometheus
    altonen authored Nov 30, 2023
    Configuration menu
    Copy the full SHA
    180a6ad View commit details
    Browse the repository at this point in the history
  3. Introduce Polkadot-Sdk developer_hub (paritytech#2102)

    This PR introduces the new crate `developer_hub` into the polkadot-sdk
    repo. The vision for the developer-hub crate is detailed in [this
    document](https://docs.google.com/document/d/1XLLkFNE8v8HLvZpI2rzsa8N2IN1FcKntc8q-Sc4xBAk/edit?usp=sharing).
    
    <img width="1128" alt="Screenshot 2023-11-02 at 10 45 48"
    src="https://github.com/paritytech/polkadot-sdk/assets/5588131/1e12b60f-fef5-42c4-8503-a3ba234077c3">
    
    
    Other than adding the new crate, it also does the following: 
    
    * Remove the `substrate` crate, as there is now a unique umbrella crate
    for multiple things in `developer_hub::polkadot_sdk`.
    * (backport candidate) A minor change to `frame-support` macros that
    allows `T::RuntimeOrigin` to also be acceptable as the origin type.
    * (backport candidate) A minor change to `frame-system` that allows us
    to deposit events at genesis because now the real genesis config is
    generated via wasm, and we can safely assume `cfg!(feature = "std")`
    means only testing. related to #62.
    * (backport candidate) Introduces a small `read_events_for_pallet` to
    `frame_system` for easier event reading in tests.
    * From paritytech/polkadot-sdk-docs#31, it
    takes action on improving the `pallet::call` docs.
    * From paritytech/polkadot-sdk-docs#31, it
    takes action on improving the `UncheckedExtrinsic` docs.
    
    ## Way Forward
    
    First, a version of this is deployed temporarily
    [here](https://blog.kianenigma.nl/polkadot-sdk/developer_hub/index.html).
    I will keep it up to date on a daily basis.
    
    ### This Pull Request
    
    I see two ways forward: 
    
    1. We acknowledge that everything in `developer-hub` is going to be WIP,
    and merge this asap. We should not yet use links to this crate anywhere.
    2. We make this be the feature branch, make PRs against this, and either
    gradually backport it, or only merge to master once it is done.
    
    I am personally in favor of option 1. If we stick to option 2, we need a
    better way to deploy a staging version of this to gh-pages.
    
    ### Issue Tracking
    
    The main issues related to the future of `developer_hub` are: 
    
    - paritytech/polkadot-sdk-docs#31
    - paritytech/polkadot-sdk-docs#4
    - paritytech/polkadot-sdk-docs#26 
    - paritytech/polkadot-sdk-docs#32
    - paritytech/polkadot-sdk-docs#36
    
    
    ### After This Pull Request
    
    - [ ] create a redirect for
    https://paritytech.github.io/polkadot-sdk/master/substrate/
    - [x] analytics 
    - [ ] link checker
    - [ ] the matter of publishing, and how all of these relative links for
    when we do, that is still an open question. There is section on this in
    the landing page.
    - [ ] updated https://paritytech.github.io/
    
    ---------
    
    Co-authored-by: Liam Aharon <[email protected]>
    Co-authored-by: Juan Girini <[email protected]>
    Co-authored-by: bader y <[email protected]>
    Co-authored-by: Sebastian Kunert <[email protected]>
    Co-authored-by: James Wilson <[email protected]>
    Co-authored-by: Michal Kucharczyk <[email protected]>
    7 people authored Nov 30, 2023
    Configuration menu
    Copy the full SHA
    eaf1bc5 View commit details
    Browse the repository at this point in the history
  4. Withdraw Assets Before Checking Out in OnReapIdentity impl (parityt…

    …ech#2552)
    
    Follow up to fix a bug from paritytech#1814 discovered in XCM emulator testing.
    
    I mistakenly thought that checking out an asset would withdraw it from
    the sender. This actually withdraws the asset before checking out.
    
    ---------
    
    Co-authored-by: Adrian Catangiu <[email protected]>
    Co-authored-by: Liam Aharon <[email protected]>
    3 people authored Nov 30, 2023
    Configuration menu
    Copy the full SHA
    64361ac View commit details
    Browse the repository at this point in the history
  5. PoV Reclaim (Clawback) Node Side (paritytech#1462)

    This PR provides the infrastructure for the pov-reclaim mechanism
    discussed in paritytech#209. The goal is to provide the current proof size to the
    runtime so it can be used to reclaim storage weight.
    
    ## New Host Function
    - A new host function is provided
    [here](https://github.com/skunert/polkadot-sdk/blob/5b317fda3be205f4136f10d4490387ccd4f9765d/cumulus/primitives/pov-reclaim/src/lib.rs#L23).
    It returns the size of the current proof size to the runtime. If
    recording is not enabled, it returns 0.
    
    ## Implementation Overview
    - Implement option to enable proof recording during import in the
    client. This is currently enabled for `polkadot-parachain`,
    `parachain-template` and the cumulus test node.
    - Make the proof recorder ready for no-std. It was previously only
    enabled for std environments, but we need to record the proof size in
    `validate_block` too.
    - Provide a recorder implementation that only the records the size of
    incoming nodes and does not store the nodes itself.
    - Fix benchmarks that were broken by async backing changes
    - Provide new externalities extension that is registered by default if
    proof recording is enabled.
    - I think we should discuss the naming, pov-reclaim was more intuitive
    to me, but we could also go with clawback like in the issue.
    
    ## Impact of proof recording during import
    With proof recording: 6.3058 Kelem/s
    Without proof recording: 6.3427 Kelem/s
    
    The measured impact on the importing performance is quite low on my
    machine using the block import benchmark. With proof recording I am
    seeing a performance hit of 0.585%.
    
    ---------
    
    Co-authored-by: command-bot <>
    Co-authored-by: Davide Galassi <[email protected]>
    Co-authored-by: Bastian Köcher <[email protected]>
    3 people authored Nov 30, 2023
    Configuration menu
    Copy the full SHA
    9a650c4 View commit details
    Browse the repository at this point in the history
  6. Add missing glossary to ref docs (paritytech#2572)

    This PR is the same as
    paritytech#2273, but that one had
    too many conflicts after a base change. As it is a just one file PR I
    decided to start over with a clean slate.
    
    ---
    This PR adds some missing glossary definitions to the Developer Hub ref
    docs
    
    FIxes paritytech/polkadot-sdk-docs#40
    juangirini authored Nov 30, 2023
    Configuration menu
    Copy the full SHA
    c30ed6f View commit details
    Browse the repository at this point in the history
  7. Bump the known_good_semver group with 2 updates (paritytech#2570)

    Bumps the known_good_semver group with 2 updates:
    [serde](https://github.com/serde-rs/serde) and
    [clap](https://github.com/clap-rs/clap).
    
    Updates `serde` from 1.0.188 to 1.0.193
    <details>
    <summary>Release notes</summary>
    <p><em>Sourced from <a
    href="https://github.com/serde-rs/serde/releases">serde's
    releases</a>.</em></p>
    <blockquote>
    <h2>v1.0.193</h2>
    <ul>
    <li>Fix field names used for the deserialization of
    <code>RangeFrom</code> and <code>RangeTo</code> (<a
    href="https://redirect.github.com/serde-rs/serde/issues/2653">#2653</a>,
    <a
    href="https://redirect.github.com/serde-rs/serde/issues/2654">#2654</a>,
    <a
    href="https://redirect.github.com/serde-rs/serde/issues/2655">#2655</a>,
    thanks <a
    href="https://github.com/emilbonnek"><code>@​emilbonnek</code></a>)</li>
    </ul>
    <h2>v1.0.192</h2>
    <ul>
    <li>Allow internal tag field in untagged variant (<a
    href="https://redirect.github.com/serde-rs/serde/issues/2646">#2646</a>,
    thanks <a
    href="https://github.com/robsdedude"><code>@​robsdedude</code></a>)</li>
    </ul>
    <h2>v1.0.191</h2>
    <ul>
    <li>Documentation improvements</li>
    </ul>
    <h2>v1.0.190</h2>
    <ul>
    <li>Preserve NaN sign when deserializing f32 from f64 or vice versa (<a
    href="https://redirect.github.com/serde-rs/serde/issues/2637">#2637</a>)</li>
    </ul>
    <h2>v1.0.189</h2>
    <ul>
    <li>Fix &quot;cannot infer type&quot; error when internally tagged enum
    contains untagged variant (<a
    href="https://redirect.github.com/serde-rs/serde/issues/2613">#2613</a>,
    thanks <a href="https://github.com/ahl"><code>@​ahl</code></a>)</li>
    </ul>
    </blockquote>
    </details>
    <details>
    <summary>Commits</summary>
    <ul>
    <li><a
    href="https://github.com/serde-rs/serde/commit/44613c7d0190dbb5ecd2d5ec19c636f45b7488cc"><code>44613c7</code></a>
    Release 1.0.193</li>
    <li><a
    href="https://github.com/serde-rs/serde/commit/c706281df3c8d50dba1763f19c856df2746eba6c"><code>c706281</code></a>
    Merge pull request <a
    href="https://redirect.github.com/serde-rs/serde/issues/2655">#2655</a>
    from dtolnay/rangestartend</li>
    <li><a
    href="https://github.com/serde-rs/serde/commit/65d75b8fe3105f00ab2e01537d568d4587167582"><code>65d75b8</code></a>
    Add RangeFrom and RangeTo tests</li>
    <li><a
    href="https://github.com/serde-rs/serde/commit/332b0cba40bcbcc7a6b23a9706277c54791a9856"><code>332b0cb</code></a>
    Merge pull request <a
    href="https://redirect.github.com/serde-rs/serde/issues/2654">#2654</a>
    from dtolnay/rangestartend</li>
    <li><a
    href="https://github.com/serde-rs/serde/commit/8c4af412969086bc8f54fdc2a079d373632e0a03"><code>8c4af41</code></a>
    Fix more RangeFrom / RangeEnd mixups</li>
    <li><a
    href="https://github.com/serde-rs/serde/commit/24a78f071b22ae491eec4127be696ac255b9b5d3"><code>24a78f0</code></a>
    Merge pull request <a
    href="https://redirect.github.com/serde-rs/serde/issues/2653">#2653</a>
    from emilbonnek/fix/range-to-from-de-mixup</li>
    <li><a
    href="https://github.com/serde-rs/serde/commit/c91c33436d7aaef7472ebc18b734ddc9b5bd11fa"><code>c91c334</code></a>
    Fix Range{From,To} deserialize mixup</li>
    <li><a
    href="https://github.com/serde-rs/serde/commit/2083f43a287cac8302009fda5bbe41518dd83209"><code>2083f43</code></a>
    Update ui test suite to nightly-2023-11-19</li>
    <li><a
    href="https://github.com/serde-rs/serde/commit/4676abdc9e6bbbddfb33a00ce8d7e81e92f01120"><code>4676abd</code></a>
    Release 1.0.192</li>
    <li><a
    href="https://github.com/serde-rs/serde/commit/35700eb23e21d8cb198ef4a422ddad13b855ce3b"><code>35700eb</code></a>
    Merge pull request <a
    href="https://redirect.github.com/serde-rs/serde/issues/2646">#2646</a>
    from robsdedude/fix/2643/allow-tag-field-in-untagged</li>
    <li>Additional commits viewable in <a
    href="https://github.com/serde-rs/serde/compare/v1.0.188...v1.0.193">compare
    view</a></li>
    </ul>
    </details>
    <br />
    
    Updates `clap` from 4.4.6 to 4.4.10
    <details>
    <summary>Release notes</summary>
    <p><em>Sourced from <a
    href="https://github.com/clap-rs/clap/releases">clap's
    releases</a>.</em></p>
    <blockquote>
    <h2>v4.4.10</h2>
    <h2>[4.4.10] - 2023-11-28</h2>
    <h3>Documentation</h3>
    <ul>
    <li>Link out to changelog</li>
    <li>Cross link derive's attribute reference to derive tutorial</li>
    </ul>
    <h2>v4.4.9</h2>
    <h2>[4.4.9] - 2023-11-27</h2>
    <h3>Fixes</h3>
    <ul>
    <li><em>(help)</em> Show correct <code>Command::about</code> under
    flattened headings</li>
    <li><em>(help)</em> Respect <code>hide</code> when flattening
    subcommands</li>
    </ul>
    <h2>v4.4.8</h2>
    <h2>[4.4.8] - 2023-11-10</h2>
    <h3>Features</h3>
    <ul>
    <li>Add <code>Command::flatten_help</code> to allow <code>git stash
    -h</code> like help for subcommands</li>
    </ul>
    </blockquote>
    </details>
    <details>
    <summary>Changelog</summary>
    <p><em>Sourced from <a
    href="https://github.com/clap-rs/clap/blob/master/CHANGELOG.md">clap's
    changelog</a>.</em></p>
    <blockquote>
    <h2>[4.4.10] - 2023-11-28</h2>
    <h3>Documentation</h3>
    <ul>
    <li>Link out to changelog</li>
    <li>Cross link derive's attribute reference to derive tutorial</li>
    </ul>
    <h2>[4.4.9] - 2023-11-27</h2>
    <h3>Fixes</h3>
    <ul>
    <li><em>(help)</em> Show correct <code>Command::about</code> under
    flattened headings</li>
    <li><em>(help)</em> Respect <code>hide</code> when flattening
    subcommands</li>
    </ul>
    <h2>[4.4.8] - 2023-11-10</h2>
    <h3>Features</h3>
    <ul>
    <li>Add <code>Command::flatten_help</code> to allow <code>git stash
    -h</code> like help for subcommands</li>
    </ul>
    <h2>[4.4.7] - 2023-10-24</h2>
    <h3>Performance</h3>
    <ul>
    <li>Reduced code size</li>
    </ul>
    </blockquote>
    </details>
    <details>
    <summary>Commits</summary>
    <ul>
    <li><a
    href="https://github.com/clap-rs/clap/commit/c0a1814d3c1d93c18faaedc95fd251846e47f4fe"><code>c0a1814</code></a>
    chore: Release</li>
    <li><a
    href="https://github.com/clap-rs/clap/commit/c83e681e20b05f7e128088f47f8fcfc44e8ea166"><code>c83e681</code></a>
    docs: Update changelog</li>
    <li><a
    href="https://github.com/clap-rs/clap/commit/91bcac4ca9d442786f554abeb7b1ed6d7a464a42"><code>91bcac4</code></a>
    Merge pull request <a
    href="https://redirect.github.com/clap-rs/clap/issues/5230">#5230</a>
    from epage/migrate</li>
    <li><a
    href="https://github.com/clap-rs/clap/commit/030d87505d150345ddd425c1df21c034d2ae7748"><code>030d875</code></a>
    docs: Link out to the changelog at the relevant tag</li>
    <li><a
    href="https://github.com/clap-rs/clap/commit/b661a9de04aebd1adaaafdbf7e470f07a8d8a36d"><code>b661a9d</code></a>
    Merge pull request <a
    href="https://redirect.github.com/clap-rs/clap/issues/5229">#5229</a>
    from epage/derive</li>
    <li><a
    href="https://github.com/clap-rs/clap/commit/a08587b00e347492165ded1415bad6ab339e9f0b"><code>a08587b</code></a>
    docs(derive): Link to tutorial sections for attributes</li>
    <li><a
    href="https://github.com/clap-rs/clap/commit/21b671f689bc0b8d790dc8c42902c22822bf6f82"><code>21b671f</code></a>
    chore: Release</li>
    <li><a
    href="https://github.com/clap-rs/clap/commit/93ba76dbaaf9136313a4fe2978693cc39fa467dd"><code>93ba76d</code></a>
    docs: Update changelog</li>
    <li><a
    href="https://github.com/clap-rs/clap/commit/c1c55b30d853446e2cab78664c0d22c1b77d4dfd"><code>c1c55b3</code></a>
    Merge pull request <a
    href="https://redirect.github.com/clap-rs/clap/issues/5228">#5228</a>
    from epage/flat</li>
    <li><a
    href="https://github.com/clap-rs/clap/commit/b13f6d98622b80ba30e63c2c6e65d218cc8a4de3"><code>b13f6d9</code></a>
    fix(help): Hide 'help' if only flattened subcommand</li>
    <li>Additional commits viewable in <a
    href="https://github.com/clap-rs/clap/compare/v4.4.6...v4.4.10">compare
    view</a></li>
    </ul>
    </details>
    <br />
    
    
    Dependabot will resolve any conflicts with this PR as long as you don't
    alter it yourself. You can also trigger a rebase manually by commenting
    `@dependabot rebase`.
    
    [//]: # (dependabot-automerge-start)
    [//]: # (dependabot-automerge-end)
    
    ---
    
    <details>
    <summary>Dependabot commands and options</summary>
    <br />
    
    You can trigger Dependabot actions by commenting on this PR:
    - `@dependabot rebase` will rebase this PR
    - `@dependabot recreate` will recreate this PR, overwriting any edits
    that have been made to it
    - `@dependabot merge` will merge this PR after your CI passes on it
    - `@dependabot squash and merge` will squash and merge this PR after
    your CI passes on it
    - `@dependabot cancel merge` will cancel a previously requested merge
    and block automerging
    - `@dependabot reopen` will reopen this PR if it is closed
    - `@dependabot close` will close this PR and stop Dependabot recreating
    it. You can achieve the same result by closing it manually
    - `@dependabot show <dependency name> ignore conditions` will show all
    of the ignore conditions of the specified dependency
    - `@dependabot ignore <dependency name> major version` will close this
    group update PR and stop Dependabot creating any more for the specific
    dependency's major version (unless you unignore this specific
    dependency's major version or upgrade to it yourself)
    - `@dependabot ignore <dependency name> minor version` will close this
    group update PR and stop Dependabot creating any more for the specific
    dependency's minor version (unless you unignore this specific
    dependency's minor version or upgrade to it yourself)
    - `@dependabot ignore <dependency name>` will close this group update PR
    and stop Dependabot creating any more for the specific dependency
    (unless you unignore this specific dependency or upgrade to it yourself)
    - `@dependabot unignore <dependency name>` will remove all of the ignore
    conditions of the specified dependency
    - `@dependabot unignore <dependency name> <ignore condition>` will
    remove the ignore condition of the specified dependency and ignore
    conditions
    
    
    </details>
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Nov 30, 2023
    Configuration menu
    Copy the full SHA
    6742aba View commit details
    Browse the repository at this point in the history
  8. Remove dependency on rand's SliceRandom shuffle implementation in gos…

    …sip-support (paritytech#2555)
    
    In gossip-support, we shuffled the list of authorities using the
    `rand::seq::SliceRandom::shuffle`. This function's behavior is
    unspecified beyond being `O(n)` and could change in the future, leading
    to network issues between nodes using different shuffling algorithms. In
    practice, the implementation was a Fisher-Yates shuffle. This PR
    replaces the call with a re-implementation of Fisher-Yates and adds a
    test to ensure the behavior is the same between the two at the moment.
    rphmeier authored Nov 30, 2023
    Configuration menu
    Copy the full SHA
    1f2ccae View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. Add recorded_keys function to get recorded keys from the proof reco…

    …rder (paritytech#2561)
    
    # Description
    
    - What does this PR do?
    This PR adds function to get recorded keys from proof recorder instance
    - Why are these changes needed?
    This change is required to get the keys accessed by the trie backend
    during the runtime execution. The keys are already tracked by proof
    recorder, just aren't exposed publicly.
    - How were these changes implemented and what do they affect?
    The changes are implemented by adding a public function in proof
    recorder that simply clones the `recorded_keys` field. It is pure
    addition of function and AFAIK does not affect anything.
    
    
    # Checklist
    
    - [x] My PR includes a detailed description as outlined in the
    "Description" section above
    - [ ] My PR follows the [labeling requirements](CONTRIBUTING.md#Process)
    of this project (at minimum one label for `T`
      required)
    - [ ] I have made corresponding changes to the documentation (if
    applicable)
    - [ ] I have added tests that prove my fix is effective or that my
    feature works (if applicable)
    
    ---------
    
    Co-authored-by: Bastian Köcher <[email protected]>
    ParthDesai and bkchr authored Dec 1, 2023
    Configuration menu
    Copy the full SHA
    5213263 View commit details
    Browse the repository at this point in the history
  2. Enforce consistent and correct toml formatting (paritytech#2518)

    Using taplo, fixes all our broken and inconsistent toml formatting and
    adds CI to keep them tidy.
    
    If people want we can customise the format rules as described here
    https://taplo.tamasfe.dev/configuration/formatter-options.html
    
    @ggwpez, I suggest zepter is used only for checking features are
    propagated, and leave formatting for taplo to avoid duplicate work and
    conflicts.
    
    TODO
    - [x] Use `exclude = [...]` syntax in taplo file to ignore zombienet
    tests instead of deleting the dir
    
    ---------
    
    Signed-off-by: Oliver Tale-Yazdi <[email protected]>
    Co-authored-by: Oliver Tale-Yazdi <[email protected]>
    Co-authored-by: Bastian Köcher <[email protected]>
    3 people authored Dec 1, 2023
    Configuration menu
    Copy the full SHA
    4a293bc View commit details
    Browse the repository at this point in the history
  3. Contracts: make benchmark dependencies optional in std feature (par…

    …itytech#2576)
    
    `wasm-instrument` and `rand` are optional and only used in benchmarking,
    so should not be pulled in by default as part of the `std` feature.
    ascjones authored Dec 1, 2023
    Configuration menu
    Copy the full SHA
    dfd7b15 View commit details
    Browse the repository at this point in the history
  4. Bump proc-macro-crate from 1.3.1 to 2.0.0 (paritytech#2557)

    Bumps [proc-macro-crate](https://github.com/bkchr/proc-macro-crate) from
    1.3.1 to 2.0.0.
    <details>
    <summary>Release notes</summary>
    <p><em>Sourced from <a
    href="https://github.com/bkchr/proc-macro-crate/releases">proc-macro-crate's
    releases</a>.</em></p>
    <blockquote>
    <h2>v2.0.0</h2>
    <h2>What's Changed</h2>
    <ul>
    <li>Release 2.0.0 by <a
    href="https://github.com/bkchr"><code>@​bkchr</code></a> in <a
    href="https://redirect.github.com/bkchr/proc-macro-crate/pull/39">bkchr/proc-macro-crate#39</a></li>
    </ul>
    <p><strong>Full Changelog</strong>: <a
    href="https://github.com/bkchr/proc-macro-crate/compare/v1.3.1...v2.0.0">https://github.com/bkchr/proc-macro-crate/compare/v1.3.1...v2.0.0</a></p>
    </blockquote>
    </details>
    <details>
    <summary>Commits</summary>
    <ul>
    <li><a
    href="https://github.com/bkchr/proc-macro-crate/commit/cc100ed2bc1ac9bb81812fd435a43e2ef023f355"><code>cc100ed</code></a>
    Merge pull request <a
    href="https://redirect.github.com/bkchr/proc-macro-crate/issues/39">#39</a>
    from bkchr/bkchr-2.0.0</li>
    <li><a
    href="https://github.com/bkchr/proc-macro-crate/commit/39a7c1844fc4d73ef397a7e8d9419f1f3381aa44"><code>39a7c18</code></a>
    Release 2.0.0</li>
    <li>See full diff in <a
    href="https://github.com/bkchr/proc-macro-crate/compare/v1.3.1...v2.0.0">compare
    view</a></li>
    </ul>
    </details>
    <br />
    
    
    [![Dependabot compatibility
    score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=proc-macro-crate&package-manager=cargo&previous-version=1.3.1&new-version=2.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
    
    Dependabot will resolve any conflicts with this PR as long as you don't
    alter it yourself. You can also trigger a rebase manually by commenting
    `@dependabot rebase`.
    
    [//]: # (dependabot-automerge-start)
    [//]: # (dependabot-automerge-end)
    
    ---
    
    <details>
    <summary>Dependabot commands and options</summary>
    <br />
    
    You can trigger Dependabot actions by commenting on this PR:
    - `@dependabot rebase` will rebase this PR
    - `@dependabot recreate` will recreate this PR, overwriting any edits
    that have been made to it
    - `@dependabot merge` will merge this PR after your CI passes on it
    - `@dependabot squash and merge` will squash and merge this PR after
    your CI passes on it
    - `@dependabot cancel merge` will cancel a previously requested merge
    and block automerging
    - `@dependabot reopen` will reopen this PR if it is closed
    - `@dependabot close` will close this PR and stop Dependabot recreating
    it. You can achieve the same result by closing it manually
    - `@dependabot show <dependency name> ignore conditions` will show all
    of the ignore conditions of the specified dependency
    - `@dependabot ignore <dependency name> major version` will close this
    group update PR and stop Dependabot creating any more for the specific
    dependency's major version (unless you unignore this specific
    dependency's major version or upgrade to it yourself)
    - `@dependabot ignore <dependency name> minor version` will close this
    group update PR and stop Dependabot creating any more for the specific
    dependency's minor version (unless you unignore this specific
    dependency's minor version or upgrade to it yourself)
    - `@dependabot ignore <dependency name>` will close this group update PR
    and stop Dependabot creating any more for the specific dependency
    (unless you unignore this specific dependency or upgrade to it yourself)
    - `@dependabot unignore <dependency name>` will remove all of the ignore
    conditions of the specified dependency
    - `@dependabot unignore <dependency name> <ignore condition>` will
    remove the ignore condition of the specified dependency and ignore
    conditions
    
    
    </details>
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Dec 1, 2023
    Configuration menu
    Copy the full SHA
    7f0beaf View commit details
    Browse the repository at this point in the history
  5. Sassafras Consensus Pallet (paritytech#1577)

    This PR introduces the pallet for Sassafras consensus.
    
    ## Non Goals
    
    The pallet delivers only the bare-bones and doesn't deliver support for
    auxiliary functionalities such as equivocation report and support for
    epoch change via session pallet.
    
    These functionalities were drafted in the [main
    PR](paritytech#1336), but IMO is
    better to introduce this auxiliary stuff in a follow up PR and after
    client code.
    
    ## Potential follow ups
    
    paritytech#2364
    
    ---------
    
    Co-authored-by: Sebastian Kunert <[email protected]>
    Co-authored-by: Koute <[email protected]>
    Co-authored-by: Michal Kucharczyk <[email protected]>
    Co-authored-by: André Silva <[email protected]>
    Co-authored-by: Bastian Köcher <[email protected]>
    6 people authored Dec 1, 2023
    Configuration menu
    Copy the full SHA
    095f4bd View commit details
    Browse the repository at this point in the history
  6. Bump the known_good_semver group with 1 update (paritytech#2575)

    Bumps the known_good_semver group with 1 update:
    [syn](https://github.com/dtolnay/syn).
    
    Updates `syn` from 2.0.38 to 2.0.39
    <details>
    <summary>Release notes</summary>
    <p><em>Sourced from <a
    href="https://github.com/dtolnay/syn/releases">syn's
    releases</a>.</em></p>
    <blockquote>
    <h2>2.0.39</h2>
    <ul>
    <li>Fix parsing of return expression in match guards (<a
    href="https://redirect.github.com/dtolnay/syn/issues/1528">#1528</a>)</li>
    <li>Improve error message on labeled loop as value expression for break
    (<a
    href="https://redirect.github.com/dtolnay/syn/issues/1531">#1531</a>)</li>
    </ul>
    </blockquote>
    </details>
    <details>
    <summary>Commits</summary>
    <ul>
    <li><a
    href="https://github.com/dtolnay/syn/commit/924217c1734c085ee6cdb5e198d36d610c234313"><code>924217c</code></a>
    Release 2.0.39</li>
    <li><a
    href="https://github.com/dtolnay/syn/commit/95aeeb559866368d8b910d388c8e04b96083666a"><code>95aeeb5</code></a>
    Merge pull request <a
    href="https://redirect.github.com/dtolnay/syn/issues/1531">#1531</a>
    from dtolnay/breaklabel</li>
    <li><a
    href="https://github.com/dtolnay/syn/commit/b88f86fae5c1ac284179181bf7a34549e6d96d7c"><code>b88f86f</code></a>
    Ignore single_element_loop clippy lint in test</li>
    <li><a
    href="https://github.com/dtolnay/syn/commit/a876185366557cb0e0e175c3be48721c8cc0d8e6"><code>a876185</code></a>
    Improve error on break followed by labeled loop</li>
    <li><a
    href="https://github.com/dtolnay/syn/commit/32ab9794d6b75248c1946ae18baab12a46137eb0"><code>32ab979</code></a>
    Add test of ambiguous label parsing in break</li>
    <li><a
    href="https://github.com/dtolnay/syn/commit/6f658f88a213e25b7ac7ec2dc77c537de679b745"><code>6f658f8</code></a>
    Merge pull request <a
    href="https://redirect.github.com/dtolnay/syn/issues/1530">#1530</a>
    from dtolnay/canbeginexpr</li>
    <li><a
    href="https://github.com/dtolnay/syn/commit/20497e1a555812cfe05769b4d8c117c4e0e4edbd"><code>20497e1</code></a>
    More precise decision to parse expression after return keyword</li>
    <li><a
    href="https://github.com/dtolnay/syn/commit/c6a651aa12447d50c22db3189ef38cff90fc267b"><code>c6a651a</code></a>
    Update name of ExprReturn parse function to match variant name</li>
    <li><a
    href="https://github.com/dtolnay/syn/commit/c2745901009f7d65e7b708cd80031642038f765e"><code>c274590</code></a>
    Indicate that peek argument refers to syn::Ident</li>
    <li><a
    href="https://github.com/dtolnay/syn/commit/3e67cb0c660fc906770d212465652bfeb7a75727"><code>3e67cb0</code></a>
    Merge pull request <a
    href="https://redirect.github.com/dtolnay/syn/issues/1529">#1529</a>
    from dtolnay/up</li>
    <li>Additional commits viewable in <a
    href="https://github.com/dtolnay/syn/compare/2.0.38...2.0.39">compare
    view</a></li>
    </ul>
    </details>
    <br />
    
    
    [![Dependabot compatibility
    score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=syn&package-manager=cargo&previous-version=2.0.38&new-version=2.0.39)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
    
    Dependabot will resolve any conflicts with this PR as long as you don't
    alter it yourself. You can also trigger a rebase manually by commenting
    `@dependabot rebase`.
    
    [//]: # (dependabot-automerge-start)
    [//]: # (dependabot-automerge-end)
    
    ---
    
    <details>
    <summary>Dependabot commands and options</summary>
    <br />
    
    You can trigger Dependabot actions by commenting on this PR:
    - `@dependabot rebase` will rebase this PR
    - `@dependabot recreate` will recreate this PR, overwriting any edits
    that have been made to it
    - `@dependabot merge` will merge this PR after your CI passes on it
    - `@dependabot squash and merge` will squash and merge this PR after
    your CI passes on it
    - `@dependabot cancel merge` will cancel a previously requested merge
    and block automerging
    - `@dependabot reopen` will reopen this PR if it is closed
    - `@dependabot close` will close this PR and stop Dependabot recreating
    it. You can achieve the same result by closing it manually
    - `@dependabot show <dependency name> ignore conditions` will show all
    of the ignore conditions of the specified dependency
    - `@dependabot ignore <dependency name> major version` will close this
    group update PR and stop Dependabot creating any more for the specific
    dependency's major version (unless you unignore this specific
    dependency's major version or upgrade to it yourself)
    - `@dependabot ignore <dependency name> minor version` will close this
    group update PR and stop Dependabot creating any more for the specific
    dependency's minor version (unless you unignore this specific
    dependency's minor version or upgrade to it yourself)
    - `@dependabot ignore <dependency name>` will close this group update PR
    and stop Dependabot creating any more for the specific dependency
    (unless you unignore this specific dependency or upgrade to it yourself)
    - `@dependabot unignore <dependency name>` will remove all of the ignore
    conditions of the specified dependency
    - `@dependabot unignore <dependency name> <ignore condition>` will
    remove the ignore condition of the specified dependency and ignore
    conditions
    
    
    </details>
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Dec 1, 2023
    Configuration menu
    Copy the full SHA
    87a73e7 View commit details
    Browse the repository at this point in the history
  7. sassafras: taplo happy (paritytech#2583)

    fixes: `taplo format check`
    michalkucharczyk authored Dec 1, 2023
    Configuration menu
    Copy the full SHA
    5789d6a View commit details
    Browse the repository at this point in the history
  8. Bandersnatch: ring-context generic over domain size (paritytech#2581)

    Serialized length is now statically computed depending on the domain
    size.
    
    Opens the primitive to more generic usages not related to Sassafras
    expectations
    
    Address one point of
    paritytech#2364
    davxy authored Dec 1, 2023
    Configuration menu
    Copy the full SHA
    ecfdb2b View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2023

  1. Removed instruction to call init.sh when buidling from source (parity…

    …tech#2580)
    
    # Description
    
    Removed instruction to call init.sh when buidling from source from the
    polkadot readme.
    jonathanudd authored Dec 2, 2023
    Configuration menu
    Copy the full SHA
    f5051c8 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. Configuration menu
    Copy the full SHA
    707dbcc View commit details
    Browse the repository at this point in the history
  2. Fixes runtime type with doc parsing in derive_impl (paritytech#2594)

    Step in paritytech#171
    
    This PR fixes a bug in `derive_impl` causing `#[inject_runtime_type]`
    attribute to be parsed incorrectly when docs are added.
    gupnik authored Dec 4, 2023
    Configuration menu
    Copy the full SHA
    35c39c9 View commit details
    Browse the repository at this point in the history
  3. Cleanup XCMP QueueConfigData (paritytech#2142)

    Removes obsolete fields from the `QueueConfigData` structure. For the
    remaining fields, if they use the old defaults, we replace them with the
    new defaults.
    
    Resolves: paritytech#1795
    serban300 authored Dec 4, 2023
    Configuration menu
    Copy the full SHA
    1266de3 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. Merge branch 'master' into update-snowbridge

    # Conflicts:
    #	Cargo.lock
    #	cumulus/parachains/runtimes/bridge-hubs/bridge-hub-polkadot/src/lib.rs
    #	cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/Cargo.toml
    #	cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/xcm_config.rs
    #	cumulus/polkadot-parachain/src/command.rs
    claravanstaden authored and claravanstaden committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    ae4d24c View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. fix tests

    claravanstaden authored and claravanstaden committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    b03a1e7 View commit details
    Browse the repository at this point in the history