This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polkadot assets on ethereum #128
Polkadot assets on ethereum #128
Changes from 10 commits
6019c8d
c613fc6
9672b52
c017bfe
3dc37ea
1f00024
a20a8b7
41104d5
a8b006b
b8a75d1
fec5a63
a683680
3621de4
f7ed096
36bb656
cf091f6
4921280
10c5e10
587fb6e
f56567d
c792204
a81b87f
ce91a8c
f3c9d11
41aa563
d6c6330
faf8f73
7001866
1edad16
933130a
8ace79e
40cc470
2d8f3b1
5a4f3af
50983ed
5ad44df
8a79d89
0251493
fa70f7b
3d0fae3
25c819a
3cb2f05
3a94733
9d900b2
33ea85e
d64e783
79fb3b5
8609eed
3f1ded3
0e06cae
4a04f1f
0d3988c
f1155b1
a44db43
0f0fd8e
f5c6b92
1095bff
21fa444
2675241
42933da
760d697
a550c42
736fe90
d1b8d16
897fdad
e733321
31c75e9
009402e
949fb45
b38b20c
0b2f782
62eef65
39a84b9
5ae8b0b
6ca963d
79e62fa
8a4f582
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto. Location version is implicitly v4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a683680
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change was rolled back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alistair-singh We should not use VersionedLocation for fields in storage. There is other commentary in the PR about this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is stopping someone from rolling over xcm versions prelude without us knowing and breaking the lookup of Tokens?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With paritytech@5ef32c8 will just not compile.