Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pre-Loader]: A better pre loader is added in the portfolio #110 #112

Closed

Conversation

PranjaliBhardwaj
Copy link
Contributor

Description

A better preloader is added , the colors are according to the portfolio color scheme and makes overall UI of webpage better. Pre loader is important and simple part of the webpage. The required code is added using simple HTML and CSS. as per the request. The task was to make a pre loader which aligns with the aesthetics of webpage. This design is new and makes it look beautiful as it is different from spinner pre loader which is very common.

Changes Made

Changes are made in HTML tag in div and CSS with keyframes and required animations.

Screenshots/Preview (if applicable)

image

@PranjaliBhardwaj
Copy link
Contributor Author

IN URL you are seeing signupfs, is actually i copy the code in my html to test, so this is the test page screenshot but this is how that pre loader looks. This screenshot is just for providing the looks of the Preloader. I have also checked it twice it works pretty well.

styles.css Outdated
}

html, body {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementing these properties globally in the HTML and body substantially disrupts the main website. The scroll functionality is being hindered, and the application of 'display: flex' is causing displacement of elements from their current positions.

@ayushichoudhary-19
Copy link
Member

Hey @PranjaliBhardwaj, the loader in the screenshot looks great. However, there are merge conflicts that need to be resolved. Also, your code seems to have an issue, as highlighted above. Please make the requested changes soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants