Skip to content

Commit

Permalink
Fix for incorrect maven repository link (#5)
Browse files Browse the repository at this point in the history
## Background (Why?)

Repo is using not publicly available repository
gcs://snapengine-maven-publish/releases which is preventing from
building the solution

## Change/Solution (What?)

Replace 
```
        maven {
            url "gcs://snapengine-maven-publish/releases"
        }
```
by
```
    google()
    mavenCentral()
```
Based on the PR
#2

## Screenshots for any visual changes

N/A

## Test Plans

Manually validated on iOS and Android devices
  • Loading branch information
jciereszko1 authored Sep 19, 2024
1 parent 274f0db commit 43dbef3
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 15 deletions.
10 changes: 4 additions & 6 deletions android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,8 @@ buildscript {
}

repositories {
maven {
url "gcs://snapengine-maven-publish/releases"
}
google()
mavenCentral()
}

dependencies {
Expand Down Expand Up @@ -68,9 +67,8 @@ android {
}

repositories {
maven {
url "gcs://snapengine-maven-publish/releases"
}
google()
mavenCentral()
}

def kotlin_version = getExtOrDefault("kotlinVersion")
Expand Down
5 changes: 2 additions & 3 deletions example/android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,8 @@ android {
}

repositories {
maven {
url "gcs://snapengine-maven-publish/releases"
}
google()
mavenCentral()
}

dependencies {
Expand Down
5 changes: 2 additions & 3 deletions example/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,8 @@ buildscript {
ndkVersion = "23.1.7779620"
}
repositories {
maven {
url "gcs://snapengine-maven-publish/releases"
}
google()
mavenCentral()
}
dependencies {
classpath("com.android.tools.build:gradle")
Expand Down
4 changes: 2 additions & 2 deletions example/ios/Podfile.lock
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
PODS:
- boost (1.76.0)
- camera-kit-react-native (0.2.0):
- camera-kit-react-native (0.3.0):
- RCT-Folly (= 2021.07.22.00)
- React-Core
- SCCameraKit
Expand Down Expand Up @@ -581,7 +581,7 @@ EXTERNAL SOURCES:

SPEC CHECKSUMS:
boost: 57d2868c099736d80fcd648bf211b4431e51a558
camera-kit-react-native: 7c28fe4ca2e7bc9caae183187b9570ae698f21fa
camera-kit-react-native: 2378f165123e067664b67f8b3c5c7d8803aba23c
DoubleConversion: 5189b271737e1565bdce30deb4a08d647e3f5f54
FBLazyVector: 5fbbff1d7734827299274638deb8ba3024f6c597
FBReactNativeSpec: 638095fe8a01506634d77b260ef8a322019ac671
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@snap/camera-kit-react-native",
"version": "0.2.0",
"version": "0.3.0",
"description": "Camera Kit wrapper for React Native",
"main": "lib/commonjs/index",
"module": "lib/module/index",
Expand Down

0 comments on commit 43dbef3

Please sign in to comment.