accept other audio formats for AudioTaskView #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjcope
reviewed
Sep 4, 2024
|
|
||
| const ext = filename.toLowerCase().split(".").pop(); | ||
| if(type === "subs" && ext != "vtt"){ | ||
| Notification.show(`Unable to load - Only ${type === "subs"?".vtt":".mp3,.m4a"} files are currently supported.`, "warning"); |
There was a problem hiding this comment.
With this restructuring, the type === "subs" check isn't really necessary anymore
|
Yes, the support aspect is why we limited it originally. I will talk to my team and see about opening it up. I generally don't like the idea of supporting content that can ultimately make it look like things are broken, but I understand the need as things have moved beyond mp3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AudioTaskView currently only accepts
mp3audio uploads. While this is the only compressed audio format that has 100% support (source: caniuse.com across browsers, some tools (eg: apple's audio recorder) now defaults to more modern formats.I propose a softer requirement where partially-supported formats would just trigger an alert though I'll understand if you want to keep stricter requirements.