Ensure request callback is invoked on client connection error

SmingHub · Oct 22, 2021 · bee6408 · bee6408
1 parent 9e4c779
commit bee6408
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/Sming/Components/Network/src/Network/Http/HttpClientConnection.cpp b/Sming/Components/Network/src/Network/Http/HttpClientConnection.cpp
@@ -61,6 +61,20 @@ void HttpClientConnection::reset()
 	HttpConnection::reset();
 }
 
+void HttpClientConnection::onError(err_t err)
+{
+	HttpConnection::onError(err);
+
+	auto request = waitingQueue.peek();
+
+	if(request != nullptr) {
+		auto callback = request->requestCompletedDelegate;
+		if(callback) {
+			callback(*this, false);
+		}
+	}
+}
+
 int HttpClientConnection::onMessageBegin(http_parser* parser)
 {
 	incomingRequest = executionQueue.peek();

diff --git a/Sming/Components/Network/src/Network/Http/HttpClientConnection.h b/Sming/Components/Network/src/Network/Http/HttpClientConnection.h
@@ -68,6 +68,7 @@ class HttpClientConnection : public HttpConnection
 
 	// TCP methods
 	void onReadyToSendData(TcpConnectionEvent sourceEvent) override;
+	void onError(err_t err) override;
 
 	void onClosed() override;