Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add powder snow block to the list of blocks that the Explosive Shovel can break #4241

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RenanMsV
Copy link
Contributor

Description

Hello, I was playing the minecraft 1.20.4 and noticed that the Explosive Shovel can't break powder snow blocks. I believe they should be able to break this block.

Proposed changes

Add powder snow block to the list of blocks that the Explosive Shovel can break.

Related Issues (if applicable)

An issue is that this block came in minecraft 1.17, so most likely 1.16 would not be compatible.
This might not be an issue but this block drops nothing, since it can only be collected with buckets like a liquid.

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

Copy link
Contributor

Your Pull Request was automatically labelled as: "🧹 Chores"
Thank you for contributing to this project! ❤️

@github-actions github-actions bot added the 🧹 Chores Refactoring / Cleanup. label Sep 12, 2024
Copy link
Contributor

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: 95b70e8

https://preview-builds.walshy.dev/download/Slimefun/4241/95b70e88

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

@Boomer-1
Copy link

with 1.21, support will be dropped for 1.16.x and 1.17, so it might be worth waiting to merge until after the 1.21 release if it's approved.

@ybw0014
Copy link
Contributor

ybw0014 commented Sep 13, 2024

to make it compatible right now, u need to mark it as not required, like the soul_soil field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 Chores Refactoring / Cleanup.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants