Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Run breakdown #499

Open
wants to merge 13 commits into
base: dev
Choose a base branch
from
Open

feat: Run breakdown #499

wants to merge 13 commits into from
+118 −6

Conversation

TakoTheDev
Copy link
Contributor

@TakoTheDev TakoTheDev commented Sep 13, 2024 •
edited
Loading

Ugly design, open for suggestions!

image

  • maybe have 2 options instead of 1 selector?

@TakoTheDev TakoTheDev mentioned this pull request Sep 13, 2024
Closed
@TakoTheDev
Copy link
Contributor Author

TakoTheDev commented Sep 13, 2024 •
edited
Loading

no idea why it decided to delete src/main/kotlin/gg/skytils/skytilsws/shared/structs/BoundingBox.kt and src/main/kotlin/gg/skytils/skytilsws/shared/structs/CHWaypointType.kt, ig I'll revert and push that once I get the complaints from lily

My-Name-Is-Jeff
My-Name-Is-Jeff requested changes Sep 14, 2024
View reviewed changes
src/main/kotlin/gg/skytils/skytilsmod/listeners/DungeonListener.kt Outdated
@@ -150,7 +151,7 @@ object DungeonListener {
if (room.foundSecrets != sec) {
room.foundSecrets = sec
if (team.size > 1)
WSClient.sendPacketAsync(C2SPacketDungeonRoomSecret(SBInfo.server ?: return@setFoundSecrets, room.mainRoom.data.name, sec))
WSClient.sendPacketAsync(C2SPacketDungeonRoomSecret(SBInfo.server ?: return@setFoundSecrets, room.mainRoom.data.name, sec, mc.thePlayer.name))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the point of this? two players can have the same update at the same time and can be in the same room at the same time

additionally the server is aware of the sender of the packet

@TakoTheDev
Copy link
Contributor Author

TakoTheDev commented Sep 14, 2024 •
edited
Loading

I can't really test rooms and secrets, since I can't keep a websocket connection for some reason, so would be nice if someone else could test it <3 (Even on the version in Releases, I think it's internet issue)

@My-Name-Is-Jeff
Copy link
Member

My-Name-Is-Jeff commented Sep 20, 2024 •
edited
Loading

I can't really test rooms and secrets, since I can't keep a websocket connection for some reason, so would be nice if someone else could test it <3 (Even on the version in Releases, I think it's internet issue)

make sure you did not modify packets. the server cannot parse modified packets due to protobuf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@My-Name-Is-Jeff My-Name-Is-Jeff My-Name-Is-Jeff requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TakoTheDev @My-Name-Is-Jeff