Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dungeon fixes + Enchantments small fix #488

Merged
merged 6 commits into from
Aug 9, 2024
Merged

Dungeon fixes + Enchantments small fix #488

merged 6 commits into from
Aug 9, 2024

Conversation

zealerker22
Copy link
Contributor

  • Fixed sending "Blaze Done" message earlier than expected if a Blaze puzzle was reset, due to total number of blaze kills wasn't cleared
  • Fixed resetting a puzzle in Dungeons doesn't change number of missing/failed puzzles, affecting score calculation
  • Fixed all Turbo-[crop] (e.g. Turbo-Potato) enchantments having exact same enchantment abbreviation (aka. "Tur.") by changing them w.r.t. actual crops
  • Attempt for a checkmark texture update for Catlas

@zealerker22
enchantment abbr. improvement
256b36a 
 - Turbo-[crop] enchantments now has abbreviations respective to the crops instead of showing "Tur." for all variations (e.g. Turbo-Potato now has abbr. "Pot.", Turbo-Wart now has abbr. "War.")
@zealerker22
checkmark texture update
a6eff6d 
- checkmarks looks a bit nicer now
@zealerker22
fixed puzzle resets not updating failed puzzle amount
22a9992
@zealerker22
fixed incorrect occurrence for "Blaze Done" message
fb93dd6 
 - now in blaze puzzle the counter actually counts for the amount of blazes killed per attempt instead of a cumulative count
(yes you could trigger Blaze Done message after failing Blaze 10 times in a row)
Sychic
Sychic reviewed Jul 6, 2024
View reviewed changes
Copy link
Member

@Sychic Sychic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the two images supposed to be 10x9?

src/main/kotlin/gg/skytils/skytilsmod/features/impl/misc/ItemFeatures.kt Outdated Show resolved Hide resolved
@zealerker22
Copy link
Contributor Author

Any other suggestions?

@My-Name-Is-Jeff
Copy link
Member

Are the two images supposed to be 10x9?

@zealerker22

@Sychic
Copy link
Member

Sychic commented Aug 9, 2024 via email

@My-Name-Is-Jeff
Copy link
Member

Isn’t this question already answered
…
On Thu, Aug 8, 2024 at 11:11 PM My-Name-Is-Jeff @.> wrote: Are the two images supposed to be 10x9? @zealerker22 https://github.com/zealerker22 — Reply to this email directly, view it on GitHub <#488 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALLJT32BLSWDQWTZ433UWPLZQQXMHAVCNFSM6AAAAABKMON7M6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZXGA3DANZSGI . You are receiving this because you commented.Message ID: @.>

where

@My-Name-Is-Jeff
Copy link
Member

Isn’t this question already answered
…
On Thu, Aug 8, 2024 at 11:11 PM My-Name-Is-Jeff @.> wrote: Are the two images supposed to be 10x9? @zealerker22 https://github.com/zealerker22 — Reply to this email directly, view it on GitHub <#488 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALLJT32BLSWDQWTZ433UWPLZQQXMHAVCNFSM6AAAAABKMON7M6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZXGA3DANZSGI . You are receiving this because you commented.Message ID: _@**.**_>

where

oh

@My-Name-Is-Jeff My-Name-Is-Jeff merged commit 599e13e into Skytils:dev Aug 9, 2024
1 check passed
My-Name-Is-Jeff pushed a commit that referenced this pull request Aug 9, 2024
@zealerker22 @My-Name-Is-Jeff
fix: Dungeon fixes + Enchantments small fix (#488)
178a5cf 
* Fixed sending "Blaze Done" message earlier than expected if a Blaze puzzle was reset, due to total number of blaze kills wasn't cleared

* Fixed resetting a puzzle in Dungeons doesn't change number of missing/failed puzzles, affecting score calculation

* Fixed all Turbo-[crop] (e.g. Turbo-Potato) enchantments having exact same enchantment abbreviation (aka. "Tur.") by changing them w.r.t. actual crops

* Attempt for a checkmark texture update for Catlas
My-Name-Is-Jeff pushed a commit that referenced this pull request Aug 9, 2024
@zealerker22 @My-Name-Is-Jeff
fix: Dungeon fixes + Enchantments small fix (#488)
df82208 
* Fixed sending "Blaze Done" message earlier than expected if a Blaze puzzle was reset, due to total number of blaze kills wasn't cleared

* Fixed resetting a puzzle in Dungeons doesn't change number of missing/failed puzzles, affecting score calculation

* Fixed all Turbo-[crop] (e.g. Turbo-Potato) enchantments having exact same enchantment abbreviation (aka. "Tur.") by changing them w.r.t. actual crops

* Attempt for a checkmark texture update for Catlas
My-Name-Is-Jeff pushed a commit that referenced this pull request Aug 9, 2024
@zealerker22 @My-Name-Is-Jeff
fix: Dungeon fixes + Enchantments small fix (#488)
e3bc274 
* Fixed sending "Blaze Done" message earlier than expected if a Blaze puzzle was reset, due to total number of blaze kills wasn't cleared

* Fixed resetting a puzzle in Dungeons doesn't change number of missing/failed puzzles, affecting score calculation

* Fixed all Turbo-[crop] (e.g. Turbo-Potato) enchantments having exact same enchantment abbreviation (aka. "Tur.") by changing them w.r.t. actual crops

* Attempt for a checkmark texture update for Catlas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sychic Sychic Sychic left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zealerker22 @My-Name-Is-Jeff @Sychic