Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add breeding #7110

Open
wants to merge 62 commits into
base: dev/feature
Choose a base branch
from
Open

Add breeding #7110

wants to merge 62 commits into from

Conversation

Efnilite
Copy link
Member

@Efnilite Efnilite commented Sep 22, 2024

Description

Continuation of #5584. Reverts the breaking change in ExprExperience in the previous PR.

  • Added EntityBreedEvent
  • Added EntityEnterLoveModeEvent
  • Added ExprBreedingFamily
  • Added CondCanAge
  • Added CondCanBreed
  • Added EffAllowAging
  • Added EffBreedable
  • Added ExprLoveTime
  • Added CondIsAdult, CondIsChild
  • Added EffMakeAdult
  • Updated ExprExperience
  • Added tests for everything

Thanks @Fusezion!


Target Minecraft Versions: any
Requirements: none
Related Issues: #5111

Fusezion and others added 30 commits March 29, 2023 20:33
📎 Added EntityEnterLoveModeEvent
🐷 Added EntityBreedEvent
✨ Added EventValues for these events
👪 Added family expression for Father, Mother, Child, and Breeder
✨ Added breeding experience to experience class
*update class to current standards
✨ Added condition for checking ageable
✨ Added condition for checking breedable
✨ Added effect for toggle breedable
✨ Added effect for locking age
✨ Added expression for love ticks
🐛 Fixed issue with `livingentities`
🐛 Added class exist checks for Breedable instances
✨ Added RequirePlugins annotation to select classes
📋 Added test for ExprLoveTime & CondIsInLove
📋 Addes test for EffBreedable & CondCanBreed
📋 Added test fpr EffLockAge & CondCanAge
✨ Added Condition for checking is adult
✨ Added Effect to make an entity a baby or adult
📋 Added test for these syntaxes
🔵 1.16 for any mob, below that is animals only
Thanks for all these formatting changes it's just what I wanted when waking up

Co-authored-by: Ayham Al Ali <[email protected]>
✨ Renamed expression to ExprLoveTicks
✨ Added support for ticks via integers
📋 Added a new test for using integers
📋 Removed unneeded test condition
✨ Changed expression for father, mother and offspring a bit
✨ Converted get to a switch statement
🐛 Fixed an issue where set allowed more than one value
🐛 Fixed a typo in examples
✨ Added a spacer to examples
Just adds some notes in descriptions to bring more light to animal exclusive syntax

Co-Authored-By: Ayham Al Ali <[email protected]>
🐛 fix accidental forgotten example
🔴 remove integer support from love ticks expression
📋 remove a test from CondIsInLove.sk

Co-Authored-By: Ayham Al Ali <[email protected]>
🐛 Fixed an issue with ExprLoveTicks not working correctly
📋 Updated test to include more checks for add, remove and reset
Co-Authored-By: Ayham Al Ali <[email protected]>
@Efnilite Efnilite added the feature Pull request adding a new feature. label Sep 22, 2024
src/main/java/ch/njol/skript/conditions/CondCanAge.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/conditions/CondCanBreed.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/conditions/CondIsAdult.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/conditions/CondIsChild.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffAllowAging.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffMakeAdult.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/events/SimpleEvents.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/events/SimpleEvents.java Outdated Show resolved Hide resolved
@Efnilite Efnilite requested review from Asleeepp and sovdeeth and removed request for Asleeepp September 23, 2024 21:04
src/main/java/ch/njol/skript/conditions/CondCanAge.java Outdated Show resolved Hide resolved
@Examples({
"on right click on living entity:",
"\tevent-entity can't breed",
"\tsend \"Turns out %event-entity% is not breedable. Must be a Skript user!\" to player"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💀

src/main/java/ch/njol/skript/conditions/CondCanBreed.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/conditions/CondIsBaby.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/conditions/CondIsInLove.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/events/SimpleEvents.java Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull request adding a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants