Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR is a draft to act more as a proposal and wanting feedback on it first before making ready to review. I'm aware of the implications behind this being merge for addons.
This PR aims to complete one of my older issues, the intended design changed a bit, due to breaking everything implemented without defining canParse and as a means to better handle this in the future.
Before Sovde ask if there is any benefit to changing this, my response is yes, not only was it impossible to omit the usage of
.parse()
(or the canParse part) due to it previously returning true by default and spamming the server with UnsupportedOperationExceptionm but is also a core part of the parser class and should be handled as one.This is a breaking change for addons that did the same thing as skript and rely on the default implementation of true, however the change itself is very light and most addons could easily add the method without breaking anything else, if someone has a better implementation that doesn't break old addons that were abandoned or discontinued I'm willing to hear ideas. Although I would prefer to, not see a repeat of
Timespan#fromTicks_i()
Target Minecraft Versions: any
Requirements: none
Related Issues: #5971