Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Detonate effect #6898

Open
wants to merge 61 commits into
base: dev/feature
Choose a base branch
from

Conversation

EquipableMC
Copy link
Contributor

Description

This simply adds the ability to detonate an entity. This makes it easy to explode a creeper or detonate a firework instantly


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@Fusezion
Copy link
Contributor

This simply adds the ability to detonate an entity. This makes it easy to explode a creeper or detonate a firework instantly

Hmm correct me if I'm wrong but detonate %projectiles% creepers aren't well projectiles are they?
Also if we're adding multiple entity support, I think merging it into EffCreeperExplode and renaming the file will be a better choice

@EquipableMC
Copy link
Contributor Author

EquipableMC commented Jul 13, 2024

This simply adds the ability to detonate an entity. This makes it easy to explode a creeper or detonate a firework instantly

Hmm correct me if I'm wrong but detonate %projectiles% creepers aren't well projectiles are they? Also if we're adding multiple entity support, I think merging it into EffCreeperExplode and renaming the file will be a better choice

You are correct yes, but this PR was originally intended for fireworks, then some ideas got thrown around and me and others decided to add multiple uses to this effect. It is midnight for me so I am going to finish it tomorrow. You’re not in the discord so you didn’t see my message

@cheeezburga
Copy link
Member

This simply adds the ability to detonate an entity. This makes it easy to explode a creeper or detonate a firework instantly

Hmm correct me if I'm wrong but detonate %projectiles% creepers aren't well projectiles are they? Also if we're adding multiple entity support, I think merging it into EffCreeperExplode and renaming the file will be a better choice

Thats what I said too but Sovde thought it deserved its own effect, coz the creeper one is more like creeper-specific

now fireworks instantly detonate
Copy link
Contributor

@ShaneBeee ShaneBeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some changes needed

src/main/java/ch/njol/skript/effects/EffDetonate.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffDetonate.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffDetonate.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffDetonate.java Outdated Show resolved Hide resolved
Copy link
Member

@cheeezburga cheeezburga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small thing

src/main/java/ch/njol/skript/effects/EffDetonate.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffDetonate.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffDetonate.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffDetonate.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffDetonate.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffDetonate.java Outdated Show resolved Hide resolved
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if you could instantly explode a primed tnt by setting the fuse ticks to 0 (see https://hub.spigotmc.org/javadocs/spigot/org/bukkit/entity/TNTPrimed.html). Might be worth testing as another entity to support.

src/main/java/ch/njol/skript/effects/EffDetonate.java Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull request adding a new feature. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.