Added gamemode to CondIsInvulnerable.java #6741
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Took 1 hour 13 minutes
UnderscoreTud
requested changes
May 28, 2024
src/main/java/ch/njol/skript/conditions/CondIsInvulnerable.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondIsInvulnerable.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondIsInvulnerable.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondIsInvulnerable.java
Outdated
Show resolved
Hide resolved
sovdeeth
requested changes
May 28, 2024
src/main/java/ch/njol/skript/conditions/CondIsInvulnerable.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondIsInvulnerable.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondIsInvulnerable.java
Outdated
Show resolved
Hide resolved
example fixed Co-authored-by: _tud <[email protected]>
since* fixed Co-authored-by: _tud <[email protected]>
only allowing entities and gamemodes* Co-authored-by: _tud <[email protected]>
i literally forgot about curly brackets for a sec Co-authored-by: _tud <[email protected]>
Took 10 minutes
…ion, fixed typo Took 9 minutes
sovdeeth
approved these changes
May 28, 2024
Moderocky
added
the
up for debate
|
tests please! |
src/main/java/ch/njol/skript/conditions/CondIsInvulnerable.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Patrick Miller <[email protected]>
Pikachu920
reviewed
Jun 8, 2024
| @Since("2.5, INSERT VERSION (gamemode)") | ||
| @RequiredPlugins("Paper 1.20.6+ (gamemodes)") | ||
| public class CondIsInvulnerable extends PropertyCondition<Object> { | ||
| private static final boolean GAMEMODE = Skript.methodExists(GameMode.class,"isInvulnerable"); |
There was a problem hiding this comment.
missing a space after the comma
There was a problem hiding this comment.
can we also name this SUPPORTS_GAMEMODE or something besides just gamemode
Took 5 minutes
sovdeeth
requested changes
Jun 8, 2024
src/test/skript/tests/syntaxes/conditions/CondIsInvulnerable.sk
Outdated
Show resolved
Hide resolved
Co-authored-by: sovdee <[email protected]>
Took 8 minutes
# Conflicts: # src/test/skript/tests/syntaxes/conditions/CondIsInvulnerable.sk Took 47 seconds
Took 2 minutes
sovdeeth
approved these changes
Aug 14, 2024
src/test/skript/tests/syntaxes/conditions/CondIsInvulnerable.sk
Outdated
Show resolved
Hide resolved
Co-authored-by: sovdee <[email protected]>
UnderscoreTud
approved these changes
Aug 16, 2024
src/test/skript/tests/syntaxes/conditions/CondIsInvulnerable.sk
Outdated
Show resolved
Hide resolved
Co-authored-by: _tud <[email protected]>
sovdeeth
added
enhancement
Moderocky
approved these changes
Aug 17, 2024
|
tests failing due to invalid syntax |
sovdeeth
removed
the
feature-ready
sovdeeth
requested changes
Sep 22, 2024
src/test/skript/tests/syntaxes/conditions/CondIsInvulnerable.sk
Outdated
Show resolved
Hide resolved
sovdeeth
requested changes
Sep 26, 2024
src/test/skript/tests/syntaxes/conditions/CondIsInvulnerable.sk
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added gamemode to ConsIsInvulnerable
Target Minecraft Versions: 1.20.6
Requirements: Paper
Related Issues: none