Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MIT release clause #5388

Open
wants to merge 10 commits into
base: dev/feature
Choose a base branch
from

Conversation

APickledWalrus
Copy link
Member

@APickledWalrus APickledWalrus commented Jan 21, 2023

Description

In the interest of promoting a better open-source community I am proposing adding a new file to track contributors who have elected to release their code under the MIT license. This file will prove useful in the future if we wish to relicense Skript (specifically the API portion) under a new license (like MIT).


Target Minecraft Versions: any
Requirements: n/a
Related Issues: none?

@APickledWalrus APickledWalrus added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Jan 21, 2023
Copy link
Member

@TPGamesNL TPGamesNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code-conventions.md should also be modified, it discusses the license.

.github/pull_request_template.md Outdated Show resolved Hide resolved
This keeps an repo-wide public record
Copy link
Collaborator

@TheLimeGlass TheLimeGlass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An update to the bottom of the main README is required.

@Moderocky Moderocky changed the base branch from master to dev/feature September 18, 2023 10:04
@sovdeeth
Copy link
Member

sovdeeth commented Apr 7, 2024

@APickledWalrus any news on this? It's been over a year of no activity.

@APickledWalrus
Copy link
Member Author

@APickledWalrus any news on this? It's been over a year of no activity.

I've addressed the existing comments. Assuming this is a satisfactory solution for the goal, this should be able to be merged.

Comment on lines +1 to +13
Skript is licensed under the [GNU General Public License (Version 3)](LICENSE).

However, to foster a better open-source community, and in the interest of further opening this project in the future,
we ask contributors to release their code under the [MIT License](MIT.txt).
Since it is less restrictive than GPLv3, it provides us and other developers
with greater flexibility when making use of your code.

To learn more about this license, you can visit [choosealicense.com](https://choosealicense.com/licenses/mit/).

If you wish to release your contributions to this repository under the [MIT License](MIT.txt),
please add your name below in your pull request.

When adding your name, please follow the example format showcased below:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file should be called something different so it doesn't get confused with the actual licence.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think LICENSING would be too similar?

@@ -0,0 +1,17 @@
Permission is hereby granted, free of charge, to any person obtaining a copy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file probably ought to be somewhere else as well because it isn't MIT right now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do you think we should put it? My main intention is to provide a copy of the license text. Do you think it would be fine to just include it as part of the licensing document?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants