Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Falta Completar) Fix #9430 - Error creating a relationship with a specific characters range #3

Draft
wants to merge 1 commit into
base: hotfix-7.10.x
Choose a base branch
from

Conversation

SinergiaCRM
Copy link
Collaborator

Closes salesagility#9430

Description

As mentioned in the issue. It exists an error creating relationships when those relationships name have between 61 and 64 characters.

In this PR we add the modification necessary to work with MySQL-MariaDB databases. We can't test it in any other.

Changes:
include/database/MysqlManager.php Line 113:
As index names will have an additional 3-5 character suffix (_idb1, etc.), set here a shorter max length for them to prevent exceeding the db supported limit of 64 chars.
modules/ModuleBuilder/parsers/relationships/AbstractRelationship.php Line 561:
The function getValidDBName() from AbstractRelationship class doesn't return correctly the shortened indexes "DBManagerFactory::getInstance()->getValidDBName()"

Motivation and Context

How To Test This

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@SinergiaCRM SinergiaCRM changed the title Fix #9430 - Error creating a relationship with a specific characters range (Falta Completar) Fix #9430 - Error creating a relationship with a specific characters range Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant