-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[modelling] Change CostStack backend to an unordered_map type #199
Conversation
9f470d4
to
83fb755
Compare
Some features in this PR (exposing the underlying map type directly to Python) will require the next version of eigenpy, following stack-of-tasks/eigenpy#504 which generalizes @edantec's work added in eigenpy 3.9.0 Maybe we could do some conditional compilation |
9b415a3
to
13452e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from a small question, everything seems fine to me
a46d009
to
4c59e90
Compare
4c59e90
to
f504102
Compare
f504102
to
33ac216
Compare
…t::unordered_map + add casting getter for components
33ac216
to
2388c20
Compare
I'll force merge cos I'm the boss here |
addCost()
now has an overload taking a key (either astd::size_t
or a string)addCost()
returns a reference to the pair of cost function component and weightResolves #195