Fix resizing bold and italic #149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsbernstein
commented
Jan 31, 2024
•
gsbernstein
commented
| Before | After |
|---|---|
 |
 |
gsbernstein
commented
Jan 31, 2024
Comment on lines
+141
to
+142
| let fontMetrics = UIFontMetrics(forTextStyle: textStyle) | ||
| font = fontMetrics.scaledFont(for: customFont) |
There was a problem hiding this comment.
just copied this from above on lines 123-124.
gsbernstein
commented
Jan 31, 2024
Comment on lines
+133
to
+138
| if globalItalic { | ||
| traits.insert(.traitItalic) | ||
| } | ||
| if globalBold { | ||
| traits.insert(.traitBold) | ||
| } |
There was a problem hiding this comment.
In theory this would also allow text to be both bold and italic, which wouldn't work before, however it seems like other bugs in the parsing prevent that.
gsbernstein
force-pushed
the
fix-resizing-bold-and-italic
branch
from
c831c14
to
202f34a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.