Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:feat: adds option to update the events. #297

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Conversation

PRBaraiya
Copy link
Collaborator

@PRBaraiya PRBaraiya commented Nov 24, 2023

Description

This PR adds a new method in EventController named update to update the existing event with the updated one.

This PR also adds some code cleanups in EventController which include,

  • Moves events-specific operations like, add, delete, and update in the CalendarData class.
  • Refactor logic in methods for event manipulation and event fetch.
  • Adds new parameter includeFullDayEvents in getEventsOnDay to decide whether to include full-day events in the returned list or not.
  • Adds getters isRangingEvent and isFullDayEvent in CalendarEventData to check if the event is a ranging event or a full-day event.
  • Adds new method occursOnDate in CalendarEventData to check if the event occurs on the given date or not.
  • Use the includeFullDayEvents flag while getting events for week and day view to avoid unnecessary calculations.

Checklist

  • The title of my PR starts with a [Conventional Commit] prefix (fix:, feat:, docs: etc).
  • I have followed the [Contributor Guide] when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Closes issue #125

@PRBaraiya PRBaraiya force-pushed the feat/issue-125 branch 4 times, most recently from 252bbf8 to e536ddb Compare December 13, 2023 10:55
@ParthBaraiya ParthBaraiya merged commit d65bb7f into master Dec 13, 2023
1 check passed
@ParthBaraiya ParthBaraiya deleted the feat/issue-125 branch December 13, 2023 11:02
@ParthBaraiya ParthBaraiya linked an issue Feb 21, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to update event?
2 participants