Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛Unwanted space at top of dayView while using sliver #225. #251

Merged
merged 1 commit into from
Aug 9, 2023
Merged

fix: 🐛Unwanted space at top of dayView while using sliver #225. #251

merged 1 commit into from
Aug 9, 2023

Conversation

jaiminrana05
Copy link
Collaborator

Description

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@jaiminrana05 jaiminrana05 force-pushed the fix/issue_225_unwanted_space_in_day_view branch from f3ba872 to 3d91969 Compare August 8, 2023 14:26
@jaiminrana05 jaiminrana05 force-pushed the fix/issue_225_unwanted_space_in_day_view branch from 3d91969 to bda779a Compare August 9, 2023 06:16
PRBaraiya
PRBaraiya approved these changes Aug 9, 2023
View reviewed changes
Copy link
Collaborator

@PRBaraiya PRBaraiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PRBaraiya PRBaraiya merged commit c556fb1 into master Aug 9, 2023
1 check passed
@PRBaraiya PRBaraiya deleted the fix/issue_225_unwanted_space_in_day_view branch August 9, 2023 06:39
@DhavalRKansara DhavalRKansara linked an issue Aug 9, 2023 that may be closed by this pull request
Unwanted space at the top of DayView when used inside a Sliver. #225
Closed
@DhavalRKansara DhavalRKansara mentioned this pull request Aug 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PRBaraiya PRBaraiya PRBaraiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unwanted space at the top of DayView when used inside a Sliver.
2 participants
@jaiminrana05 @PRBaraiya