Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ issue #59 provider support to add start duration in the da… #250

Merged
merged 1 commit into from
Aug 8, 2023
Merged

✨ issue #59 provider support to add start duration in the da… #250

merged 1 commit into from
Aug 8, 2023

Conversation

DhavalRKansara
Copy link
Collaborator

…y view calendar.

Description

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Closes #57

PRBaraiya
PRBaraiya requested changes Aug 8, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
lib/src/day_view/day_view.dart Outdated Show resolved Hide resolved
@DhavalRKansara DhavalRKansara force-pushed the fixes/issues_57_default_start_hour_in_day branch 6 times, most recently from c9f1da4 to fe05a2b Compare August 8, 2023 10:04
@DhavalRKansara DhavalRKansara linked an issue Aug 8, 2023 that may be closed by this pull request
Can I set the initial time to be the actual time in day view #221
Closed
@DhavalRKansara DhavalRKansara force-pushed the fixes/issues_57_default_start_hour_in_day branch from fe05a2b to bbc02e8 Compare August 8, 2023 11:51
PRBaraiya
PRBaraiya approved these changes Aug 8, 2023
View reviewed changes
Copy link
Collaborator

@PRBaraiya PRBaraiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PRBaraiya PRBaraiya merged commit c0334eb into master Aug 8, 2023
1 check passed
@PRBaraiya PRBaraiya deleted the fixes/issues_57_default_start_hour_in_day branch August 8, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PRBaraiya PRBaraiya PRBaraiya approved these changes

@ParthBaraiya ParthBaraiya Awaiting requested review from ParthBaraiya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can I set the initial time to be the actual time in day view Change default start hour in DayView
2 participants
@DhavalRKansara @PRBaraiya