-
Notifications
You must be signed in to change notification settings - Fork 44.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(platform): Fix REST API CORS issue + UI build for Firefox #8140
fix(platform): Fix REST API CORS issue + UI build for Firefox #8140
Conversation
PR Reviewer Guide 🔍
|
✅ Deploy Preview for auto-gpt-docs canceled.
|
Have these changes been confirmed to fix the mentioned issues? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and working fine.
Issue described in Builder UI sometimes resets input boxes · Issue #8058 · Significant-Gravitas/AutoGPT, likely has already been fixed by fix(rnd): Fix execution error on non-saved agent by majdyz · Pull Request #8054 · Significant-Gravitas/AutoGPT
So you can close that accordingly.
…thub.com:Significant-Gravitas/AutoGPT into swiftyos/secrt-883-firefox-is-not-working-at-all
@Significant-Gravitas/maintainers Given we are so close to release. Please can you be extra diligent during reviews to ensure no bugs slip through |
I've tested this and can confirm it works (on my machine). The code changed is not something I am familiar with so I'll leave approval to one of the other reviewers who have left comments @aarushik93 @majdyz @Pwuts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Background
We keep getting cors issues when using the platform, also Firefox was not working. This PR aims to fix these issues.
Changes 🏗️
Testing 🔍
Note
Only for the new autogpt platform, currently in autogpt_platform/
Note
Firefox was tested with
yarn run build
yarn run start
to test the production build