Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dx: Set Python type checking mode to "basic" for all subprojects #7599

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

Pwuts
Copy link
Member

@Pwuts Pwuts commented Jul 25, 2024

After talking to Craig (@Swiftyos) yesterday, I realized our Python type checking issues may be aggravated because we haven't set the type checking mode for the repo.

Changes 🏗️

  • Set python.analysis.typeCheckingMode to basic in all subprojects' .vscode/settings.json + all-projects.code-workspace

PR Quality Scorecard ✨

  • Have you used the PR description template?   +2 pts
  • Is your pull request atomic, focusing on a single change?   +5 pts
  • Have you linked the GitHub issue(s) that this PR addresses?   +5 pts
  • Have you documented your changes clearly and comprehensively?   +5 pts
  • Have you changed or added a feature?   -4 pts
    • Have you added/updated corresponding documentation?   +4 pts
    • Have you added/updated corresponding integration tests?   +5 pts
  • Have you changed the behavior of AutoGPT?   -5 pts
    • Have you also run agbenchmark to verify that these changes do not regress performance?   +10 pts

@Pwuts Pwuts requested a review from a team as a code owner July 25, 2024 11:00
@Pwuts Pwuts requested review from ntindle and kcze and removed request for a team July 25, 2024 11:00
Copy link

netlify bot commented Jul 25, 2024

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit a5ed464
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/66a2303fdc7fce000856aded

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.63%. Comparing base (3b0cd95) to head (a5ed464).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7599      +/-   ##
==========================================
- Coverage   53.82%   49.63%   -4.20%     
==========================================
  Files         124      146      +22     
  Lines        7032     8926    +1894     
  Branches      912     1242     +330     
==========================================
+ Hits         3785     4430     +645     
- Misses       3113     4348    +1235     
- Partials      134      148      +14     
Flag Coverage Δ
Linux 49.43% <ø> (-4.15%) ⬇️
Windows 49.73% <ø> (-0.71%) ⬇️
agbenchmark 34.05% <ø> (?)
autogpt-agent 34.09% <ø> (ø)
forge 58.03% <ø> (ø)
macOS 48.90% <ø> (-4.00%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Torantulino Torantulino merged commit 0767b17 into master Jul 25, 2024
36 of 38 checks passed
@Torantulino Torantulino deleted the set-pylance-checking-to-basic branch July 25, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants