-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Add base delta config for anchor roller height #1800
base: master
Are you sure you want to change the base?
Conversation
When calculating scope for anchoring, distance of the anchor roller (or bridle connection point) above the water line should be added to the depth before applying whatever formula or multiplier the sailor is using. Like beam and draft, it's a fixed quality of the vessel, so isn't going to come from a sensor. Having it as a base delta would allow deriving an "anchoring depth" value from draft and depthBelowSurface.
Are you still there? |
Hey, yes ... Currently mostly AFK, back next week. Thanks for the pointer, I'll take a look in that direction as soon as I'm back at a computer |
I finally got a chance to look at this - and the new metadata editor looks pretty cool. Perhaps if we do a similar thing but to allow adding arbitrary paths? Because I hear you on the hardcoded fields part of it all. I think there are ultimately two different but related questions here:
On the first I'd like to advocate that But perhaps for that we need a spec proposal instead? For the second - I really do like the metadata editor approach, and there are some cases I think it will really help. For instance - I have 3 different GPS antennas on my current boat - so I might also make the argument that we should consider sensors.gps.fromBow to be something that should be set on a per-data source basis instead of globally for the boat ... so actually using the metadata editor for that might be a much better approach. I know I can set those values in the Cortex AIS, although I haven't looked to see if it exports those values over NMEA and my boat is currently switched off. OTOH there is something nice, especially for new users, about being able to simply go add things like height, beam and draft without needing to know which signalk paths those translate to. So maybe it's still ok to let a set of basic vessel qualities have an an easy-button way of configuring them? |
When calculating scope for anchoring, distance of the anchor roller (or bridle connection point) above the water line should be added to the depth before applying whatever formula or multiplier the sailor is using. Like beam and draft, it's a fixed quality of the vessel, so isn't going to come from a sensor. Having it as a base delta would allow deriving an "anchoring depth" value from draft and depthBelowSurface.