Add B&G WS320 related PGNs (65309 and 65312) #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
{"canId":486481152,"prio":7,"src":0,"dst":255,"pgn":65309,"time":"1628312401044;A;06:25:52.641","input":["1628312401044;A;06:25:52.641 R 1CFF1D00 13 99 00 4E 0A FF FF 7F"],"fields":{"Manufacturer Code":"Navico","Industry Code":"Marine Industry","Status":0,"Battery Status":78,"Battery Charge Status":10,"Reserved2":8388607},"description":"Navico: Wireless Battery Status","timestamp":"2021-09-05T14:43:06.818Z"}
tkurki
reviewed
Sep 6, 2021
| { | ||
| source: 'Battery Status', | ||
| node: function(n2k){ | ||
| return `instruments.wireless.${n2k.src}.batteryStatus` |
There was a problem hiding this comment.
I don't think using src as the instance identifier makes sense, as it can change essentially randomly when the bus reshuffles addresses. @sbender9 should this be canId?
There was a problem hiding this comment.
Yeah, it should probably use canId. The canId may not be there initially, so should ignore messages until it is there.
|
Please add tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add new PGNs related to B&G WS320 anemometer.
65309 is about signal strenght when using wireless sensor.
65312 is about battery status and charging for the same sensor.
Captured with Yacht Devices YDNU-02