Cg sync for ghost 4.0 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs https://github.com/TryGhost/Team/issues/221 TryGhost/Ghost@26e20d2 - The default engine for Casper shipping with Ghost v4 has to match up. This way it uses all the correct APIs
Dark mode is disabled by default, but can be enabled by adding a class dark-mode to html element.
refs https://github.com/TryGhost/Team/issues/332 refs TryGhost/gscan@870a09b - The {{@labs.members}} always evaluates to "true" starting with Ghost 4.0 and will be "null" coercing to "false" starting Ghost 5.0 - Enabled all conditionals be default to pass the build in main Ghost repository. These changes should be reviewed - special attentio to the left out RSS feed which was surrounded with {{unless @labs.members}} condition
no issue - we previously needed a config.json to provide the GitHub token for publishing new Casper releases - this commit removes the need for this file by pulling the token from the environment variable, which everyone in the Core team has set up
no issue - the renovate.json file was removed to clean up the repository files, but we still want Renovate to update dependencies - Renovate allows us to configure the config in the package.json, so this commit moves the previous contents there
no issue - the check needs to be inverted to ensure we're being passed a token
refs https://github.com/TryGhost/Team/issues/509 refs TryGhost/gscan@b0f80be - @site.lang property is being deprecated with Ghsot 4.0 and @site.locale is advised to be used instead
no issue - not important, but it saves manually entering it during the release process - Casper is only compatible with Ghost 4.0 moving forwards
no issue - these weren't rebuilt when changing the code
no issue - Casper is now ready for 4.0 so this commit merges the branch in to try and keep the Git history as clean as possible
no issue - as of 4.0, we're shipping tags with the preceding `v`, but this script ignored that and so the release was incorrect - this commit updates the tagName to have the preceding `v`
…#763) The tag archive header shares the same classes as post cards, but have different elements. This changes the selector to target article.post-card, which ignores header.post-card
…t#761) Co-authored-by: John O'Nolan <[email protected]>
Co-authored-by: John O'Nolan <[email protected]>
Co-authored-by: John O'Nolan <[email protected]>
Highly specific styles for traditional Instagram embeds Co-authored-by: John O'Nolan <[email protected]>
Co-authored-by: John O'Nolan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.