Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive v1 contracts if blockheight is passed V2 require height #1586

Open
wants to merge 6 commits into
base: api-breakers
Choose a base branch
from

Conversation

peterjan
Copy link
Member

@peterjan peterjan commented Sep 27, 2024

NOTE: can't write an integration test for it because the host doesn't allow renewing contracts after the V2 require height, this means that the contractor will always archive contracts because they are expired and we can't mine passed the V2 require height

Fixes #1545

@peterjan peterjan changed the base branch from dev to api-breakers September 27, 2024 11:40
@peterjan peterjan self-assigned this Oct 1, 2024
@peterjan peterjan marked this pull request as ready for review October 3, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

shouldArchive should archive v1 contracts beyond the v2 require height
1 participant