Fix scan error when fetching archived contracts #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8maninger
reviewed
Oct 9, 2024
| @@ -12,7 +12,7 @@ type Scanner interface { | |||
|
|
|||
| type ContractRow struct { | |||
| FCID FileContractID | |||
| HostID int64 | |||
| HostID *int64 | |||
There was a problem hiding this comment.
Will a contract ever not be attached to a host where nil would make sense?
There was a problem hiding this comment.
Yes, we merged contracts and archived_contracts into a single contracts table. If a host we used before goes offline for an extended period of time we remove it (RemoveOfflineHosts), so it's possible for a row in the contracts table to point to a host that no longer exists.
Edit: sorry, bit too fast on the trigger, we nullify the host_id when we archive a contract, we do that so we can remove offline hosts without breaking the FK check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a scan error when fetching contracts using the new filter mode
api.ContractFilterModeArchived.Related #1545