Collection of PRs that require UI update #1512
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `offset` and `limit` consistently. Turns out there were various places where we were needlessly trying to decode the offset and limit it in the handler. I chose to rename `offset` to `encryptionoffset` in the worker because that would be inconsistent with the normal `offset` usage. Since the option is named `EncryptionOffset` I feel it's fine to name the query string parameter the same way. Fixes #1567
I occasionally saw "superfluous response.WriteHeader call" in testing and decided to trace it down today. Turns out it comes from the renew handler. We also assert `MinNewCollateral` can't be zero but I think it can.
Continuation of #1068 Addressed some of the concerns in the reviews: - Move `PrometheusMetric` method to original type where possible - Move `writeResponse` logic to api package - Improve handling slices of Prometheus marshallable types - Disable type checking in `jape`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary branch to merge PRs into that break the UI. Once this is complete, we can update the UI in a single version, update the version in this branche's
go.mod, test that it is working and then merge everything at once.Required Updates:
/account/:id/resetdriftmoved to worker (Refactor worker to derive its own account for each host #1464)/search/hoststo/hosts(Deprecate/hostsin favour of/search/hosts#1484)/wallet(Remove some deprecated code and address some v2 API changes #1478)/search/objectsand/objects/*pathto/listobjects(Merge objects endpoints #1493)/autopilot/hostand/autopilot/hosts(Remove host endpoints from autopilot #1508)/slab/:key/objectsand integrated it into the list objects endpoint (Update list object options, add slab encryption key and make bucket optional #1517)