Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VisuallyHidden] Reintroduce VisuallyHidden top position #5208

Merged
merged 3 commits into from
Feb 28, 2022
Merged

[VisuallyHidden] Reintroduce VisuallyHidden top position #5208

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6fe93f9
reintroduce VisuallyHidden top position
emma-boardman Feb 23, 2022
70935e8
add docs
emma-boardman Feb 23, 2022
9792958
add comment
emma-boardman Feb 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions UNRELEASED.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ Use [the changelog guidelines](/documentation/Versioning%20and%20changelog.md) t

### Bug fixes

- Reintroduced `top: 0` to `VisuallyHidden` CSS to prevent unexpected scrolling when using a `Sheet` ([#5208](https://github.com/Shopify/polaris-react/pull/5208))
- Fixed `Form` > `VisuallyHidden` markup causing excessive vertical whitespace ([#5181](https://github.com/Shopify/polaris-react/pull/5181))

### Documentation
Expand Down
1 change: 1 addition & 0 deletions src/styles/shared/_accessibility.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
// Need to make sure we override any existing styles.
// stylelint-disable declaration-no-important
position: absolute !important;
top: 0;
emma-boardman marked this conversation as resolved.
Show resolved Hide resolved
width: 1px !important;
height: 1px !important;
margin: 0 !important;
Expand Down