Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use possibly deprecated RuboCop api #375

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

Earlopain
Copy link
Contributor

See https://github.com/rubocop/rubocop/blob/8fc2afce8e9379ffa3aeb87f23593ca5b1f8c02c/lib/rubocop/cop/team.rb#L15-L16

There is no deprecation at the moment, but it was added as a temporary measure: rubocop/rubocop#8088. Also see rubocop/rubocop#13244

RuboCop must be >= 1.0, so this is fine

Copy link
Member

@etiennebarrie etiennebarrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@etiennebarrie etiennebarrie merged commit 255fdb4 into Shopify:main Sep 18, 2024
6 checks passed
@Earlopain Earlopain deleted the team-new branch September 18, 2024 17:12
@Earlopain Earlopain restored the team-new branch September 18, 2024 17:12
@Earlopain Earlopain deleted the team-new branch September 18, 2024 17:12
@Mangara Mangara mentioned this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants