fix crash when no test

ShockedPlot7560 · Dec 17, 2023 · 68d1bc9 · 68d1bc9
1 parent 143e6ac
commit 68d1bc9
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 7 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -62,7 +62,7 @@ jobs:
       fail-fast: false
       matrix:
         image: [ubuntu-20.04]
-        suittest: ["normal", "with_plugin"]
+        suittest: ["normal", "with_plugin", "no_test"]
         php: ["8.1", "8.2", "8.3"]
 
     steps:

diff --git a/src/PmmpUnit.php b/src/PmmpUnit.php
@@ -92,7 +92,11 @@ protected function onEnable() : void {
 			$this->test->run()
 				->then(function () {
 					$this->finish();
-				});
+				})
+                ->catch(function (\Throwable $e) {
+                    $this->getLogger()->logException($e);
+                    $this->finish();
+                });
 		}), 0);
 	}
 
@@ -147,11 +151,16 @@ private function finish(bool $close = true) : void {
 			}
 		}
 
-		$this->getLogger()->notice("Total tests: " . count($results));
-		$this->getLogger()->info("  Total passed: " . count($passedTests) . " (" . round(count($passedTests) / count($results) * 100, 2) . "%)");
-		$this->getLogger()->info((count($failedTests) > 0 ? "§4" : "") . "  Total failed: " . count($failedTests) . " (" . round(count($failedTests) / count($results) * 100, 2) . "%)");
-		$this->getLogger()->info((count($fatalErrors) > 0 ? "§c" : "") . "  Total fatal: " . count($fatalErrors) . " (" . round(count($fatalErrors) / count($results) * 100, 2) . "%)");
-		$this->getLogger()->info($heatmap);
+        if(count($results) > 0) {
+            $this->getLogger()->notice("Total tests: " . count($results));
+            $this->getLogger()->info("  Total passed: " . count($passedTests) . " (" . round(count($passedTests) / count($results) * 100, 2) . "%)");
+            $this->getLogger()->info((count($failedTests) > 0 ? "§4" : "") . "  Total failed: " . count($failedTests) . " (" . round(count($failedTests) / count($results) * 100, 2) . "%)");
+            $this->getLogger()->info((count($fatalErrors) > 0 ? "§c" : "") . "  Total fatal: " . count($fatalErrors) . " (" . round(count($fatalErrors) / count($results) * 100, 2) . "%)");
+            $this->getLogger()->info($heatmap);
+        } else {
+            $this->getLogger()->notice("No tests were run.");
+        }
+
 
 		$this->getLogger()->notice("=== ============ ===");
 

diff --git a/tests/pmmpunit/suitetest/no_test/config/.gitkeep b/tests/pmmpunit/suitetest/no_test/config/.gitkeep
diff --git a/tests/pmmpunit/suitetest/no_test/plugins/.gitkeep b/tests/pmmpunit/suitetest/no_test/plugins/.gitkeep