Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name col/field to bookmarks api endpoints #144

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

katerina-kossler
Copy link
Contributor

part of: #127

changes:

  • add name to bookmark-related endpoints
  • include col in db setup for docker image

notes:

Copy link
Member

@richardxia richardxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, assuming that the code compiles and the existing tests pass. I don't know if we have any tests for these endpoints, but if not, it'd be good to write some, though no need to block this PR, especially because we didn't have them previously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants