-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1604 add covid jobs and covid financial categories #539
base: master
Are you sure you want to change the base?
1604 add covid jobs and covid financial categories #539
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One thing -- if you could separate your changes into another file that would be helpful, as we're not going to rerun the entirety of the script. Also please add each service to the parent category as well, that's required for search to work properly.
db/sql/add-covid-categories.sql
Outdated
|
||
|
||
-- Covid Finance Category and Subcategories | ||
delete from category_relationships(parent_id,child_id) values (1000003,1100010); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete from category_relationships where parent_id=1000003 and child_id=1100010;
db/sql/covid-jobs-and-finance.sql
Outdated
|
||
-- Covid Finance Category and Subcategories | ||
delete from category_relationships(parent_id,child_id) where parent_id=1000003 and child_id=1100010; | ||
delete from category_services where category_id=1000003 and service_id=1070 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
table name is categories_services, and you are missing a semicolon.
…oved covid-shelter.sql from this branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
db/sql/covid-shelter.sql
Outdated
(1000009, '04-OCT-20', '04-OCT-20', 'Covid-shelter', 't', null, 'f'); | ||
|
||
insert into categories (id, created_at, updated_at, name, top_level, vocabulary, featured) values | ||
(1100035, '04-OCT-20', '04-OCT-20', 'Job Boa', 'f', null, 'f'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be a newline at the end of the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also why don't you pull out the shelter stuff until it's complete so I can merge the rest in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh did this not get removed from this branch? I'm looking at db/sql/ and I don't still see it...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Ran SQL script on staging to add new Covid-jobs category and modify Covid-finances category to match with new hierarchy, Added Covid Jobs and Covid Finances to db populate script in local dev.