Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1604 add covid jobs and covid financial categories #539

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

meltingmelon
Copy link
Contributor

@meltingmelon meltingmelon commented Oct 1, 2020

Ran SQL script on staging to add new Covid-jobs category and modify Covid-finances category to match with new hierarchy, Added Covid Jobs and Covid Finances to db populate script in local dev.

Copy link
Contributor

@jjfreund jjfreund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One thing -- if you could separate your changes into another file that would be helpful, as we're not going to rerun the entirety of the script. Also please add each service to the parent category as well, that's required for search to work properly.



-- Covid Finance Category and Subcategories
delete from category_relationships(parent_id,child_id) values (1000003,1100010);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete from category_relationships where parent_id=1000003 and child_id=1100010;


-- Covid Finance Category and Subcategories
delete from category_relationships(parent_id,child_id) where parent_id=1000003 and child_id=1100010;
delete from category_services where category_id=1000003 and service_id=1070
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

table name is categories_services, and you are missing a semicolon.

Copy link
Contributor

@jjfreund jjfreund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

(1000009, '04-OCT-20', '04-OCT-20', 'Covid-shelter', 't', null, 'f');

insert into categories (id, created_at, updated_at, name, top_level, vocabulary, featured) values
(1100035, '04-OCT-20', '04-OCT-20', 'Job Boa', 'f', null, 'f');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be a newline at the end of the file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also why don't you pull out the shelter stuff until it's complete so I can merge the rest in?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh did this not get removed from this branch? I'm looking at db/sql/ and I don't still see it...

Copy link
Contributor

@jjfreund jjfreund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants