feat(Core): migrate engine extensions to rust core (WIP) #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lity. - Restores parity for Udisks2 - Restores parity for SteamRemovableMedia - Fixes a bug with the game loading overlay appearing after OpenGamepadUI is detected by Gamescope. - Properly load devices and profiles in InputPlumber
pastaq
reviewed
Sep 28, 2024
| @@ -59,7 +59,7 @@ var _persist_path: String = "/".join([_data_dir, "launcher.json"]) | |||
| var _persist_data: Dictionary = {"version": 1} | |||
| var _ogui_window_id := 0 | |||
| var should_manage_overlay := true | |||
| var logger := Log.get_logger("LaunchManager", Log.LEVEL.INFO) | |||
pastaq
reviewed
Sep 28, 2024
core/systems/launcher/running_app.gd
Outdated
| @@ -102,7 +102,7 @@ var steam_close_tries := 0 | |||
| ## Flag for if OGUI should manage this app. Set to false if app is launched | |||
| ## outside OGUI and we just want to track it. | |||
| var is_ogui_managed: bool = true | |||
| var logger := Log.get_logger("RunningApp", Log.LEVEL.INFO) | |||
| var logger := Log.get_logger("RunningApp", Log.LEVEL.TRACE) | |||
pastaq
reviewed
Sep 28, 2024
| @@ -111,6 +111,7 @@ func _init(item: LibraryLaunchItem, process_id: int, dsp: String) -> void: | |||
| display = dsp | |||
|
|
|||
|
|
|||
| # TODO: Only call this on window creation/deletion | |||
- Add input focus change for steam/opengameapdui - Add InputPlumber node to OverlayModeInputManager so it can process dbus signals - Reconnect to all composite devices when InputPlumber starts - Preload all state modules, fixes visibility of overlay... Somehow.
ShadowApex
force-pushed
the
shadowapex/core-refactor
branch
from
748e8e8
to
5a96942
Compare
pastaq
reviewed
Sep 30, 2024
| logger.debug("Focusable apps changed from", from, "to", to) | ||
| # If focusable apps has changed and the currently focused app no longer exists, | ||
| # remove the manual focus | ||
| var baselayer_app := _xwayland_primary.baselayer_app |
There was a problem hiding this comment.
What is a base layer app and how is it defined?
pastaq
reviewed
Sep 30, 2024
| @@ -522,7 +522,7 @@ dependencies = [ | |||
| [[package]] | |||
| name = "gamescope-x11-client" | |||
| version = "0.1.0" | |||
| source = "git+https://github.com/ShadowBlip/gamescope-x11-client?branch=main#3a0cbe64ba60dffb5ad85f156101c056f764e659" | |||
| source = "git+https://github.com/ShadowBlip/gamescope-x11-client?branch=main#deeab5be067bfbb2add2446d8c7fbcbeba7c8c7f" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.