Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WavPack: Add a TODO for unknown sample counts #366

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

Serial-ATA
Copy link
Owner

WavPack supports unknown sample counts:

typedef struct {
    // ...
    uint32_t total_samples;     // total samples for entire file, but this is
                                // only valid if block_index == 0 and a value of
                                // -1 indicates unknown length
    // ...
} WavpackHeader;

(https://web.archive.org/web/20150424062034/https://www.wavpack.com/file_format.txt)

This wasn't checked for before, so it would produce wild results for the duration. I don't plan on actually fixing this anytime soon, I'd just rather produce no results than wrong results.

@Serial-ATA Serial-ATA merged commit 25dd1e7 into main Apr 6, 2024
12 checks passed
@Serial-ATA Serial-ATA deleted the wavpack-unknown-samples branch April 6, 2024 04:43
@Serial-ATA Serial-ATA added this to the 0.19.0 milestone Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant